Versione: 5.1.4.2 (x64) Build ID: f99d75f39f1c57ebdd7ffc5f42867c12031db97a Thread CPU: 4; Versione SO: Windows 6.19; Resa interfaccia: predefinito; Versione locale: it-IT (it_IT) 1. Open a Dialog Window 2. Hold CRTL for a while and look at widgets Result: widgets start flashing (redrawing). Expected behavior: not flashing It happens with every modifier key, such as CTRL (both ones) or ALT (both ones)
Still present in Version 5.2.1.2
Tried with image properties, open and save dialogs. No flashing. Win 7 Pro 64-bit Version: 5.3.0.0.alpha0+ Build ID: 7da2f3ce9f7b049c177a735a146dae84a764d3f7 CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; TinderBox: Win-x86@42, Branch:master, Time: 2016-10-04_03:49:06 Locale: fi-FI (fi_FI); Calc: CL Win 7 Pro 64-bit, Version: 5.2.2.2 (x64) Build ID: 8f96e87c890bf8fa77463cd4b640a2312823f3ad CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; Locale: fi-FI (fi_FI); Calc: CL
I can still replicate the bug on another (customer's) PC, BUT this time it happens if you press repeatedly CRTL or ALT, and NOT keeping (one of) them pressed. File Open and Save are not common dialog windows from LO, they are MS Windows File Requesters, unless differently specified in LO options. So they're not the right dialogs to test, while Image Properties is a good one. I used that for this test. Win7 Home Premium 64bit Italiaan Versione: 5.2.2.2 (x64) Build ID: …f3ad (I'm copying manually ;) Thread CPU: 2; Versione SO: Windows 6.1; Resa interfaccia: predefinito; Versione locale: it-IT (it_IT); Calc: group
If I go to image Properties (which takes me to Wrap tab by default): -pressing Alt repeatedly causes "None" to flash, -pressing Alt or Ctrl continuously causes flickering to run through all the widgets. Even the menu bar is flickering if I run my mouse pointer across. No flickering in native Windows Open/Save/etc. dialogs, though. Opetions menu doesn't flicker, either.
(In reply to Aron Budea from comment #5) > If I go to image Properties (which takes me to Wrap tab by default): > -pressing Alt repeatedly causes "None" to flash, > -pressing Alt or Ctrl continuously causes flickering to run through all the > widgets. > > Even the menu bar is flickering if I run my mouse pointer across. > > No flickering in native Windows Open/Save/etc. dialogs, though. Opetions > menu doesn't flicker, either. So you can confirm my bug: what's the version of LO?
(In reply to Gabriele Ponzo from comment #6) > So you can confirm my bug: what's the version of LO? I can reproduce this even in current 5.2.3.3 and 5.3beta1 versions in Windows 7.
Bibisected using repo bibisect-win32-5.1. ca38e903b89635d06e61ef907e796827091d55ad is the first bad commit commit ca38e903b89635d06e61ef907e796827091d55ad Author: Norbert Thiebaud <nthiebaud@gmail.com> Date: Sun Jul 26 21:04:31 2015 -0700 source 74407aef94b6d8dfdd69891c4a6e578587ef3e71 # bad: [05d11632892a322664fb52bac90b2598b7fb7544] source 5616d22b57a9a5e57d545e912e029162a230829b # good: [c1efd324c6ad448ac9edb030dc9738b9e6899e4d] source ab465b90f6c6da5595393a0ba73f33a1e71a2b65 git bisect start '05d11632892a322664fb52bac90b2598b7fb7544' 'oldest' # bad: [97526ab777da7e58ce283c05498262ecdd4d6f7f] source 4ea70f87f7a2b61eda6e5ab1f48debf6fcfadc1f git bisect bad 97526ab777da7e58ce283c05498262ecdd4d6f7f # good: [2202cdaa0eae3f646f1285a0ea45934edeb26e8a] source a88bf8fd10c42a15e5d6e66da656889c82b4933a git bisect good 2202cdaa0eae3f646f1285a0ea45934edeb26e8a # bad: [13169de9868218d603d1ae26805ebf4583e7d628] source 6f98a0ab51cc5c860576b4ad44478b438cc5a5eb git bisect bad 13169de9868218d603d1ae26805ebf4583e7d628 # bad: [a2e73a5257c1598c1070ec06105c1dffaef3842e] source 01d1165572f53ca50c626fa036343932c1e8c5db git bisect bad a2e73a5257c1598c1070ec06105c1dffaef3842e # bad: [86fd3c7e02672e1b346387131ea4a1d63c93bc7b] source 9ce5cfff0af69bfff7512b806e0e5a39ab1566f8 git bisect bad 86fd3c7e02672e1b346387131ea4a1d63c93bc7b # bad: [df347a4b442f6231c963e7d2333053b35597ced4] source be6c884feb389ec6931e1853aa421d5bccd69f12 git bisect bad df347a4b442f6231c963e7d2333053b35597ced4 # bad: [4fbbe57eb46f8fcee3991ec0c46d3f9dd9bbd115] source 122a15f4a6c09d35db58fe3a7b943b5ea79cbe65 git bisect bad 4fbbe57eb46f8fcee3991ec0c46d3f9dd9bbd115 # good: [9eec228510ef0f771928d69171fe3784cd55b6c2] source 2e99e4e11d33679aed674eea0d6054d16d39d6df git bisect good 9eec228510ef0f771928d69171fe3784cd55b6c2 # good: [b853f72a7f279f47c3006ce40b8e4686b7daa19e] source 90334404e2bf9ced73f60793dc90056e1fd99938 git bisect good b853f72a7f279f47c3006ce40b8e4686b7daa19e # bad: [2eaf5b6a4715d4c5ff8399e74fd8f74c4a81c260] source b54f22302731784d7bd462bf2cef0621eea8b22a git bisect bad 2eaf5b6a4715d4c5ff8399e74fd8f74c4a81c260 # good: [4a0b70cd60a6775d84919d7b44ad7d2e56431552] source 24c50b6029791ed9fd14ed2c75351acd6c55e895 git bisect good 4a0b70cd60a6775d84919d7b44ad7d2e56431552 # good: [904a0c16aec072f969c42f22d73b8aff41ee849d] source 9a11e59e5699c5eb0854355d3dd3848bc895545c git bisect good 904a0c16aec072f969c42f22d73b8aff41ee849d # bad: [ca38e903b89635d06e61ef907e796827091d55ad] source 74407aef94b6d8dfdd69891c4a6e578587ef3e71 git bisect bad ca38e903b89635d06e61ef907e796827091d55ad # good: [d02651f9320435a7e9421fefa3fc8bac9926c466] source 40ade8d04380083e383d6a6e50e5c254fcde2b2f git bisect good d02651f9320435a7e9421fefa3fc8bac9926c466 # first bad commit: [ca38e903b89635d06e61ef907e796827091d55ad] source 74407aef94b6d8dfdd69891c4a6e578587ef3e71
This is a regression, and the flickering during a modifier key being pressed started with the commit referenced below. Yes, the commit says gtk, yet it affects Windows. It seems to have gotten slightly better over time, but still very noticeable (not sure if reverse-bibisecting that commit is worth, let me know if it is). Adding Cc: to Simon Long as author, also adding Cc: to Caolán McNamara as committer. Please take a look sometimes. https://cgit.freedesktop.org/libreoffice/core/commit/?id=74407aef94b6d8dfdd69891c4a6e578587ef3e71 author Simon Long <simon@raspberrypi.org> 2015-07-08 17:02:50 (GMT) committer Caolán McNamara <caolanm@redhat.com> 2015-07-09 15:07:24 (GMT) "tdf#92630 Enable auto-accelerator behaviour for gtk"
I can't reproduce this with gen under Linux, probably hardware too fast or better rendering, but I have a fair idea how to simply fix it for the platforms that don't have auto accels
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f67dc04cfdd9e63a45ec6c8bc00829bce8f17d4b Resolves: tdf#101972 skip invalidating labels on alt if autoaccel is disabled It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I'm reasonably confident that will stop flickering on windows, backports for 5-3 and 5-2 in gerrit
I first confirmed the flickering in an older build. With the fresh build the flickering is gone. Win 10 64-bit Version: 5.4.0.0.alpha0+ Build ID: 54d5b1828ec73d0475e0ddb6e31394a7e1904a1b CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; TinderBox: Win-x86@42, Branch:master, Time: 2017-02-09_23:41:14 Locale: fi-FI (fi_FI); Calc: group
Many thanks to all of you guys! I'm proud to have been useful to improve the code. Thanks particularly to Caolan for taking into consideration this bug, surely not blocking, but still important for the cleanliness of code.
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-5-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=1cd4913603d112b47106939de350aaca3143d37a&h=libreoffice-5-3 Resolves: tdf#101972 skip invalidating labels on alt if autoaccel is disabled It will be available in 5.3.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-5-2": http://cgit.freedesktop.org/libreoffice/core/commit/?id=0d8746c091ce3e70340c431da8d35d453d2b3b2c&h=libreoffice-5-2 Resolves: tdf#101972 skip invalidating labels on alt if autoaccel is disabled It will be available in 5.2.6. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.