Download it now!
Bug 102054 - Allow access and modifying of comment with keyboard
Summary: Allow access and modifying of comment with keyboard
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks: UNO-Command-New a11y Writer-Comments
  Show dependency treegraph
 
Reported: 2016-09-10 23:28 UTC by Yousuf Philips (jay) (retired)
Modified: 2018-11-05 00:31 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2016-09-10 23:28:36 UTC
Presently there isnt a means of editing comments in writer unless you use the mouse, so we need a feature similar to Calc's Sheet > Cell Comment > Edit Comment (uno:EditAnnotation) that would be provide the same functionality.
Comment 1 Cor Nouws 2016-09-12 19:13:36 UTC
indeed - thanks
Comment 2 Gülşah Köse 2016-10-27 10:56:28 UTC
(In reply to Yousuf Philips (jay) from comment #0)
For writer:

Ctrl+Alt+C adds comment. If there is already a comment there, same combination edits comment. Mouse pointer unneeded for editing.

For Calc:

Ctrl+Alt+C adds comment but if there is already a comment there, same combination doesn't edit comment. Mouse pointer needed for editing.

Can you describe your bug report again? I want to fix it but i couldn't understand well.
Comment 3 Yousuf Philips (jay) (retired) 2016-10-27 12:12:19 UTC
(In reply to Gülşah Köse from comment #2)
> Ctrl+Alt+C adds comment. If there is already a comment there, same
> combination edits comment. Mouse pointer unneeded for editing.

The same combination doesnt edit the comment when the cursor is within a comment range and only works if the cursor is right above the triangle pointer of the comment selection text.

Example
1) Type 'My name is Gulsah'
2) Add a comment around 'name is'
3) Place the cursor between the two words
4) Pressing ctrl+alt+c will create a new comment
5) Place the cursor at the end of the two words and the border highlight around the selection will appear and combination then works

The intended uno command intends to be active in both scenarios of the example above and be contextual, so that it is disabled when not on or within a comment, which will allow the uno command to be added to the context menu. This is the same as the 'Edit Link' command (.uno:EditHyperlink) for when the cursor is within a hyperlink.

> For Calc:
> 
> Ctrl+Alt+C adds comment but if there is already a comment there, same
> combination doesn't edit comment. Mouse pointer needed for editing.

Would be good to make this combination work in Calc to edit comments as well.
Comment 4 Gülşah Köse 2016-10-27 16:29:24 UTC
To implement that two scenerio i think i need to seperate "insert comment" and "edit comment" commands. Because in the current state of LO Ctrl+Alt+C's behaviour is true. I am working on now.
Comment 5 Yousuf Philips (jay) (retired) 2016-10-28 12:42:00 UTC
Yes a separate "edit comment" command would be needed. :D
Comment 6 Yousuf Philips (jay) (retired) 2016-11-30 22:12:12 UTC
Patch that Gulsah previously submitted - https://gerrit.libreoffice.org/#/c/30332/
Comment 7 funnyjokes 2018-05-17 04:16:11 UTC Comment hidden (spam)