Bug 102379 - Notebookbar need more icons for buttons
Summary: Notebookbar need more icons for buttons
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsDevEval
Depends on:
Blocks: Notebookbar
  Show dependency treegraph
 
Reported: 2016-09-23 08:21 UTC by Volga
Modified: 2018-10-23 19:03 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Volga 2016-09-23 08:21:59 UTC
User-Agent:       Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:49.0) Gecko/20100101 Firefox/49.0
Build Identifier: dec8da2a9aadbb6758ee76c30582bd8620a10ecb

LODev 5.3 alpha0 have already implemented Notebookbar, but some buttons does not have their icons. For Example, on LO Writer, “File”, “References”, “Review” and “View” tabs has some large buttons without icon.

Reproducible: Always







Reset User Profile?No
Comment 1 Yousuf Philips (jay) (retired) 2016-09-23 19:46:22 UTC
As we never had icons for any of these commands, they are naturally not present in the notebookbar.
Comment 2 Heiko Tietze 2016-09-24 08:07:42 UTC
All functions need icons, CC'ing the master of Breeze.

We should also make sure that the classic main menu will not get affected by this. Additional icons must not be shown there. -> needsDevEval +Samuel
Comment 3 andreas_k 2016-09-24 09:21:54 UTC
Which sizes are needed and can i test it in the daily master.
Comment 4 Volga 2016-09-24 17:15:05 UTC
Some of them can be create via making derivative work of existed icons, I think this require some designers who can do it.
Comment 5 Yousuf Philips (jay) (retired) 2016-09-24 19:05:10 UTC
(In reply to Heiko Tietze from comment #2)
> All functions need icons, CC'ing the master of Breeze.

Yes all toolbar buttons require icons.

> We should also make sure that the classic main menu will not get affected by
> this. Additional icons must not be shown there. -> needsDevEval +Samuel

Yes this is the major problem and i had asked about this issue previously, but nobody provided me with an answer of being able to disable an icon in the menus (main menu + context menu).

(In reply to andreas_k from comment #3)
> Which sizes are needed and can i test it in the daily master.

For the tabbed extended toolbar, we need 16px for small buttons and 24px for large buttons. For the non-tabbed extended toolbar, we need 32px for extra large buttons.

Here are the icons that are needed for the time being.

Home Tab
--------
Edit Style - sc_editstyle.png (likely link with sc_editdoc.png)
Go To Page - sc_gotopage.png (you can duplicate the concept from tango which i recently did)

Review Tab
----------
Word Count - *c_wordcountdialog.png (icon concept from ms word - http://666kb.com/i/bbbxdzcmnsix5jd02.jpg)
Merge Track Changed Document -*c_mergedocuments.png (similar concept to *c_comparedocuments.png and is enabled in the track changes toolbar now)

View Tab
----------
Normal View - lc_printlayout.png (take design concept from galaxy and have it similar to the icon below which is already done)
Web View - lc_browseview.png (icon is present by disabled in .xcu, 32px icon needs to be fixed to look similar to 24px icon)
Rulers - sc_ruler.png
Show Comments - lc_showannotations.png (needs a new icon and its incorrect to have the insert comment icon with the same icon using links.txt)

The buttons in the extended toolbar will be undergoing changes, so we shouldnt create icons that wont end up being used.
Comment 6 andreas_k 2018-10-23 19:03:48 UTC
All notebookbar actions will have an icon, only when the label is more descriptable than an icon can be, it will have no icon, but in general all actions will get an icon.