Bug 102778 - Insufficient contrast with dark GTK3 theme in bottom status bar
Summary: Insufficient contrast with dark GTK3 theme in bottom status bar
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
5.2.1.2 release
Hardware: All Linux (All)
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:5.3.0
Keywords:
Depends on:
Blocks: GTK3
  Show dependency treegraph
 
Reported: 2016-09-28 23:35 UTC by Jeremy Bicha
Modified: 2016-11-14 18:18 UTC (History)
0 users

See Also:
Crash report or crash signature:


Attachments
Screenshot with Adwaita Dark (68.87 KB, image/png)
2016-09-28 23:35 UTC, Jeremy Bicha
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Bicha 2016-09-28 23:35:03 UTC
Created attachment 127711 [details]
Screenshot with Adwaita Dark

- Ubuntu 16.10 Beta amd64
- LibreOffice 1:5.2.1~rc2-0ubuntu1 (Ubuntu package) which now defaults to GTK3 in Ubuntu 16.10+
- gnome-themes-standard 3.20.2-3ubuntu1
This screenshot was taken with GTK+ 3.22.0-0ubuntu1~yakkety0 from the GNOME3 Staging PPA although I believe it affects Ubuntu's GTK 3.20 also.

There is not enough contrast in the symbolic icons in the bottom status bar with a dark theme which makes them difficult to see.

I set the theme to Adwaita but I used gnome-tweak-tool to enable the "Global Dark Theme" option.

Screenshot attached.
Comment 1 Caolán McNamara 2016-10-18 15:02:12 UTC
These are just pngs so there isn't a oneliner fix anyway and its not really gtk3 specific as I look at how they work
Comment 2 Caolán McNamara 2016-10-19 11:55:48 UTC
Here's what I suggest, basically as briefly discussed on the mailing list recently...

If the dark variant of the gtk theme is requested (or if an icon theme is selected in gnome which is suffixed "dark") then by default fallback in LibreOffice to our only dark icon theme.
Comment 3 Commit Notification 2016-10-19 12:00:21 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=75544eb042ab3fc79dd6104749a32af7e180c116

Resolves: tdf#102778 by default use breeze_dark when dark themes are requested

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Caolán McNamara 2016-10-19 12:05:58 UTC
Best I can do for now until we move to something like using svg icons sources with symbolic color names we can replace with the theme colors.