Bug 103099 - Paragraph style - line spacing - proportional: wrong spacing when set to <100% on first line of paragraph
Summary: Paragraph style - line spacing - proportional: wrong spacing when set to <100...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.2.0.4 release
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
: 127556 161053 (view as bug list)
Depends on:
Blocks: Paragraph-Line-Spacing
  Show dependency treegraph
 
Reported: 2016-10-10 21:04 UTC by bugzilla
Modified: 2024-08-26 15:02 UTC (History)
8 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot of Dejavu Sans 57% proportional line spacing (210.35 KB, image/jpeg)
2016-10-24 12:02 UTC, Buovjaga
Details
Test file with Dejavu Sans (15.80 KB, application/vnd.oasis.opendocument.text)
2016-10-24 12:04 UTC, Buovjaga
Details
Screenshot of Hebrew 95% proportional line spacing (610.43 KB, image/png)
2024-04-28 14:27 UTC, bdjnks
Details

Note You need to log in before you can comment on or make changes to this bug.
Description bugzilla 2016-10-10 21:04:27 UTC
Description:
When Paragraph style - line spacing - proportional  is set to value smaller than 100%, the spacing between first and the second line in the paragraph is wrong, it is too small. The second line ends up being too close to the first line. It looks very odd.

It gets worse is you set "line spacing"- proportional to really small values, like 60% or 50%.

Other lines in a paragraph seem to be spaced correctly.

All fonts are affected, but on some fonts the error is less noticable.
With "liberation serif", the error is smaller. 

Try "Deja Vu Sans", line height: proportional-57%
Try "liberation serif", line height: proportional-50%

On some fonts, like "Charis Sil", it gets really annoying at proportional-90%

Steps to Reproduce:
1. Type a paragraph of text having at least 3 lines, (5 is better)
2. Change the font of the paragraph to "liberation serif"
3. Right click on the paragraph, select "edit style", go to "Indents and spacing", "Line spacing", set it to "Proportional":50%, click OK

Actual Results:  
The spacing between the first and the second line is smaller than spacing between second and third line.

Expected Results:
All lines spaced evenly.


Reproducible: Always

User Profile Reset: No

Additional Info:
There is an additional bug. When line spacing: proportional is set to small values (<40%), the (rendering of) first line of text get clipped on it's upper part.


User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:49.0) Gecko/20100101 Firefox/49.0
Comment 1 Buovjaga 2016-10-24 12:02:30 UTC
Created attachment 128203 [details]
Screenshot of Dejavu Sans 57% proportional line spacing

Repro.

Win 7 Pro 64-bit Version: 5.3.0.0.alpha1+
Build ID: 02e6c1c95993740e0dbea724b3014348c4b6559d
CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; 
TinderBox: Win-x86@39, Branch:master, Time: 2016-10-24_04:01:05
Locale: fi-FI (fi_FI); Calc: group
Comment 2 Buovjaga 2016-10-24 12:04:37 UTC
Created attachment 128204 [details]
Test file with Dejavu Sans

Created with 5.3
Comment 3 Buovjaga 2016-10-24 12:06:33 UTC
Btw. in LibO 3.5 all the rows are smashed together, even a bit more than the 1st and 2nd line in newer versions.
Comment 4 QA Administrators 2017-10-25 08:58:02 UTC Comment hidden (obsolete)
Comment 5 Thomas Lendo 2017-11-07 21:22:05 UTC
Still repro.

Version: 6.0.0.0.alpha1+
Build ID: 1f8c3e3b78e0abb96d06a51eca354ae7ade5deb2
CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk3; 
Locale: de-DE (de_DE.UTF-8); Calc: group
build from 2017-11-01
Comment 6 Olivier Tilloy 2018-08-29 12:56:41 UTC
This has been reported in Ubuntu (https://launchpad.net/bugs/1772430) and I can reliably reproduce the issue with 6.0.6 and 6.1.0.
Comment 7 QA Administrators 2019-09-02 09:26:08 UTC Comment hidden (obsolete)
Comment 8 vaaydayaasra 2019-09-12 12:30:04 UTC
Still reproducible on:

Version: 6.3.1.2 (x64)
Build ID: b79626edf0065ac373bd1df5c28bd630b4424273
Threads CPU : 4; OS : Windows 6.3; UI Render : par défaut; VCL: win; 
Locale : fr-FR (fr_FR); Langue IHM : fr-FR
Calc: threaded
Comment 9 Dieter 2019-09-18 06:28:11 UTC
*** Bug 127556 has been marked as a duplicate of this bug. ***
Comment 10 QA Administrators 2021-09-18 03:25:57 UTC Comment hidden (obsolete)
Comment 11 justus-dev 2022-04-15 10:08:36 UTC
I just observed this bug in LibreOffice 7.3.2.
Comment 12 QA Administrators 2024-04-15 03:15:20 UTC Comment hidden (obsolete)
Comment 13 bdjnks 2024-04-28 02:35:53 UTC
I can reproduce this bug today with the following.

Version: 24.2.2.2 (X86_64) / LibreOffice Community
Build ID: 420(Build:2)
CPU threads: 16; OS: Linux 6.8; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
24.2.2-3
Calc: threaded
Comment 14 bdjnks 2024-04-28 14:27:07 UTC
Created attachment 193881 [details]
Screenshot of Hebrew 95% proportional line spacing

This is not limited to English, nor to small values. Here you can see it affecting Hebrew noticeably at 95% proportional line spacing.
Comment 15 László Németh 2024-08-26 13:47:01 UTC
*** Bug 161053 has been marked as a duplicate of this bug. ***
Comment 16 László Németh 2024-08-26 13:47:50 UTC
(In reply to raal from comment #3)
> This seems to have begun at the below commit in bibisect repository/OS
> bibisect-44max.
> Adding Cc: to Michael Stahl ; Could you possibly take a look at this one?
> Thanks
>  21e12db3d1ea89affb3f5c97bf3625a8be70f1a7 is the first bad commit
> commit 21e12db3d1ea89affb3f5c97bf3625a8be70f1a7
> Author: Matthew Francis <mjay.francis@gmail.com>
> Date:   Sun Mar 15 04:52:13 2015 +0800
> 
>     source-hash-4e223fab04279c3583689e69fa1342966e81de36
>     
>     commit 4e223fab04279c3583689e69fa1342966e81de36
>     Author:     Michael Stahl <mstahl@redhat.com>
>     AuthorDate: Wed Oct 29 23:50:21 2014 +0100
>     Commit:     Michael Stahl <mstahl@redhat.com>
>     CommitDate: Thu Oct 30 15:56:07 2014 +0100
>     
>         fdo#79602: sw: fix text formatting of proportional line space < 100%
>     
>         SwTxtFormatter::CalcRealHeight(): Apply the special treatment of <
> 100%
>         line space shrinking the Height() of the line only to the first line
>         in a paragraph; the subsequent ones are shrunk again (to the square
> of
>         the desired proportion) 30 lines later.
>     
>         Also set the Ascent of the line, as the wrong base-line causes the
> lower
>         part of the line to be clipped.
>     
>         (regression from 42532d42bfcdb12df86376cda009e8e315a82153)
>     
>         Change-Id: I0424396263293deaa318c80eedc2237cdb01b22b