tools/source/fsys/urlobj.cxx:4450:1: error: V502 Perhaps the '?:' operator works in a different way than it was expected. The '?:' operator has a lower priority than the '&&' operator. Source code is eStyle = eStyle & FSYS_VOS && m_aHost.isPresent() && m_aHost.getLength() > 0 ? FSYS_VOS : hasDosVolume(eStyle) || ((eStyle & FSYS_DOS) != 0 && m_aHost.isPresent() && m_aHost.getLength() > 0) ? FSYS_DOS : eStyle & FSYS_UNX && (!m_aHost.isPresent() || m_aHost.getLength() == 0) ? FSYS_UNX : FSysStyle(0); What a mess ! Nested ternary operators are worth avoiding. Suggest recode with a clear sequence of if-then-else statements.
I don't know if we can consider this as a bug since there's no buggy behavior but if interested, you can help to clean up this mess! :-) (see https://wiki.documentfoundation.org/Development/GetInvolved)
moving it to NEW as per comment 1. Besides, adding keyword easyHack.
I have fixed this issue. Please review here https://gerrit.libreoffice.org/32453
(In reply to saurabh kukade from comment #3) > I have fixed this issue. Please review here > https://gerrit.libreoffice.org/32453 The patch has been commented by several people. Could you give an update or do you want to abandon this one? (in this case, please unassign yourself to make the bugtracker available again).
A polite ping, still working on this patch ?
(In reply to jan iversen from comment #5) > A polite ping, still working on this patch ? Not sure if you mean me (dcb) but the patch looks reasonably ok to me.
(In reply to dcb314 from comment #6) > (In reply to jan iversen from comment #5) > > A polite ping, still working on this patch ? > > Not sure if you mean me (dcb) but the patch looks reasonably ok to me. I suppose Jan's comment was concerning the assignee of this bugtracker, "Sandeep Dubey".
(In reply to Julien Nabet from comment #7) > (In reply to dcb314 from comment #6) > > (In reply to jan iversen from comment #5) > > > A polite ping, still working on this patch ? > > > > Not sure if you mean me (dcb) but the patch looks reasonably ok to me. > > I suppose Jan's comment was concerning the assignee of this bugtracker, > "Sandeep Dubey". Yes it was, we try to make sure bugs are being worked on, or set back to NEW.
(In reply to jani from comment #8) > (In reply to Julien Nabet from comment #7) > > (In reply to dcb314 from comment #6) > > > (In reply to jan iversen from comment #5) > > > > A polite ping, still working on this patch ? > > > > > > Not sure if you mean me (dcb) but the patch looks reasonably ok to me. > > > > I suppose Jan's comment was concerning the assignee of this bugtracker, > > "Sandeep Dubey". > > Yes it was, we try to make sure bugs are being worked on, or set back to NEW. It has been too long since any progress been made. Can I upload patch with with clear sequence of if-else code ?
(In reply to Fakabbir amin from comment #9) > (In reply to jani from comment #8) > > (In reply to Julien Nabet from comment #7) > > > (In reply to dcb314 from comment #6) > > > > (In reply to jan iversen from comment #5) > > > > > A polite ping, still working on this patch ? > > > > > > > > Not sure if you mean me (dcb) but the patch looks reasonably ok to me. > > > > > > I suppose Jan's comment was concerning the assignee of this bugtracker, > > > "Sandeep Dubey". > > > > Yes it was, we try to make sure bugs are being worked on, or set back to NEW. > > It has been too long since any progress been made. Can I upload patch with > with clear sequence of if-else code ? Patches are always welcome, but in gerrit please.
Fakabbir Amin committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=2af4221bd1f91b4cef22d6b1867a250e3780f6e3 tdf#103221 recoded clear if-else sequence It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Let's put this one to FIXED since the commit has been pushed on master sources.