Bug 103280 - [Gtk3] rounding in radio buttons in options is crooked in gtk+ 3.22 with default Adwiata theme.
Summary: [Gtk3] rounding in radio buttons in options is crooked in gtk+ 3.22 with defa...
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
5.3.0.0.alpha0+
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
: 111815 (view as bug list)
Depends on:
Blocks: gtk3-themeing
  Show dependency treegraph
 
Reported: 2016-10-17 14:57 UTC by Hussam Al-Tayeb
Modified: 2020-01-20 12:19 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
LO radio button in options. (5.84 KB, image/png)
2016-10-17 14:58 UTC, Hussam Al-Tayeb
Details
native gtk3 radio button. Notice the perfect rounding. (3.04 KB, image/png)
2016-10-17 15:00 UTC, Hussam Al-Tayeb
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Hussam Al-Tayeb 2016-10-17 14:57:39 UTC
The rounding in radio buttons in options is crooked in gtk+ 3.22 with default Adwiata theme. (You probably need gtk+ 3.22 and the default Adwaita theme to notice this)
Parts of the circle don't show.
I have attached screenshots of LO radio buttons in options and native gtk3 radio buttons.
Comment 1 Hussam Al-Tayeb 2016-10-17 14:58:52 UTC
Created attachment 128045 [details]
LO radio button in options.
Comment 2 Hussam Al-Tayeb 2016-10-17 15:00:32 UTC
Created attachment 128046 [details]
native gtk3 radio button. Notice the perfect rounding.
Comment 3 Hussam Al-Tayeb 2016-10-18 12:52:12 UTC
Caolán, Hi, I hope you don't mind that I cc'ed you here. I noticed you were fixing quite a few UI issues in the GTK3 port.

It looks as LO is drawing short straight line to approximate a circle in the radio button instead of a actual rounded circle.
Comment 4 Caolán McNamara 2016-10-19 12:08:09 UTC
gtk3-demo draws them (foreign drawing example) pretty much like we draw them here, but ours do look cruddy compared to those for some reason
Comment 5 Hussam Al-Tayeb 2016-10-27 19:21:53 UTC
(In reply to Caolán McNamara from comment #4)
> gtk3-demo draws them (foreign drawing example) pretty much like we draw them
> here, but ours do look cruddy compared to those for some reason

If you look closely and zoom in, it looks like libreoffice is drawing short straight lines to approximate a circle. The shorter the straight lines, the closer it is to a circle. But it will still look cruddy.
Comment 6 Hussam Al-Tayeb 2016-10-27 20:02:31 UTC
My drawing skills are not good but this is how it is being rendered http://i.imgur.com/TqZNd7s.png
Comment 7 Caolán McNamara 2017-08-15 09:52:09 UTC
*** Bug 111815 has been marked as a duplicate of this bug. ***
Comment 8 Hussam Al-Tayeb 2017-08-15 10:08:44 UTC
Are you sure? This one is about radio buttons.
The other one is about the checkbox mark.
Comment 9 Caolán McNamara 2017-08-15 13:38:38 UTC
its all the same problem, they're not at exactly their ideal/natural size so the rendering looks a little cruddy
Comment 10 QA Administrators 2018-09-09 02:39:35 UTC Comment hidden (obsolete)
Comment 11 Hussam Al-Tayeb 2018-09-09 03:14:38 UTC
Version: 6.2.0.0.alpha0+
Build ID: 025abb05385a1dc6219d48390cd4b783988cb409
CPU threads: 4; OS: Linux 4.14; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); Calc: threaded
Comment 12 QA Administrators 2019-09-10 08:45:34 UTC Comment hidden (obsolete)
Comment 13 Hussam Al-Tayeb 2019-12-20 10:59:03 UTC
I don't think there is any need to keep this bug open as the options dialog window has been welded in LO 6.4
Comment 14 Xisco Faulí 2020-01-20 12:19:55 UTC
(In reply to Hussam Al-Tayeb from comment #13)
> I don't think there is any need to keep this bug open as the options dialog
> window has been welded in LO 6.4

Thanks for retesting the issue with the latest version.
Setting to RESOLVED WORKSFORME since the commit fixing this issue hasn't been
identified.