Bug 103774 - Support more arguments via POST to the editor frame
Summary: Support more arguments via POST to the editor frame
Status: RESOLVED WONTFIX
Alias: None
Product: LibreOffice Online
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-08 08:12 UTC by Aleksander Machniak
Modified: 2019-03-13 12:23 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aleksander Machniak 2016-11-08 08:12:20 UTC 
I'm sending 'lang' parameter set to 'de' as POST to the editor iframe. However, the editor is still in English.

loolwsd-1.9.6-1.
Comment 1 Aleksander Machniak 2016-11-08 08:18:55 UTC 
Oh, I see it works with GET, but could you support 'lang' via POST? Or in more general, support all GET arguments to be passed as POST.
Comment 2 Olivier Hallot 2016-11-08 12:31:20 UTC 
Hello Aleksander,

Thank you for reporting the bug.
Unfortunately without clear steps to reproduce it, we cannot track down the origin of the problem.
Please provide a clearer set of step-by-step instructions on how to reproduce the problem.
I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' once the steps are provided
If you want a direct conversation with LibreOffice Online developers, please access https://webchat.freenode.net/?channels=#libreoffice-dev
Comment 3 Aleksander Machniak 2016-11-08 12:35:00 UTC 
Olivier, please don't! The description is clear. Maybe you didn't notice this is about LibreOffice Online product? Looks like you have no idea about the Online product, otherwise you wouldn't ask for clarification here.
Comment 4 Michael Meeks 2016-11-08 13:32:03 UTC 
Thanks for the report - this was fixed shortly after the release:

commit 5f9a9264e4c824a805c182b061f11a9869123fe1
Author: Pranav Kant <pranavk@collabora.co.uk>
Date:   Mon Nov 7 17:59:42 2016 +0530

    Fix menubar l10n, set String.locale before requiring loleaflet
    
    Change-Id: Ic5a22f05d0a11bd0485d0c88dfa34dcc6bfe29cf
Comment 5 Aleksander Machniak 2016-11-08 13:36:46 UTC 
Are you sure I can POST 'lang'? Please, read my Comment 1.
Comment 6 Andras Timar 2016-11-08 13:41:05 UTC 
Yeah, Michael referred to another bug that we fixed. Is there a reason, that you cannot use GET? It might be possible to use POST, but wouldn't it complicate things?
Comment 7 Aleksander Machniak 2016-11-08 13:51:07 UTC 
With WOPI backend I already use POST for access_token. Of course I could use both GET and POST, but having all arguments in POST would be clearer from my perspective.
Comment 8 Aron Budea 2019-03-13 12:23:38 UTC 
The conclusion is that according to the WOPI specification, only token-related parameters are supposed to be part of the POST, please use GET for the others. Therefore closing this as WONTFIX.