Download it now!
Bug 103965 - Increase/Decrease Paragraph Spacing doesn't get disabled in read-only sections
Summary: Increase/Decrease Paragraph Spacing doesn't get disabled in read-only sections
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.0.0.0.beta1
Hardware: All All
: medium normal
Assignee: Mike Kaganski
URL:
Whiteboard: target:5.3.0
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-16 23:32 UTC by Mike Kaganski
Modified: 2016-11-17 10:09 UTC (History)
0 users

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kaganski 2016-11-16 23:32:08 UTC
When cursor is in read-only area, all paragraph/character edit buttons/menu items get disabled, except Increase/Decrease Paragraph Spacing.

To reproduce, create a new writer document, add a section that is protected (or alternatively, insert a table and protect its cells), and put cursor to the protected area. The "Increase/Decrease Paragraph Spacing" items on Formatting toolbar, on Properties sidebar, and in Format->Spacing menu are not disabled. Using them makes relevant changes, which is wrong.

Reproducible with Version: 5.3.0.0.alpha1+
Build ID: 722ea624fdb1ae3c5009b9dadc5699dc3724c649
CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; Layout Engine: new; 
Locale: ru-RU (ru_RU); Calc: group;

Version: 5.0.0.0.beta1
Build ID: 0a16c3dda4150008d9be6f24cbd15ac198d116d3
Locale: ru-RU (ru_RU);

Version: 5.2.3.2
Build ID: 1:5.2.3~rc2-0ubuntu1~xenial1
CPU Threads: 1; OS Version: Linux 4.4; UI Render: default; 
Locale: en-US (en_US.UTF-8); Calc: group
Comment 1 Mike Kaganski 2016-11-17 00:09:34 UTC
A patch has been submitted for review: https://gerrit.libreoffice.org/30916
Comment 2 Commit Notification 2016-11-17 09:12:40 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=c87e31f763b9c7e0372a13096be205a5930b6498

tdf#103965: set DisableFlags for SID_PARASPACE_INCREASE/DECREASE

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.