Edit - Track changes - Show Changes ALWAYS has a check-box in it. Clicking on Show changes does turn off showing changes, but cannot turn it back on.
Regression in 5.3 development branch. Tested using Linux daily dbgutil narrowed it down to around Sept 8 and then I identified the regression as
author Noel Grandin <email@example.com> 2016-09-07 11:10:40 (GMT)
convert nsRedlineMode_t to typed_flags
because these two lines are not equivalent:
- bSet = (eMode & nMask) == nMask;
+ bSet = bool(eMode & nMask);
attachment 114078 [details] can be used as a test document. It already has Show Changes enabled, with green changes showing. Turning Show Changes off DOES turn off the green marking, but the checkbox still indicates that Show Changes is active, and clicking on it again does not shown the green changes again.
Steps to Reproduce:
1. Edit Menu - track changes - show changes is marked as enabled. click on it.
go back and it is still marked as enabled.
On a new document - show changes should not even be enabled. Clicking on it should have marked it as disabled anyways.
User Profile Reset: No
Major severity - an important feature is completely disabled.
User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:49.0) Gecko/20100101 Firefox/49.0
Moving it to NEW as the problematic commit has been identified
Justin Luth committed a patch related to this issue.
It has been pushed to "master":
tdf#104023 - fix wrong boolean logic for RedlineFlags
It will be available in 5.3.0.
The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
Affected users are encouraged to test the fix and report feedback.
Let me note that probably the same issue is present in LO-Fresh 5.2.3 (Arch Linux). In "Edit" menu there is only a (non-functional) check-box menu entry "Track changes", (not) working as described in the bug report; there is no sub-menu with relevant entries, as in LO-Still 5.1.6.
So if Fresh is going to see further releases before 5.3, this should be fixed there as well.
(In reply to Nikos Platis from comment #3)
> Let me note that probably the same issue is present in LO-Fresh 5.2.3 (Arch
Hi Nikos. I just checked and "convert nsRedlineMode_t to typed_flags" was never back-ported to LO 5.2.
> In "Edit" menu there is only a (non-functional) check-box menu entry
> "Track changes", (not) working as described in the bug report; there is no
> sub-menu with relevant entries, as in LO-Still 5.1.6.
Are you refering to using Writer? In Ubuntu and LO 220.127.116.11 I do have a submenu for Edit - Track Changes (and no checkbox for Edit - Track Changes). The same is true for the libreoffice-5-2 development branch. So I cannot replicate your report.
> So if Fresh is going to see further releases before 5.3, this should be
> fixed there as well.
Probably it will be best to create a new bug report if you can consistently replicate the problem - since it will be a different one than was fixed by this bug-report.
In 5.3, there is also a VIEW - Track Changes which is a simple checkbox. It is identical to EDIT - Track Changes - Show. Perhaps that is what Nikos was looking at.