Bug Hunting Session
Bug 104201 - FILEOPEN: PPTX: Group solid fill is not imported
Summary: FILEOPEN: PPTX: Group solid fill is not imported
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
5.3.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Tamás Zolnai
URL:
Whiteboard: target:5.4.0 target:5.3.0.1 target:5.2.4
Keywords: filter:pptx, regression
Depends on:
Blocks: PPTX-Limitations
  Show dependency treegraph
 
Reported: 2016-11-27 13:54 UTC by Xisco Faulí
Modified: 2016-11-28 09:30 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2016-11-27 13:54:24 UTC
Steps:
1. Open attachment 60264 [details]

Observed behaviour: Group solid fill not imported

Reproduced in:

Version: 5.3.0.0.beta1
Build ID: 690f553ecb3efd19143acbf01f3af4e289e94536
CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: gtk2; Layout Engine: new; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

but not in

Version: 5.3.0.0.alpha1+
Build ID: ada8a2123ea655142be74a11c23e042a0109d5f8
CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: gtk3; Layout Engine: new; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group
Comment 1 Xisco Faulí 2016-11-27 13:57:21 UTC
Hello Zolnai,
Could it be that 5c7f3e4a7190bf9821bed102f96a926c9a894e59 or 8d613870b2cd2e3e4396b4fa97dbd8080fda8f52 instroduced this regression?
Comment 2 Tamás Zolnai 2016-11-27 14:39:28 UTC
Yes, it is related to 8d613870b2cd2e3e4396b4fa97dbd8080fda8f52.
Thanks, for finding this bug this early. I'll fix it.
Comment 3 Commit Notification 2016-11-27 15:25:37 UTC
Tamás Zolnai committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=7c5aaa254f444d54b9ebf6574f0ccd37af548ee5

tdf#104201: PPTX: Group solid fill is not imported

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2016-11-27 18:53:37 UTC
Tamás Zolnai committed a patch related to this issue.
It has been pushed to "libreoffice-5-3":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=ae79fbd42fd61c878939111a04bca22f84c37e03&h=libreoffice-5-3

tdf#104201: PPTX: Group solid fill is not imported

It will be available in 5.3.0.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Xisco Faulí 2016-11-27 19:15:21 UTC
Verified in

Version: 5.4.0.0.alpha0+
Build ID: 7c5aaa254f444d54b9ebf6574f0ccd37af548ee5
CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group
Comment 6 Commit Notification 2016-11-27 21:01:27 UTC
Tamás Zolnai committed a patch related to this issue.
It has been pushed to "libreoffice-5-2":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=32395df104106743e5599f14b19a9a887c1a78ec&h=libreoffice-5-2

tdf#104201: PPTX: Group solid fill is not imported

It will be available in 5.2.4.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Timur 2016-11-28 09:30:17 UTC
When adding attachments from existing bugs, please add Bug number it's in ("open attachment from Bug ...") and add that bug to See Also. 

When setting to Fixed or Verified, please remove "bibisectRequest" (I did it now). It may stay for WFM, if backport makes sense.