Bug 104213 - Copy/Insert a row causes Calc to freeze
Summary: Copy/Insert a row causes Calc to freeze
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
5.1.4.2 release
Hardware: x86-64 (AMD64) All
: medium major
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, haveBacktrace, perf, regression
Depends on:
Blocks: Paste
  Show dependency tree / graph
 
Reported: 2016-11-28 08:23 UTC by John
Modified: 2023-01-20 22:50 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:

Attachments
Edited version of my original file (537.71 KB, application/vnd.oasis.opendocument.spreadsheet)
2016-11-28 08:28 UTC, John 		Details
a backtrace (14.45 KB, text/plain)
2016-12-11 11:12 UTC, fiftyigfuci_f_mi 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John 2016-11-28 08:23:35 UTC 
Description:
Commencing version 5.1.4.2 (the problem does not appear in v5.0.6.3 or earlier)
The problem appears in both Windows 86 and Linux DEBS 64 versions.
A spreadsheet with several thousand rows and several columns with some cells containing expanding sum formula (=SUM($D$5:H8537))
Selecting an entire row, any row, copying and pasting either into (overwrite) or insert (move rows down) causes Calc to freeze for a few minutes with the message Not Responding if the mouse button is pressed.
From Task Manager Calc is using 25% of the CPU for the entire time.
Strange: If a blank row in inserted somewhere in the sheet and then the above (Ctl Alt drag drop) operation is done on any row below the insertion the problem does not occur.

Steps to Reproduce:
1.Using a spreadsheet with several thousand rows and several columns with some cells containing expanding sum formula (=SUM($D$5:H8537))
2. Selecting an entire row, any row, copying and pasting either into (overwrite) or insert (move rows down)
3.Calc to freeze for a few minutes with the message Not Responding if the mouse button is pressed.

Actual Results:  
Calc to freeze for a few minutes with the message Not Responding if the mouse button is pressed. Depending on the number of rows and which row is chosen Calc will freeze for a number of minutes.

Expected Results:
In version 5.0.6.3 there is no freezing, the chosen row is inserted with all following rows moved down.


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 5.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/49.0.2623.112 Safari/537.36
Comment 1 John 2016-11-28 08:28:16 UTC 
Created attachment 129060 [details]
Edited version of my original file
Comment 2 John 2016-11-28 08:31:13 UTC 
The problem occurs under Windows and Linux (Ubuntu)
Comment 3 Buovjaga 2016-12-01 19:06:33 UTC 
Yep, confirmed.

Arch Linux 64-bit, KDE Plasma 5
Version: 5.4.0.0.alpha0+
Build ID: 368de904974b18dc5a8d237e046c0ed005f7c85d
CPU Threads: 8; OS Version: Linux 4.8; UI Render: default; VCL: kde4; Layout Engine: new; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on November 26th 2016
Comment 4 raal 2016-12-04 17:25:58 UTC 
This seems to have begun at the below commit.
Adding Cc: to Jan Holesovsky; Could you possibly take a look at this one? Thanks

author	Jan Holesovsky <kendy@collabora.com>	2015-11-30 11:32:16 (GMT)
committer	Jan Holesovsky <kendy@collabora.com>	2015-12-03 15:22:11 (GMT)
commit f73ecff91d759b54836f47771a297958b4a70300 (patch)
tree c9aaa71d24ff28289926f57890cc52946892d846
parent 9b6d78cc68e9dc644bf2d06b358049de3cd3ee8f (diff)
sc interperter: Turn it on for a subset of operations by default.
 5b31f1fea0e61aa851acf6d11713755a7a5f8d8c is the first bad commit
commit 5b31f1fea0e61aa851acf6d11713755a7a5f8d8c
Author: Norbert Thiebaud <nthiebaud@gmail.com>
Date:   Thu Dec 3 07:44:50 2015 -0800

    source f73ecff91d759b54836f47771a297958b4a70300
 git bisect log
# bad: [05d11632892a322664fb52bac90b2598b7fb7544] source 5616d22b57a9a5e57d545e912e029162a230829b
# good: [c1efd324c6ad448ac9edb030dc9738b9e6899e4d] source ab465b90f6c6da5595393a0ba73f33a1e71a2b65
git bisect start 'origin/master' 'oldest'
# good: [97526ab777da7e58ce283c05498262ecdd4d6f7f] source 4ea70f87f7a2b61eda6e5ab1f48debf6fcfadc1f
git bisect good 97526ab777da7e58ce283c05498262ecdd4d6f7f
# good: [86fee7ded76d9c2756ccab6aef160a2d7fab0ab6] source 1b62841b1859ae3443e2bf1ebe99ec3d6afb6cc2
git bisect good 86fee7ded76d9c2756ccab6aef160a2d7fab0ab6
# good: [11864a7db429a57aeea021e0b3f1fb1412282d32] source e5b721a14c1c8e5261a70588b30353cbb5bd55c6
git bisect good 11864a7db429a57aeea021e0b3f1fb1412282d32
# good: [7d52a87c0aa24498584ec522705cfae3a3a5a038] source 479df22d0b4b0e0393fcf621e7380b38415bcef8
git bisect good 7d52a87c0aa24498584ec522705cfae3a3a5a038
# good: [bea538a879f50238f4c9c6f05e3d7390db9d76c7] source 7289a140fc68dc898ba2b2357cc960968195f236
git bisect good bea538a879f50238f4c9c6f05e3d7390db9d76c7
# bad: [cec09749b56c5e7f080ebfc289f7ea713baf2a65] source 86a52d6bb9ba75a1a56589bce0cb51a72a46ed19
git bisect bad cec09749b56c5e7f080ebfc289f7ea713baf2a65
# bad: [62ef89cfa8c6509f4d35b4ee8f146057f73f4d87] source 5da95d887ce8f0de9d19a886ebad733be02ae5a5
git bisect bad 62ef89cfa8c6509f4d35b4ee8f146057f73f4d87
# bad: [b0b315a8b5530ee99664ac00a5eaa5ef7b89673a] source 53054959a12edc6510f51b94ddc9b73d27aedaf6
git bisect bad b0b315a8b5530ee99664ac00a5eaa5ef7b89673a
# good: [e53c2f51687d99e04ddaff38e292b1858ff1cba8] source 4d0e46143dcf94f7131911162eaf359662758646
git bisect good e53c2f51687d99e04ddaff38e292b1858ff1cba8
# bad: [e1e8865e8407a0f2e917f903aa4572b54fc7f59c] source e83b77681d8716e0e044ecaf53bbdd4d083f1137
git bisect bad e1e8865e8407a0f2e917f903aa4572b54fc7f59c
# good: [47d228d8a1787388e507899974fa2a9c4a93f946] source 9b6d78cc68e9dc644bf2d06b358049de3cd3ee8f
git bisect good 47d228d8a1787388e507899974fa2a9c4a93f946
# bad: [cebfac28ed04722950e843f3adfd4b2ddb382b53] source 09c79f966b83bf37936681c32f87fb6157b3edb2
git bisect bad cebfac28ed04722950e843f3adfd4b2ddb382b53
# bad: [5b31f1fea0e61aa851acf6d11713755a7a5f8d8c] source f73ecff91d759b54836f47771a297958b4a70300
git bisect bad 5b31f1fea0e61aa851acf6d11713755a7a5f8d8c
# first bad commit: [5b31f1fea0e61aa851acf6d11713755a7a5f8d8c] source f73ecff91d759b54836f47771a297958b4a70300
Comment 5 fiftyigfuci_f_mi 2016-12-11 11:12:15 UTC 
Created attachment 129486 [details]
a backtrace

I confirmed on my dev build:
Version: 5.4.0.0.alpha0+
Build ID: f35d29c8388744be1f95ec4acfca12eec706911a
CPU Threads: 2; OS Version: Linux 4.9; UI Render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); Calc: group
Comment 6 QA Administrators 2018-07-04 02:49:08 UTC Comment hidden (obsolete)
Comment 7 Xavier Van Wijmeersch 2018-07-04 18:29:56 UTC 
tested with original file, works fine.
suggest to upgrade to 6.0.5.2

Version: 5.4.8.0.0+
Build ID: cc68977f1be22ac0f4a15eb37e05ccba13a7a554
CPU threads: 8; OS: Linux 4.14; UI render: default; VCL: kde4; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:libreoffice-5-4, Time: 2018-05-12_11:32:19
Locale: nl-BE (en_US.UTF-8); Calc: group

Version: 6.0.4.2
Build ID: 9b0d9b32d5dcda91d2f1a96dc04c645c450872bf
CPU threads: 8; OS: Linux 4.14; UI render: default; VCL: kde4; 
Locale: nl-BE (en_US.UTF-8); Calc: group
Comment 8 Buovjaga 2018-07-04 19:23:31 UTC 
(In reply to Xavier Van Wijmeersch from comment #7)
> tested with original file, works fine.
> suggest to upgrade to 6.0.5.2

Yep, works now.

Arch Linux 64-bit
Version: 6.2.0.0.alpha0+
Build ID: ea39c41fdf63191579d25f327db81db14862251c
CPU threads: 8; OS: Linux 4.17; UI render: default; VCL: gtk3; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group threaded
Built on July 4th 2018