Bug 104261 - VIEWING: Calc comment indicator (red square or magenta triangle) only partly displayed before redraw
Summary: VIEWING: Calc comment indicator (red square or magenta triangle) only partly ...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
(earliest affected) release
Hardware: All All
: low trivial
Assignee: Not Assigned
Keywords: bibisected, regression
: 117136 158651 (view as bug list)
Depends on:
Blocks: Calc-Comments
  Show dependency treegraph
Reported: 2016-11-29 16:51 UTC by Telesto
Modified: 2024-01-08 23:51 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:

Screenshot (13.46 KB, image/png)
2018-05-28 13:53 UTC, Telesto

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2016-11-29 16:51:07 UTC
When inserting a comment the shape of the comment indicator is a small bar.
When inserting a new comment, the shape of the first one changes to a red square

Screencast: attachment 129088 [details]

Steps to Reproduce:
1.Create a comment in cell D4
2.Create a comment in cell D5

Notice the changing shape of comment indicator in cell D4. It doesn't happen with (for example) cell A1 and A2

Actual Results:  
First red bar subsequently red square

Expected Results:
Always red square

Reproducible: Always

User Profile Reset: YES

Additional Info:
Found in:
Version: (x64)
Build ID: 7aa2b5a041df8e71a435cccbc79ee13799ec9138
CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; Layout Engine: new; 
TinderBox: Win-x86_64@62-TDF, Branch:MASTER, Time: 2016-11-24_11:40:27
Locale: nl-NL (nl_NL); Calc: CL

and in
Build ID: e8938fd3328e95dcf59dd64e7facd2c7d67c704d
Locale: nl_NL

User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0
Comment 1 Buovjaga 2016-12-02 08:33:32 UTC
Yep, confirmed this is in, but not in

Win 7 Pro 64-bit Version:
Build ID: 142618ecae472e535c582c0fb357d2a9a76655f1
CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2016-11-28_00:46:57
Locale: fi-FI (fi_FI); Calc: group
Comment 2 QA Administrators 2017-12-08 08:08:55 UTC Comment hidden (obsolete)
Comment 3 Chavdar 2017-12-18 19:50:27 UTC

Observed in versions:
- (x64)
- (x64)

Creating a comment on any cell of the first two rows results in a comment indicator with a red square shape. 
It does not matter if it is the first or next comment. First and second rows always result with red square shapped icon.

- (x64)
- (x64)
Windows 10 64
Locale: bg-BG (bg_BG)
Comment 4 raal 2018-04-21 14:10:17 UTC
*** Bug 117136 has been marked as a duplicate of this bug. ***
Comment 5 Buovjaga 2018-05-22 18:28:51 UTC
Works OK now. I confirmed with on the same Windows to be sure.

Version: (x64)
Build ID: 8c07193cec5e09d50b20bc5b107da02a7d8f05a5
CPU threads: 4; OS: Windows 10.0; UI render: default; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-05-17_23:03:56
Locale: fi-FI (fi_FI); Calc: group
Comment 6 Telesto 2018-05-28 13:53:48 UTC
Created attachment 142345 [details]

Build ID: 938ec2597be2e0ad3af2fb99f77de7f87285ad86
CPU threads: 4; OS: Windows 6.3; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-05-25_23:38:38
Locale: nl-NL (nl_NL); Calc: CL
Comment 7 Buovjaga 2018-05-28 14:28:25 UTC
Bibisected to range https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=482f97926e1090c50ef05eed6badf311a7aa02f9...579d9ae1c5873f78dbe0364c83842de8556f6ccb out of which this seems to be the culprit: https://cgit.freedesktop.org/libreoffice/core/commit/?id=902b7e9f192fab45cffc35d81cd0df0373a610ed

commit 902b7e9f192fab45cffc35d81cd0df0373a610ed (patch)
tree 83f39b2c5992647af07bd4c08d3d5a0ed77b07d3
parent a89b8601ce7be0b6dc3f262661ea7802f2c725fd (diff)
draw white border around note marks for fdo#81032
also translate the mark to make cell border visible

Change-Id: Ifa9f3befd1e25a66cc3443a3f33255603feea6a6
Reviewed-on: https://gerrit.libreoffice.org/10135

Adding Laurent to CC
Comment 8 QA Administrators 2019-05-29 02:52:57 UTC Comment hidden (obsolete)
Comment 9 QA Administrators 2021-05-29 04:53:05 UTC Comment hidden (obsolete)
Comment 10 QA Administrators 2023-05-30 03:15:49 UTC Comment hidden (obsolete)
Comment 11 Andreas Heinisch 2023-12-22 13:03:08 UTC
Imho this is a redraw problem because the drawing borders are now correct. So if you try to scroll the borders are redrawn correctly.
Comment 12 Stéphane Guillou (stragu) 2023-12-27 16:21:18 UTC
Also reproduced on Linux with gen VCL plugin, with the red square in 7.5, as well as the new magenta triangle (but more noticeable now) in a recent trunk build:

Version: (X86_64) / LibreOffice Community
Build ID: 40617d867346956588ac023511f31210107217f4
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: x11
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Comment 13 Stéphane Guillou (stragu) 2023-12-27 16:21:57 UTC
*** Bug 158651 has been marked as a duplicate of this bug. ***