Bug 104456 - Inline edits of a cell in collaboration mode conflict between users
Summary: Inline edits of a cell in collaboration mode conflict between users
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice Online
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: high normal
Assignee: Not Assigned
URL:
Whiteboard: target:6.0.0
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-07 08:51 UTC by Georg Greve
Modified: 2018-01-09 18:19 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Georg Greve 2016-12-07 08:51:57 UTC
Situation: Two users editing spreadsheet collaboratively

User 1: Opens cell for inline editing of formula

User 2: Clicks on another cell to work on that while User 1 is doing inline editing

Result: Cell that User 2 is clicking on will be added to the inline edit of User 1

Expected behaviour: User 2 should not actually modify the inline edit of User 1
Comment 1 Michael Meeks 2016-12-09 16:44:13 UTC
Nasty indeed - Marco - can you take a look ?
Comment 2 Marco Cecchetti 2016-12-12 11:56:24 UTC
I reproduced it. Moreover the text entered by User 2 are sent to the cell edited by User 1.

That is due to the fact that when we are in formula mode, ScModel::GetInputHandler() returns always the input handler which is handling the edited formula and not the input handler of the current view.
That is wanted by design, so fixing the problem properly requires to analyze several aspect of formula editing.
Comment 3 Xisco Faulí 2017-07-13 10:40:51 UTC
Setting Assignee back to default. Please assign it back to yourself if you're
still working on this issue
Comment 4 Aron Budea 2018-01-09 18:19:11 UTC
This has been worked around by disabling formula mode for online with multiple editors, which makes editing a bit less convenient (adding cells to the edit formula by clicking on them doesn't work anymore), but gets rid of this bug, which is much more important.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=52f2e70c9ef727a1a638d44fbabe76fc4b5a755a
author		Marco Cecchetti <marco.cecchetti@collabora.com>	2017-09-30 17:51:26 +0200
committer	Julien Nabet <serval2412@yahoo.fr>	2017-11-04 09:30:55 +0100

lok: temporary workaround: disable formula mode for online