Description: Pasting columns from tables to tables works OK if you preselect the destination cells, if not if fails in what seems to be different manners for reasons I was unable to figure out. Steps to Reproduce: 1. Copy a column 2. Paste it inside the same table or another one without preselecting destination cells Actual Results: Column is pasted disordered, missing cells, or other looking random behaviours. Expected Results: Column paste as a column. Reproducible: Always User Profile Reset: No Additional Info: User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.99 Safari/537.36
Created attachment 129459 [details] Weird paste Pasting a column from the first rows to the last ones.
Created attachment 129507 [details] Writer table copy-paste bug Confirmed with 5.3beta1 / Windows 7. Works fine with 5.2.3.3. => regression. To reproduce, open the attached document, and copy the "1"s from 1st column [1, 1, 1, 1, 1] to the 6th row of 3rd, 4th or 5th column: starting with 7th row the entries are shifted to the right, or not visible at all. Bibisected to the commit below. Adding Cc: to Noel Grandin, please take a look. https://cgit.freedesktop.org/libreoffice/core/commit/?id=9e9e7bd3c9dc9a3149436916e747c7f7ee040621 author Noel Grandin <noel@peralex.com> 2016-09-01 07:35:43 (GMT) committer Noel Grandin <noel@peralex.com> 2016-09-01 09:05:21 (GMT) "std::list<sal_uLong> to deque"
commit 9a12b1dd3a4f145d8e3bc4a87c0215f92fbfadd5 Author: Norbert Thiebaud <nthiebaud@gmail.com> Date: Fri Sep 2 16:04:26 2016 -0700 source 9e9e7bd3c9dc9a3149436916e747c7f7ee040621 source 9e9e7bd3c9dc9a3149436916e747c7f7ee040621 # bad: [479ca41474b9720803421ab7717aa69fa6c60528] source f8c463b393885b660500bf4f7f73b4fb90ce2389 # good: [defb73f1c6e2a66dbd21ba89e684f57427e8bc4b] source 5b168b3fa568e48e795234dc5fa454bf24c9805e git bisect start '479ca41474b9720803421ab7717aa69fa6c60528' 'oldest' # good: [1c50425620ffbce30bb57f9ff19ef3c5d20d69f1] source b62f4c2cd9685618fff2270760ce0787880f1c8d git bisect good 1c50425620ffbce30bb57f9ff19ef3c5d20d69f1 # bad: [70770f0ce4d3672d5cd2759605adb44d867e7208] source 0b7e11a2a7ade0b565c18d1deb58c19848f6ceef git bisect bad 70770f0ce4d3672d5cd2759605adb44d867e7208 # skip: [38be3cd61d583b1d04ed67670a7fd7b3de1fa1c3] source dd691312a3a0e0e18ade5c64a3c4f5115c3fde0f git bisect skip 38be3cd61d583b1d04ed67670a7fd7b3de1fa1c3 # bad: [d41638b121c8d158ba962ef2e3f13264bd6ee7e7] source d550f5e6b670e75907be5ea81e8fd5c0f4f67401 git bisect bad d41638b121c8d158ba962ef2e3f13264bd6ee7e7 # skip: [04de14ad269b07bd6eba4d9177caab011456687f] source 3c4dfb872d50413b605fb846dfdebd28947026e8 git bisect skip 04de14ad269b07bd6eba4d9177caab011456687f # bad: [ff6e5cbc0b3995b05299879e1403668f07b1d279] source 3c376151f5445f3a5ca147f962a12235128cfc01 git bisect bad ff6e5cbc0b3995b05299879e1403668f07b1d279 # good: [3d3dfd5d3ed8dafe38049d3bb144157e6673ba42] source e3df93d03c19bc75d1aeb340f056f57db3f4f46c git bisect good 3d3dfd5d3ed8dafe38049d3bb144157e6673ba42 # good: [ce771d941878d12d7bd582769464ee1b38a3a601] source cea58d4c27621725b068d26f3587491322769f45 git bisect good ce771d941878d12d7bd582769464ee1b38a3a601 # good: [2bb438dac1da902139cbda140605bb45303bfd4f] source 813a8944bdb337a0018208381aa30118151872ff git bisect good 2bb438dac1da902139cbda140605bb45303bfd4f # good: [16555f22cb18f159d44b74a0cecc268c4c0f8f9a] source 47a72493a9106a4783bfcb7c34a8cde579a2cba0 git bisect good 16555f22cb18f159d44b74a0cecc268c4c0f8f9a # good: [2f4179cd24966c5c8ac881190f262f91a1971010] source bb932b34f19bf8297549b9741b7cdcfe691ca374 git bisect good 2f4179cd24966c5c8ac881190f262f91a1971010 # good: [1fa2a16158aecb30dbddf42eefa7ea031a40dee1] source 6af36bae47e34c51b0f063e938554db3a922eed6 git bisect good 1fa2a16158aecb30dbddf42eefa7ea031a40dee1 # bad: [9a12b1dd3a4f145d8e3bc4a87c0215f92fbfadd5] source 9e9e7bd3c9dc9a3149436916e747c7f7ee040621 git bisect bad 9a12b1dd3a4f145d8e3bc4a87c0215f92fbfadd5 # first bad commit: [9a12b1dd3a4f145d8e3bc4a87c0215f92fbfadd5] source 9e9e7bd3c9dc9a3149436916e747c7f7ee040621
That commit was reverted in 1a583283d6b58c8951cb52faac82ecb24fdbf1b3 and then re-applied (in a fixed form) in f0fa43ea99ac7564f2cc7ca1d997831808056b68 So this should be fixed already? Unless we have more than one cause.
I tested it with the build recommended on the IRC's chat for this last bughunting sessions, IIRC it was the December 8th daily. If the commit you talk about is more recent, I can download a newer daily and retest tonight.
(In reply to Noel Grandin from comment #4) > That commit was reverted in > 1a583283d6b58c8951cb52faac82ecb24fdbf1b3 > and then re-applied (in a fixed form) in > f0fa43ea99ac7564f2cc7ca1d997831808056b68 > > So this should be fixed already? Unless we have more than one cause. I'd assume the bibisect jumped through that commit range. I just checked with the commit in the repo corresponding to f0fa43ea99ac7564f2cc7ca1d997831808056b68 and the preceding one, and the observation is: -f0fa43ea99ac7564f2cc7ca1d997831808056b68: exhibits the bug, -4c62de279a6783236a5e0811d0733e107c127fe3 (preceding commit): doesn't exhibit the bug. So the fix must've been for a different issue. Julien, are you interested in this one?
I submitted a patch to gerrit review, see https://gerrit.libreoffice.org/#/c/32020/
Julien Nabet committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=14a0d26d6ae0ee59a685c254ec235fea81636475 tdf#104554: fix iterator calculus It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Julien Nabet committed a patch related to this issue. It has been pushed to "libreoffice-5-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=39e6f271d1b0e91456d2dc5f14fad7191ce6bb13&h=libreoffice-5-3 tdf#104554: fix iterator calculus It will be available in 5.3.0.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.