Bug 104734 - FIREBIRD: Add those field types that are not available with FB while they are available with Hsqldb
Summary: FIREBIRD: Add those field types that are not available with FB while they are...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Base (show other bugs)
Version:
(earliest affected)
5.4.0.0.alpha0+ Master
Hardware: All All
: medium enhancement
Assignee: Not Assigned
QA Contact:
URL:
Whiteboard: target:5.4.0 target:5.3.1
Keywords:
Depends on:
Blocks: 51780 Base-Images
  Show dependency treegraph
 
Reported: 2016-12-17 14:33 UTC by m.a.riosv
Modified: 2017-02-07 02:38 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description m.a.riosv 2016-12-17 14:33:51 UTC
Description:
Recently with #103074 fixed, BOOLEAN type was added to Firebird, but several field types are not available with Firebird while they are with Hsqldb.

Name                Hsqldb              Firebird            
Tiny Integer        TINYINT             (1) SMALLINT        
BigInt              BIGINT              BIGINT              
Image               LONGVARBINARY       (1) BLOB            
Binary              VARBINARY           (1) BLOB            
Binary (fix)        BINARY              (1) BLOB            
Memo                LONGVARCHAR         (1) BLOB            
Text (fix)          CHAR                CHAR                
Number              NUMERIC             NUMERIC             
Decimal             DECIMAL             DECIMAL             
Integer             INTEGER             INTEGER             
Small Integer       SMALLINT            SMALLINT            
Float               FLOAT               FLOAT               
Real                REAL                (1) DOUBLE PRECISION
Double              DOUBLE              DOUBLE PRECISION    
Text                VARCHAR             VARCHAR             
Text                VARCHAR_IGNORECASE  VARCHAR (2)         
Yes/No              BOOLEAN             BOOLEAN             
Date                DATE                DATE                
Time                TIME                TIME                
Date/Time           TIMESTAMP           TIMESTAMP           
OTHER               OTHER               (1) BLOB            
BLOB                --                  BLOB                
                                                       
(1) Not defined for FB in base, substitute types to use with FB
(2) Looks it can be achivied by defining a specific Collation for the column.
http://www.firebirdsql.org/file/documentation/reference_manuals/fblangref25-en/html/fblangref25-datatypes-chartypes.html#fblangref25-datatypes-chartypes-collation"


Actual Results:  
Not all field's tupe defined for FB.

Expected Results:
Make easier to transpose a database with the embedded Hsqldb to Firebird dragging the tables, without need to reenter the column definition.


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0
Comment 1 Alex Thurgood 2016-12-19 08:26:17 UTC
Some of this is already being considered in other bug reports, for example, the various CLOB sub-type implementations. Not sure of the bug report number, but it is already in the system.
Comment 2 Commit Notification 2017-01-14 12:14:27 UTC
Tamás Bunth committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=882db8709f4ebc9f170cf743f39434d791b34b14

tdf#70433 tdf#104734 implement sdbc XClob

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Drew Jensen 2017-01-23 04:54:51 UTC
Using 5.4 Alpha0 downloaded yesterday under Linux

With embedded Firebird, using the GUI table designer the following dataypes are _not_ available:
 Image, Binary, Binary fix, Memo, OTHER

A new datatype is available:
 BLOB 



I wasn't sure if those were expected in this build, I kind of thought not reading a couple of comments but thought I'd mention it.

For the other data types I was able to for create a table using all of them, with default scaling information where applicable.

In a few cases the display of column information in the table editor was not what I expected when the table design was opened for editing.
i.e.

FLOAT creating the column UI defaults to Length 7, Decimal places 1; open for editing design displays Length 0, Decimal places 1, which seems to be a display issue, not a change to the column in the database.

DOUBLE creating the column UI defaults to Length 10, Decimal places 1; open for editing design displays Length 0, Decimal places 1, which seems to be a display issue, not a change to the column in the database.

DECIMAL creating the column UI defaults to Length 15, Decimal places 1; but is displayed later as Length 8, Decimal places 1. Here the column in the table was created as scale (8,1) apparently.
Comment 4 Commit Notification 2017-01-24 06:14:00 UTC
Tamás Bunth committed a patch related to this issue.
It has been pushed to "libreoffice-5-3":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=c6d9e749b72c18cb71f7ffc25bb3474ee5c355b4&h=libreoffice-5-3

tdf#70433 tdf#104734 implement sdbc XClob

It will be available in 5.3.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.