Bug 104745 - FILEOPEN: RTF Bullet List Spacing Partially Lost on Import
Summary: FILEOPEN: RTF Bullet List Spacing Partially Lost on Import
Status: RESOLVED DUPLICATE of bug 104016
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.0.0.5 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, filter:rtf, regression
Depends on:
Blocks:
 
Reported: 2016-12-17 23:12 UTC by Luke
Modified: 2017-10-18 17:06 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luke 2016-12-17 23:12:57 UTC 
While troubleshooting Bug 104744, I discovered a more subtle regression in bullet list spacing in RTF importer. In 4.4 we used to correctly handle the spacing like the DOCX format. Now we add an additional .25" to the indent.


Steps to Reproduce:
1. In LO <= 4.4  open attachment 129736 [details]
2. In a build of 4.4-5.3, open attachment 129736 [details] (5.4 master suffers from Bug 104744)


Expected Results:
Indented like Word.

Actual Results:
And additional .25” spacing is added.

Compared to 4.2, Now Format -> Paragraph -> Indent and Spacing: First Line
is missing the -0.25” First Line indent. The DOCX importer has no such issue. (See attachment 129737 [details])
Version: 4.4.7 -  GOOD
Version: 5.0.6 - BAD
Comment 1 Buovjaga 2016-12-18 18:57:13 UTC 
Confirmed (I compared to DOCX).

Arch Linux 64-bit, KDE Plasma 5
Version: 5.2.3.3
Build ID: 5.2.3-1
CPU Threads: 8; OS Version: Linux 4.8; UI Render: default; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Comment 2 raal 2016-12-20 08:43:28 UTC 
This seems to have begun at the below commit.
Adding Cc: to Miklos Vajna; Could you possibly take a look at this one? Thanks

author	Miklos Vajna <vmiklos@collabora.co.uk>	2016-01-26 12:21:28 (GMT)
committer	Miklos Vajna <vmiklos@collabora.co.uk>	2016-01-26 12:21:54 (GMT)
commit 3915bf2dc877d5f1140798e24933db0f21386a4a (patch)
tree bcc1034371fa11953556b3400f520ee593760727
parent 09e46424c510924bae09c6e0147095e2958fa009 (diff)
tdf#95376 DOCX import: fix incorrectly indented tab stops
 564aeb6b0f7decd2b37eb836f3a86585edc76b8b is the first bad commit
commit 564aeb6b0f7decd2b37eb836f3a86585edc76b8b
Author: Norbert Thiebaud <nthiebaud@gmail.com>
Date:   Thu Feb 4 18:25:46 2016 -0800

    source 3915bf2dc877d5f1140798e24933db0f21386a4a
git bisect log
# bad: [6380ca07b05f68dedcaa379302cfe1fa478571c4] source 60b74fe1775e647545d2da1fcc58a4c63ec18aa5
# good: [1f670510f08cb800cbae2a1dd6ea70d3542e4721] source 49c2b9808df8a6b197dec666dfc0cda6321a4306
git bisect start 'origin/master' 'oldest'
# bad: [38f37b8ec1a2d199bb957cfd2581df7d1b273b74] source c0da1080b61a1d51654fc34fdaeba373226065ff
git bisect bad 38f37b8ec1a2d199bb957cfd2581df7d1b273b74
# good: [6998931a34ad75eb555f882fbed223e585548721] source 1fbd073828ef52f5206aed4643226bae9fb85f4f
git bisect good 6998931a34ad75eb555f882fbed223e585548721
# bad: [b283fbadb387862ea0f09058430317906e1a78b5] source 1fc4cb57755cdfb9ab65c112435997874fb057cd
git bisect bad b283fbadb387862ea0f09058430317906e1a78b5
# good: [46053f8f06492a2c806ebd473883548d4a1115d8] source 3de2c3952b9757c40615194811142fd19a9b72eb
git bisect good 46053f8f06492a2c806ebd473883548d4a1115d8
# bad: [67a60fe21b0a52702588b1337face4a45ea247bf] source 3187193a6142b4b1c974ae1e1de572fa74a3c8ee
git bisect bad 67a60fe21b0a52702588b1337face4a45ea247bf
# bad: [0891028d34a92b73ff4cf8989493b185119c25b9] source 626702aa39798715fd252ae8f484233cae8a829f
git bisect bad 0891028d34a92b73ff4cf8989493b185119c25b9
# bad: [f37d54867e72f854f159f68f685fa704d779f053] source 3f9088bae26c726e0632e626b7f8c3ae3ff457ee
git bisect bad f37d54867e72f854f159f68f685fa704d779f053
# bad: [fbfca52a04ffb0d1e5e275d1e2b5226e307d373b] source 7345aaf69a9d88cde3deabb6818a00938d8ad392
git bisect bad fbfca52a04ffb0d1e5e275d1e2b5226e307d373b
# good: [58f5a99891c2423c119c9cc0755f0c1ad6b84ec8] source 7c151f39144b7401a99c7b736a41e5dce4ac4db1
git bisect good 58f5a99891c2423c119c9cc0755f0c1ad6b84ec8
# bad: [70ff5e5b712a95a4f844ad08e77aaa2e7b21a90e] source 7d9ac365039a23b704738b63a54bbbae6e9f6f3a
git bisect bad 70ff5e5b712a95a4f844ad08e77aaa2e7b21a90e
# good: [2b6606bb7423d3588e08ff6a18176c411cf7df3d] source 09e46424c510924bae09c6e0147095e2958fa009
git bisect good 2b6606bb7423d3588e08ff6a18176c411cf7df3d
# bad: [55b3e608904d03e5644de604dee0de61b76b8add] source 93fdb8dc67bf04c7a1e22c8dd15152212799c4f2
git bisect bad 55b3e608904d03e5644de604dee0de61b76b8add
# bad: [564aeb6b0f7decd2b37eb836f3a86585edc76b8b] source 3915bf2dc877d5f1140798e24933db0f21386a4a
git bisect bad 564aeb6b0f7decd2b37eb836f3a86585edc76b8b
# first bad commit: [564aeb6b0f7decd2b37eb836f3a86585edc76b8b] source 3915bf2dc877d5f1140798e24933db0f21386a4a
Comment 3 Xisco Faulí 2016-12-20 11:33:16 UTC 
I guess this can be closed as duplicate of bug 104016 as the root cause is the same...

*** This bug has been marked as a duplicate of bug 104016 ***
Comment 4 Luke 2017-10-18 17:06:22 UTC 
The regression caused by https://cgit.freedesktop.org/libreoffice/core/commit/?id=3915bf

Was fixed before:
Version: 5.2.0.0.alpha0+
Build ID: 00cf864e5d317016d7224c199aa982d07bd70113

However the other bugs causes by this commit have not been fixed. They are tracked in bug 104016