Bug 104767 - Crash if add row in control grid and select row
Summary: Crash if add row in control grid and select row
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: BASIC (show other bugs)
Version:
(earliest affected)
5.2.3.3 release
Hardware: x86-64 (AMD64) Linux (All)
: high critical
Assignee: Julien Nabet
URL:
Whiteboard: target:5.4.0 target:5.3.0.1 target:5.2.5
Keywords: haveBacktrace
Depends on:
Blocks:
 
Reported: 2016-12-19 02:02 UTC by Mauricio Baeza
Modified: 2016-12-20 17:05 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Test control grid for this report (12.16 KB, application/x-7z-compressed)
2016-12-19 02:05 UTC, Mauricio Baeza
Details
backtrace (146.43 KB, text/x-log)
2016-12-19 09:11 UTC, Xisco Faulí
Details
bt with symbols (10.08 KB, text/plain)
2016-12-19 15:50 UTC, Julien Nabet
Details
bt with symbols from IndexOutOfBoundsException (16.17 KB, text/plain)
2016-12-19 20:49 UTC, Julien Nabet
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mauricio Baeza 2016-12-19 02:02:17 UTC
Description:
Wend add control grid in dialog box, always add one row and select, LibreOffice crash, with Basic and Python

Steps to Reproduce:
1. Open Calc doc and activate macros
2. Click in command button Contorl Grid
3. Click in command button "Agregar fila"
4. Select new row

Actual Results:  
LibreOffice crash, if see shell log, you can see:

(soffice:2417): GLib-GObject-WARNING **: gsignal.c:3492: signal name 'selection_changed' is invalid for instance '0x35aeb70' of type 'OOoAtkObjComp'

Expected Results:
LibreOffice not crash


Reproducible: Always

User Profile Reset: Yes

Additional Info:


User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0
Comment 1 Mauricio Baeza 2016-12-19 02:05:53 UTC
Created attachment 129753 [details]
Test control grid for this report
Comment 2 Xisco Faulí 2016-12-19 09:10:00 UTC
Reproduced in

Version: 5.4.0.0.alpha0+
Build ID: 634589b340316ba64b731b4d923c1056be415494
CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

but not in

Version: 5.0.0.0.alpha1+
Build ID: 0db96caf0fcce09b87621c11b584a6d81cc7df86
Locale: ca-ES (ca_ES.UTF-8)

in

Version: 5.4.0.0.alpha0+
Build ID: 634589b340316ba64b731b4d923c1056be415494
CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: gtk2; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

it doesn't crash but it freezes
Comment 3 Xisco Faulí 2016-12-19 09:11:04 UTC
Created attachment 129769 [details]
backtrace
Comment 4 Xisco Faulí 2016-12-19 09:18:45 UTC
Actually it's not a regression. Even in

LibreOffice 3.3.0 
OOO330m19 (Build:6)
tag libreoffice-3.3.0.4

it crashes when selecting 'Eliminar ultima fila' after adding a row
Comment 5 Pierre Lepage 2016-12-19 10:59:55 UTC
The problem does not appear on my version of Office.
Version: 5.2.3.3
Build ID: d54a8868f08a7b39642414cf2c8ef2f228f780cf

There is just a small bug when there is no more line in the table and an attempt is made to remove one.
Comment 6 Julien Nabet 2016-12-19 15:50:04 UTC
Created attachment 129783 [details]
bt with symbols

On pc Debian x86-64 with master sources updated today, I could reproduce the crash but with a different bt.
Comment 7 Julien Nabet 2016-12-19 20:49:57 UTC
Created attachment 129793 [details]
bt with symbols from IndexOutOfBoundsException

I added "catch throw IndexOutOfBoundsException" in gdb to see precisely where's the pb.
Comment 8 Commit Notification 2016-12-19 23:24:21 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=4e1c423358f60f7516a1682c97837edd21addcf3

tdf#104767: Fix calculus of child index in commitTableEvent (accessibility)

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2016-12-19 23:26:58 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-5-3":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=899ea62194d59a69e04823962a3170f762a02e9b&h=libreoffice-5-3

tdf#104767: Fix calculus of child index in commitTableEvent (accessibility)

It will be available in 5.3.0.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Julien Nabet 2016-12-19 23:29:47 UTC
The patch for 5.2 branch is on gerrit review, see https://gerrit.libreoffice.org/#/c/32210/1

Mauricio/Xisco: if you still reproduce the crash with a build which includes https://cgit.freedesktop.org/libreoffice/core/commit/?id=4e1c423358f60f7516a1682c97837edd21addcf3, don't hesitate to reopen this tracker.
Comment 11 Commit Notification 2016-12-20 05:15:50 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-5-2":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=c6f2be29a856044a98615c3209c247de586757f9&h=libreoffice-5-2

tdf#104767: Fix calculus of child index in commitTableEvent (accessibility)

It will be available in 5.2.5.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Xisco Faulí 2016-12-20 10:13:51 UTC
Verified in

Version: 5.4.0.0.alpha0+
Build ID: 4e1c423358f60f7516a1682c97837edd21addcf3
CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

@Julien, Thank you very much for the fast fix!!
Comment 13 Mauricio Baeza 2016-12-20 17:00:01 UTC
Verified in 

Version: 5.2.5.0.0+
Build ID: a4d4fbeb623013f6377b30711ceedb38ea4b49f8
CPU Threads: 8; OS Version: Linux 4.8; UI Render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:libreoffice-5-2, Time: 2016-12-20_09:25:39
Locale: en-US (en_US.UTF-8); Calc: group

Work very fine!!

@Julien, thanks a lot
Comment 14 Julien Nabet 2016-12-20 17:05:35 UTC
Xisco/Mauricio: you're welcome :-)