Bug 104795 - Digital Signature reports !!br0ken!! in Properties dialog
Summary: Digital Signature reports !!br0ken!! in Properties dialog
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
4.2.0.4 release
Hardware: All All
: medium normal
Assignee: Julien Nabet
URL:
Whiteboard: target:5.4.0 target:5.3.0.2 target:5....
Keywords: bibisectRequest, regression
Depends on:
Blocks:
 
Reported: 2016-12-19 20:03 UTC by Timur Davletshin
Modified: 2021-02-22 14:53 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Testcase file (10.69 KB, application/vnd.oasis.opendocument.text)
2016-12-19 20:08 UTC, Timur Davletshin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Timur Davletshin 2016-12-19 20:03:44 UTC
Description:
If I sign document my signature and see information about file I see "12/19/2016, 00:00:00, !!br0ken!!" while OpenOffice.org gives my email instead !!br0ken!!

Digital signature status icon says "The document signature is OK"

Steps to Reproduce:
1. Sign document
2. Open File → Properties
3. See Digital Signature information

Actual Results:  
12/19/2016, 00:00:00, !!br0ken!!

Expected Results:
12/19/2016, 00:00:00, username@domain.com


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0
Comment 1 Timur Davletshin 2016-12-19 20:08:14 UTC
Created attachment 129791 [details]
Testcase file
Comment 2 Telesto 2016-12-20 16:25:45 UTC
Confirming with:
Version: 5.4.0.0.alpha0+
Build ID: 53edf60c4ce6ed32f87471e018878c40b788005a
CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2016-12-18_06:57:59
Locale: nl-NL (nl_NL); Calc: CL
Comment 3 Telesto 2016-12-20 16:36:18 UTC
Also in:
Version: 5.0.0.5
Build ID: 1b1a90865e348b492231e1c451437d7a15bb262b
Locale: en-US (nl_NL)

and in:
Versie: 4.4.6.3 
Build ID: e8938fd3328e95dcf59dd64e7facd2c7d67c704d
Locale: nl_NL

and in
Version: 4.3.0.4
Build ID: 62ad5818884a2fc2e5780dd45466868d41009ec0

and in:
Versie: 4.2.0.4 
Build ID: 05dceb5d363845f2cf968344d7adab8dcfb2ba71

but not in
Versie: 4.1.0.4 
Build ID: 89ea49ddacd9aa532507cbf852f2bb22b1ace28
Comment 4 Terrence Enger 2016-12-31 05:49:48 UTC
The !!br0ken!! email address in tab General has already been reported
in tdf#104795.
Comment 5 Julien Nabet 2016-12-31 11:30:06 UTC
Same root cause as tdf#105011
Comment 6 Commit Notification 2016-12-31 12:51:14 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=5e149b630bd837ca6c8cae609a5c148f25f9ee82

tdf#105011, tdf#104795: copy string until its end if there's no comma

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2016-12-31 12:52:45 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-5-3":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=822a9fe43380458d81f2381be75d295562d608f7&h=libreoffice-5-3

tdf#105011, tdf#104795: copy string until its end if there's no comma

It will be available in 5.3.0.2.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Julien Nabet 2016-12-31 12:55:44 UTC
For 5.2 branch, https://gerrit.libreoffice.org/#/c/32533/
Comment 9 Terrence Enger 2017-01-01 15:55:55 UTC
I see the expected email address in 
    Version: 5.4.0.0.alpha0+
    Build ID: 879bac84cde2fc7cc27363d1bb0ca50c53162a88
    CPU Threads: 2; OS Version: Linux 4.8; UI Render: default; VCL: x11; 
    Locale: en-CA (en_CA.utf8); Calc: group

Thank you, Julien.
Comment 10 Terrence Enger 2017-01-01 15:57:21 UTC
Timur,

When you see the fix working for you, please advance the bug status to
VERIFIED FIXED.
Comment 11 Timur Davletshin 2017-01-01 16:28:31 UTC
Both 5.2 and 5.3 branches still report !!broken!!
Comment 12 Julien Nabet 2017-01-01 16:52:49 UTC
(In reply to Timur I. Davletshin from comment #11)
> Both 5.2 and 5.3 branches still report !!broken!!

About 5.2 branch, it's normal since https://gerrit.libreoffice.org/#/c/32533/ is still on review.
About 5.3 LO version, do you confirm the build id you retrieved includes this commit:
https://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-5-3&id=822a9fe43380458d81f2381be75d295562d608f7 ?
5.3 daily builds may be found here: http://dev-builds.libreoffice.org/daily/libreoffice-5-3/
Comment 13 Timur Davletshin 2017-01-01 17:01:38 UTC
Version: 5.3.0.1.0+
Build ID: f5695bf6a868e14e28f06697b2803ff7d325e7cb

bug is still there in this build downloaded via http://dev-builds.libreoffice.org/daily/libreoffice-5-3/Linux-rpm_deb-x86_64@70-TDF/current/
Comment 14 Julien Nabet 2017-01-01 17:16:05 UTC
(In reply to Timur I. Davletshin from comment #13)
> Version: 5.3.0.1.0+
> Build ID: f5695bf6a868e14e28f06697b2803ff7d325e7cb
> 
> bug is still there in this build downloaded via
> http://dev-builds.libreoffice.org/daily/libreoffice-5-3/Linux-rpm_deb-
> x86_64@70-TDF/current/

Ok this daily build doesn't include the fix, you must wait for the next daily build.
Indeed, last 5.3 daily build stops to this one:
https://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-5-3&id=f5695bf6a868e14e28f06697b2803ff7d325e7cb
so about 41 hours ago
The one which fixes the problem is this one:
https://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-5-3&id=822a9fe43380458d81f2381be75d295562d608f7
so about 28 hours ago
Comment 15 Commit Notification 2017-01-01 17:45:59 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-5-2":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=342ed30e08ddf625e9c6bb35ebd772b4ec6a213f&h=libreoffice-5-2

tdf#105011, tdf#104795: copy string until its end if there's no comma

It will be available in 5.2.5.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 16 Timur Davletshin 2017-01-03 14:35:21 UTC
Now all braches are fixed & verified. Thanks for fixing this bug!
Comment 17 Commit Notification 2021-02-22 14:53:18 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/68a323c97ad817faf95d2569b0965c4654044f60

tdf#104795: sw: Add UItest

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.