Bug 104833 - Scroll panes in Check for Updates dialog do not expose names to assistive technologies
Summary: Scroll panes in Check for Updates dialog do not expose names to assistive tec...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:24.2.0
Keywords: accessibility
: 156929 (view as bug list)
Depends on:
Blocks: a11y, Accessibility Updates
  Show dependency treegraph
 
Reported: 2016-12-21 12:32 UTC by am_dxer
Modified: 2023-09-01 14:14 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Sample document with UNO edit controls (9.50 KB, application/vnd.oasis.opendocument.text)
2023-08-31 12:11 UTC, Michael Weghorn
Details

Note You need to log in before you can comment on or make changes to this bug.
Description am_dxer 2016-12-21 12:32:55 UTC
Description:
When testing with NVDA and using the tab key to navigate this dialog, two scroll panes are read without labels.

Steps to Reproduce:
1. Press Alt+H to open the Help menu.
2. Select Check for Updates.
3. Press the Tab key to navigate between controls in the dialog.

Actual Results:  
NVDA reads two scroll panes without announcing a label.

Expected Results:
These scroll bars should expose names to assistive technologies.


Reproducible: Always

User Profile Reset: Yes

Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0
Comment 1 Buovjaga 2016-12-31 15:28:14 UTC
Repro with NVDA 2016.4.

Also, it did not read the contents of the Status scroll pane "LibreOfficeDev 5.4 is up to date".

Win 10
Version: 5.4.0.0.alpha0+
Build ID: 7ed40deee74a9869b7da073ad473241187420ff8
CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2016-12-30_23:18:54
Locale: fi-FI (fi_FI); Calc: group
Comment 2 QA Administrators 2018-01-01 03:26:57 UTC Comment hidden (obsolete)
Comment 3 am_dxer 2018-02-20 18:15:20 UTC
Repro in Version: 6.1.0.0.alpha0+
Build ID: 60ae5f530c3123341a8c2d49793693c2cd4521c2
CPU threads: 2; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-02-19_23:37:52
Locale: en-US (en_US); Calc: group
Comment 4 QA Administrators 2021-01-18 04:07:36 UTC Comment hidden (obsolete)
Comment 5 QA Administrators 2023-01-19 03:24:47 UTC Comment hidden (obsolete)
Comment 6 Michael Weghorn 2023-08-31 12:04:27 UTC
*** Bug 156929 has been marked as a duplicate of this bug. ***
Comment 7 Michael Weghorn 2023-08-31 12:11:54 UTC
Created attachment 189287 [details]
Sample document with UNO edit controls

Still reproducible, s.a. newly reported duplicate bug 156929.

The dialog implementation is here:
extensions/source/update/check/updatehdl.cxx

It uses UNO controls, UnoControlEditModel for the panes that are not announced.

Accerciser shows that the Text interface is not supported by that control, which might be the reason why it's not announced by screen readers.

The same behavior can also be reproduced with the dialog in the attached sample doc ("Tools" -> "Macros" -> "Organize Dialogs" -> select the one from the doc -> "Edit" -> run preview).

The single-line control supports the AT-SPI text interface w/ gtk3 on Linux and is announced by Orca just fine, the multi-line one is just announced as "blank"
Comment 8 Michael Weghorn 2023-09-01 10:04:13 UTC
(In reply to Michael Weghorn from comment #7)
> The single-line control supports the AT-SPI text interface w/ gtk3 on Linux
> and is announced by Orca just fine, the multi-line one is just announced as
> "blank"

Pending Gerrit changes which make the multi line edit expose the Text interface:

https://gerrit.libreoffice.org/c/core/+/156400
https://gerrit.libreoffice.org/c/core/+/156401 
https://gerrit.libreoffice.org/c/core/+/156402

As described in more detail in the commit message of the last change, these changes make Orca announce status ("LibreOfficeDev 24.2 is up to date.") when moving into the control using the Tab key. NVDA still says "Checking..." for that case, seems to be using the accessible name rather than the text (and that's outdated on Windows for some reason).

The label (which this bug report is primarily about) is still not announced. 
Don't know whether there's even a way to define a labelled-by relation for UNO controls (or that would require redesigning the dialog more).
Comment 9 Michael Weghorn 2023-09-01 12:43:18 UTC
(In reply to Michael Weghorn from comment #8)
> NVDA still says
> "Checking..." for that case, seems to be using the accessible name rather
> than the text (and that's outdated on Windows for some reason).

That will be fixed by
https://gerrit.libreoffice.org/c/core/+/156411

> The label (which this bug report is primarily about) is still not announced. 
> Don't know whether there's even a way to define a labelled-by relation for
> UNO controls (or that would require redesigning the dialog more).

Didn't see a way to set such a relation when getting over the UNO API doc, so looks to me like it might need more fundamental changes to the dialog, which I don't plan to work on right now.

The previously mentioned changes will allow to retrieve the most relevant information at least, even if the labels are still not announced.
Comment 10 Commit Notification 2023-09-01 14:13:43 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9a559df3fe2f623ac4eace30cdfeabb3a747c0e9

tdf#104833 a11y: Don't use VCLXEdit in VCLXAccessibleEdit

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2023-09-01 14:13:45 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/847df831b1c46a257fd371c6a193387cc9c06c4b

tdf#104833 Move VCLXMultiLineEdit to public toolkit header

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Commit Notification 2023-09-01 14:13:48 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a766f7555c55c73e2dfd167e66f1bf32c75de6df

tdf#104833 a11y: Use VCLXAccessibleEdit for VCLXMultiLineEdit

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 Commit Notification 2023-09-01 14:14:50 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a5593114bb409c93c7cf79a3abac0c60a8aebb18

tdf#104833 a11y Send name changed event for text controls

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.