Bug 105005 - Breakpoint has wrong icon image in BASIC IDE
Summary: Breakpoint has wrong icon image in BASIC IDE
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: BASIC (show other bugs)
Version:
(earliest affected)
5.4.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Regina Henschel
URL:
Whiteboard: target:5.4.0
Keywords: regression
Depends on:
Blocks:
 
Reported: 2016-12-30 16:15 UTC by Regina Henschel
Modified: 2017-01-02 21:16 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2016-12-30 16:15:11 UTC
Open the Basic IDE, write some code and set a breakpoint.

The image in the breakpoint window (the small area left of the code) is wrong. It shows the "folder" icon of the tree view of the libraries (= im30820.png). It should be a red circle (= im30838.png).

The images had been im30838.png and im30839.png. But the error is not only the missing images, but even if you copy them to the theme image-zip, they are not used.

It was OK in version 5.4.0.0.alpha0+
Build ID: f4732872aaba09c3d5b7cebb9af6bc7b7be534d4
TinderBox Win-x86@39, Branchmaster, Time:2016-12-10_23:50:52

It is broken in Version: 5.4.0.0.alpha0+
Build ID: 690cf2a5ac87d3d05c45a86944e7f6b0adf12cf2
CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; 
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2016-12-15_18:59:20
Locale: de-DE (de_DE); Calc: group
Comment 1 Regina Henschel 2016-12-30 16:42:50 UTC
Hi Caolán, would you mind looking whether this was introduced with commit https://cgit.freedesktop.org/libreoffice/core/commit/?id=96d0506fceb8064c5ae156dfaf12d5b45623c557 ?
Comment 2 Regina Henschel 2016-12-30 18:17:44 UTC
The error marker is wrong too. It should be a red left-to-right block arrow (= res/im30841.png), but it is res/im30823.png.
Comment 3 Jacques Guilleron 2016-12-30 22:52:53 UTC
Hi Regina,

Also broken in:
LO 5.4.0.0.alpha0+ Build ID: 08fa2e9307c9e4a49e18ecb0b4e9461492122fe3
CPU Threads: 2; OS Version: Windows 6.1; UI Render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2016-12-12_23:44:54
Locale: fr-FR (fr_FR); Calc: CL

And Windows 7 Home.
Comment 4 Regina Henschel 2017-01-01 18:48:51 UTC
Proposed patch is in https://gerrit.libreoffice.org/#/c/32590/
Comment 5 Commit Notification 2017-01-02 14:50:14 UTC
Regina Henschel committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=2ab040f5edfa83a40f918915f18ecca621aa2f94

tdf#105005 Breakpoint has wrong image in BASIC IDE

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.