Bug 105024 - paste only numbers Err:502, after reopen cells contain formula =err:502
Summary: paste only numbers Err:502, after reopen cells contain formula =err:502
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
5.3.0.0.beta2
Hardware: All All
: medium normal
Assignee: Eike Rathke
URL:
Whiteboard: odf target:5.4.0 target:5.3.0.2 targe...
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2017-01-01 11:13 UTC by raal
Modified: 2017-01-08 23:26 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
file for test (33.63 KB, application/x-vnd.oasis.opendocument.spreadsheet)
2017-01-01 11:14 UTC, raal
Details

Note You need to log in before you can comment on or make changes to this bug.
Description raal 2017-01-01 11:13:24 UTC
Description:
paste only numbers  Err:502, after reopen cells  contain formula =err:502

Steps to Reproduce:
1.open attached file
2.select A1:A2, copy
3.select B1
4. paste only numbers (menu Edit→Paste only → Paste only numbers or right click and context menu)
5. save,reopen

Actual Results:  
after reopen cells B1:B2 contain formula =err:502

Expected Results:
after reopen cells B1:B2 contain value Err:502


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0
Comment 1 raal 2017-01-01 11:14:00 UTC
Created attachment 130069 [details]
file for test
Comment 2 raal 2017-01-01 11:16:12 UTC
This seems to have begun at the below commit.
Adding Cc: to Eike Rathke ; Could you possibly take a look at this one?
Thanks
 6a4c4bc0bf1c9525a69ab4ae6b043d1bbaa2adee is the first bad commit
commit 6a4c4bc0bf1c9525a69ab4ae6b043d1bbaa2adee
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Wed Nov 16 00:18:55 2016 +0100

    source c4820366710fcbcc198a5471ad1f4a29f71d2019

author	Eike Rathke <erack@redhat.com>	2016-11-15 22:50:49 (GMT)
committer	Eike Rathke <erack@redhat.com>	2016-11-15 22:51:55 (GMT)
commit c4820366710fcbcc198a5471ad1f4a29f71d2019 (patch)
tree 86d06a7f4b31851cd786f118c6ea6927d9cf152c
parent c802fb24368ac9866940f2d987d46357b0e577f3 (diff)
tdf#96475 PutFormulaCell: any other cell than formula is utter nonsense
Comment 3 Xisco Faulí 2017-01-02 09:31:30 UTC
Moving it to NEW as the problematic commit has been identified
Comment 4 Eike Rathke 2017-01-02 14:06:03 UTC
Importing the cell as formula cell is expected behavior. Calc does not have distinct error cells, so to preserve the error information the error value is stored as a formula. What goes wrong here is that the detailed Err:502 value (and others) are not recognized as an error formula, contrary to defined errors like #DIV/0! or #VALUE! In fact it should not be stored as Err:502 that does not comply with the ODFF specification, but transformed to a value according to the syntax definition in "5.12 Constant Errors" at https://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part2.html#Constant_Errors and remapped during import.

Actually the identified commit for the first time preserves the paste special resulting error formulas when loading a document, see also its commit message, previously such error formulas were imported as string cells and thus lost their error property, so formulas like ISERROR(A1) ceased to produce a correct result if A1 contained a "special pasted" error value and the document was saved and reloaded.
Comment 5 Commit Notification 2017-01-05 12:30:31 UTC
Eike Rathke committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=896dd3962cd7e62bb2a9ebc6f97ff77936ec06a8

tdf#105024 use context to generate "error only" formula string

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2017-01-05 16:47:35 UTC
Eike Rathke committed a patch related to this issue.
It has been pushed to "libreoffice-5-3":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=d321ba87f5ab67f939034c59846d2a3d0ab7e9b4&h=libreoffice-5-3

tdf#105024 use context to generate "error only" formula string

It will be available in 5.3.0.2.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2017-01-05 17:24:59 UTC
Eike Rathke committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=857be5b2db4b2726306199bc279942f621bf55d8

Resolves: tdf#105024 generate and parse detailed "#ERRxxx!" error constants

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2017-01-05 17:25:05 UTC
Eike Rathke committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=44021bd4018f4f97d9f0f6b6e1f0a256e8853537

check token array code errors when testing for equality, tdf#105024 related

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2017-01-05 17:25:10 UTC
Eike Rathke committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=6b89bcf85a911d043c9d93e843be12e6f23adedd

check "#ERRxxx!" constants for accepted error values, tdf#105024 follow-up

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2017-01-06 00:47:11 UTC
Eike Rathke committed a patch related to this issue.
It has been pushed to "libreoffice-5-3":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=964cf72012b80ee4cab8923939182450bab28a4f&h=libreoffice-5-3

Resolves: tdf#105024 generate and parse detailed "#ERRxxx!" error constants

It will be available in 5.3.0.2.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2017-01-06 00:48:29 UTC
Eike Rathke committed a patch related to this issue.
It has been pushed to "libreoffice-5-3":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=a34de7f0e4165db1a64be42044f9d5900d0d3da9&h=libreoffice-5-3

check token array code errors when testing for equality, tdf#105024 related

It will be available in 5.3.0.2.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Commit Notification 2017-01-06 00:48:34 UTC
Eike Rathke committed a patch related to this issue.
It has been pushed to "libreoffice-5-3":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=049862c9dd426eef74e229aee619facb98c7e7da&h=libreoffice-5-3

check "#ERRxxx!" constants for accepted error values, tdf#105024 follow-up

It will be available in 5.3.0.2.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 Commit Notification 2017-01-06 17:30:29 UTC
Eike Rathke committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=b36bf9f567f5b531f526dad6776c84e06203396f

check length of string as this can be called untokenized, tdf#105024 related

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 14 Commit Notification 2017-01-06 17:30:33 UTC
Eike Rathke committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=4fcbe16959c839bfacf745cfa554b234e639f794

read single error constant formula as such, tdf#105024 related

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 15 Commit Notification 2017-01-06 17:30:38 UTC
Eike Rathke committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=75d963bc7bb87429f304d29138c27178880c039a

recognize the broken "Err:xxx" written by 5.2 and earlier, tdf#105024 related

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 16 Commit Notification 2017-01-06 18:32:03 UTC
Eike Rathke committed a patch related to this issue.
It has been pushed to "libreoffice-5-3":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=03e5263dbedcf7650722f0b1bc18ce069e4ce244&h=libreoffice-5-3

check length of string as this can be called untokenized, tdf#105024 related

It will be available in 5.3.0.2.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 17 Commit Notification 2017-01-06 18:32:07 UTC
Eike Rathke committed a patch related to this issue.
It has been pushed to "libreoffice-5-3":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=4164596f43132e7769057170a228d74118ee63c6&h=libreoffice-5-3

read single error constant formula as such, tdf#105024 related

It will be available in 5.3.0.2.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 18 Commit Notification 2017-01-06 19:40:05 UTC
Eike Rathke committed a patch related to this issue.
It has been pushed to "libreoffice-5-3":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=cb7ab49dde0ae21c472300f126cce4555a3e0ae5&h=libreoffice-5-3

recognize the broken "Err:xxx" written by 5.2 and earlier, tdf#105024 related

It will be available in 5.3.0.2.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 19 Eike Rathke 2017-01-06 20:37:27 UTC
Some adaptation pending review for 5-2 https://gerrit.libreoffice.org/32794
Comment 20 Commit Notification 2017-01-08 23:26:45 UTC
Eike Rathke committed a patch related to this issue.
It has been pushed to "libreoffice-5-2":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=7f3e71d2a6e34e33d04739bdf48ea3c18beef1be&h=libreoffice-5-2

display error constants written by 5.3+ in the for 5.2 usual way, tdf#105024

It will be available in 5.2.5.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.