Description: Inserting images into Photo Gallery crashes when imported image file name contains hash (#) character. Steps to Reproduce: 1. Name an image file as, for example, #1.jpg 2.In Impress: Insert|Media|Photo Album|Add 3.select the image 4.Open|Insert Slides Actual Results: Impress closes down with no error message. Restarting Impress goes through recovery process. Expected Results: Image(s) should have been imported. If for some reason the file name is deemed to invalid, a warning to that effect should be given, instead of crashing the program. Reproducible: Always User Profile Reset: No Additional Info: If the file name to be imported does not contain a "#", then the import works. 5.1.4.2 program crashes and disappears. Same problem occurs in 5.2.3.3 (via Flatpak) but in that case program hangs and does not respond. Windows 5.1.6.2 gives "Fatal error" dialog without further explanation. User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0
In GTK3 it crashes, in GTK+ it freezes. Confirmed in: Version: 5.4.0.0.alpha0+ Build ID: 75d963bc7bb87429f304d29138c27178880c039a CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group but not in Version: 5.0.0.0.alpha1+ Build ID: 0db96caf0fcce09b87621c11b584a6d81cc7df86 Locale: ca-ES (ca_ES.UTF-8
crash also reproducible in Version: 5.4.0.0.alpha0+ Build ID: 6bd7451ecd66417a4e8b8dff3874c15ba4d1536e CPU Threads: 1; OS Version: Windows 6.1; UI Render: default; TinderBox: Win-x86@42, Branch:master, Time: 2017-01-05_23:24:16 Locale: es-ES (es_ES); Calc: group
5e8294b0ca5f96b0d65ba416a20547e15d14f38e is the first bad commit commit 5e8294b0ca5f96b0d65ba416a20547e15d14f38e Author: Norbert Thiebaud <nthiebaud@gmail.com> Date: Wed Nov 4 12:30:39 2015 -0800 source d3248d1fd83cca67a11dd593c124694382bf5f34 # bad: [05d11632892a322664fb52bac90b2598b7fb7544] source 5616d22b57a9a5e57d545e912e029162a230829b # good: [c1efd324c6ad448ac9edb030dc9738b9e6899e4d] source ab465b90f6c6da5595393a0ba73f33a1e71a2b65 git bisect start '05d11632892a322664fb52bac90b2598b7fb7544' 'oldest' # good: [97526ab777da7e58ce283c05498262ecdd4d6f7f] source 4ea70f87f7a2b61eda6e5ab1f48debf6fcfadc1f git bisect good 97526ab777da7e58ce283c05498262ecdd4d6f7f # good: [86fee7ded76d9c2756ccab6aef160a2d7fab0ab6] source 1b62841b1859ae3443e2bf1ebe99ec3d6afb6cc2 git bisect good 86fee7ded76d9c2756ccab6aef160a2d7fab0ab6 # bad: [11864a7db429a57aeea021e0b3f1fb1412282d32] source e5b721a14c1c8e5261a70588b30353cbb5bd55c6 git bisect bad 11864a7db429a57aeea021e0b3f1fb1412282d32 # good: [cec39174971f789b01d212afe8b5ffdd1ba466ca] source 76e75d2dd6dafe55fd1740693529640652ed6455 git bisect good cec39174971f789b01d212afe8b5ffdd1ba466ca # bad: [a3f07b2197c8ba6b4614fd06d2793099d78fae17] source 401483271ffca557a922d6d1ca271a46084867dc git bisect bad a3f07b2197c8ba6b4614fd06d2793099d78fae17 # bad: [2290510d84871b8f7f33a7f03f7b07bde43b6588] source f927cf4d23432341921c55e6983edf9c8ebe7ff7 git bisect bad 2290510d84871b8f7f33a7f03f7b07bde43b6588 # good: [76818fe95bdebbb58306825b97f7f72cc7de1b80] source ae78051c22d5a9bc7b5728482d59720fed7e6146 git bisect good 76818fe95bdebbb58306825b97f7f72cc7de1b80 # good: [44df3b1b50b2557200878b7ab70442c98a024774] source 75303695eb4bfe6c8fdea2cad0d3ed3f912f95c9 git bisect good 44df3b1b50b2557200878b7ab70442c98a024774 # good: [03b92a5d2b797a42dbcb3ad3d55de94fe140770e] source c93db89a8f025a44ede88d16f01d11f41a818bbb git bisect good 03b92a5d2b797a42dbcb3ad3d55de94fe140770e # bad: [3b0d682bf09ba22097f076e2a4939b5d538f2247] source 67b4adc473c14f6ab72c27b52e77a76ed387dccc git bisect bad 3b0d682bf09ba22097f076e2a4939b5d538f2247 # good: [7ef4caeb1fa5a60e31bb16b707e7810b445125b8] source 16e4bbf44c4b2a95e26c331804940181c0fa1d86 git bisect good 7ef4caeb1fa5a60e31bb16b707e7810b445125b8 # good: [e6b57969a1666869561045a48c6a4c65beba7053] source e8a5e8023d8c3adcd0d91160a82f093e76b85030 git bisect good e6b57969a1666869561045a48c6a4c65beba7053 # bad: [5d732ddf91434fdf18e91e1f9691ff52eab60f0e] source 32bc8ddbf335dd26019edcf12758643b4cff9913 git bisect bad 5d732ddf91434fdf18e91e1f9691ff52eab60f0e # bad: [5e8294b0ca5f96b0d65ba416a20547e15d14f38e] source d3248d1fd83cca67a11dd593c124694382bf5f34 git bisect bad 5e8294b0ca5f96b0d65ba416a20547e15d14f38e # first bad commit: [5e8294b0ca5f96b0d65ba416a20547e15d14f38e] source d3248d1fd83cca67a11dd593c124694382bf5f34
This issue started at the commit referenced below. Adding Cc: to Stephan Bergmann, please take a look. https://cgit.freedesktop.org/libreoffice/core/commit/?id=d3248d1fd83cca67a11dd593c124694382bf5f34 author Stephan Bergmann <sbergman@redhat.com> 2015-11-04 07:39:35 (GMT) committer Stephan Bergmann <sbergman@redhat.com> 2015-11-04 09:19:59 (GMT) "Handle URLs with query or fragment (or containing NUL chars)"
Stephan Bergmann committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=6a68e364faa0d384f1e3bf397f5decaadecf9b3b tdf#105199: Keep URL intact It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to Aron Budea from comment #4) > This issue started at the commit referenced below. Adding Cc: to Stephan > Bergmann, please take a look. > > https://cgit.freedesktop.org/libreoffice/core/commit/ > ?id=d3248d1fd83cca67a11dd593c124694382bf5f34 > author Stephan Bergmann <sbergman@redhat.com> 2015-11-04 07:39:35 (GMT) > committer Stephan Bergmann <sbergman@redhat.com> 2015-11-04 09:19:59 (GMT) > > "Handle URLs with query or fragment (or containing NUL chars)" The problem was probably introduced with <https://cgit.freedesktop.org/libreoffice/core/commit/?id=97a055dfa7c85c8795dc9b55fb39a5b3448b29f2> "Related fdo#35546: Cosmetic fixes for Photo Album Dialog". On Windows, that problem just happened to be hidden by broken (Windows-specific) code elsewhere, which was in turn fixed by my commit mentioned above, causing this issue to become visible. On non-Windows, the problem should have been visible all the time.
Stephan Bergmann committed a patch related to this issue. It has been pushed to "libreoffice-5-2": http://cgit.freedesktop.org/libreoffice/core/commit/?id=96e0beb0ef99a0840ecf434c3d726eebaa3c745e&h=libreoffice-5-2 tdf#105199: Keep URL intact It will be available in 5.2.5. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Stephan Bergmann committed a patch related to this issue. It has been pushed to "libreoffice-5-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=192ea4c3a85dd5cb8ffa6dab38b8764fee73d223&h=libreoffice-5-3 tdf#105199: Keep URL intact It will be available in 5.3.0.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I tried development version from libreoffice-5-2~2017-01-11_11.51.06_LibreOfficeDev_5.2.5.0.0_Linux_x86-64_deb.tar.gz and the problem is fixed. Thanks to those who worked on this.
Setting status to VERIFIED, thanks for the feedback!