Bug 105301 - sort options not remembered thoroughly in saved document
Summary: sort options not remembered thoroughly in saved document
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
3.6.7.2 release
Hardware: All All
: medium normal
Assignee: Andreas Heinisch
URL:
Whiteboard: target:7.2.0 target:7.1.2
Keywords:
: 116502 (view as bug list)
Depends on:
Blocks: Sorting
  Show dependency treegraph
 
Reported: 2017-01-13 08:23 UTC by Paolo Benvenuto
Modified: 2021-02-17 22:44 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
file with sort memory buggish (39.33 KB, application/vnd.oasis.opendocument.spreadsheet)
2017-01-21 21:15 UTC, Paolo Benvenuto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Paolo Benvenuto 2017-01-13 08:23:33 UTC
Reproduce it this way:

- In a sheet with many columns of data, select many cells in many columns, say A1:L10
- From menu, Data - Sort
- Select more than 3 sort fields, say columns A, B, C, D, E, F, G
- In the second tab, select Natural Search too
- Perform the search -> OK

- Modify the data
- Select again A1:L10
- From menu, Data - Sort: the sort dialog has everything you have set
- Perform the search -> OK

- Save the spreadsheet
- Close it

- Open again the spreadsheet
- Select again A1:L10
- From menu, Data - Sort: the sort dialog hasn't remembered all the stuff you had set:
-- only 3 columns are remembered: A, B, C
-- Natural Search option has been lost too
Comment 2 Paolo Benvenuto 2017-01-14 21:34:25 UTC
Yes I tried defining ranges.

Nothing changed, the bug is there, identical.

Actually using range is only a way to select the cells
Comment 3 Paolo Benvenuto 2017-01-14 21:40:18 UTC
Sorts options are preserved associated with their respective ranges, but only till a certain extent, which seems to be 3 sort columns, and natural sort option isn't preserved either.
Comment 4 Buovjaga 2017-01-15 09:20:11 UTC
Ok, please attach an example file.
Comment 5 Paolo Benvenuto 2017-01-21 21:15:09 UTC
Created attachment 130601 [details]
file with sort memory buggish

The document has been saved after a sort option performed on columns (respectively) N O C D E and natural sort option set

The sort is relative to the cells defined in an area named "prova" (the area is automatically selected when Data - Sort is run)

However, opening the file and issuing Data - Sort, the dialog only shows a sort on columns (respectively) N O C, and natural sort option isnt' set
Comment 6 Paolo Benvenuto 2017-01-21 21:16:39 UTC
surely related to bug #105468
Comment 7 Paolo Benvenuto 2017-01-21 21:19:28 UTC
but in bug #105468 natural sort option is preserved
Comment 8 Buovjaga 2017-01-22 17:40:42 UTC
(In reply to Paolo Benvenuto from comment #5)
> Created attachment 130601 [details]
> file with sort memory buggish
> 
> The document has been saved after a sort option performed on columns
> (respectively) N O C D E and natural sort option set
> 
> The sort is relative to the cells defined in an area named "prova" (the area
> is automatically selected when Data - Sort is run)
> 
> However, opening the file and issuing Data - Sort, the dialog only shows a
> sort on columns (respectively) N O C, and natural sort option isnt' set

Ok, I tested with the document and the options are not saved.

Arch Linux 64-bit, KDE Plasma 5
Version: 5.4.0.0.alpha0+
Build ID: 63fd4c97118a943c84ba5a666cf8c9cc54b511c7
CPU Threads: 8; OS Version: Linux 4.8; UI Render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on January 22th 2016

Arch Linux 64-bit
Version 3.6.7.2 (Build ID: e183d5b)
Comment 9 QA Administrators 2018-02-01 03:44:55 UTC Comment hidden (obsolete)
Comment 10 Paolo Benvenuto 2018-03-10 21:49:45 UTC
present in  6.0.2.1
Comment 11 Buovjaga 2018-03-28 15:23:06 UTC
*** Bug 116502 has been marked as a duplicate of this bug. ***
Comment 12 ayca.yassi 2018-11-02 07:47:32 UTC
6.0.6 version also has that bug. Is there Any development action for this problem??
Comment 13 QA Administrators 2019-11-03 03:31:05 UTC Comment hidden (obsolete)
Comment 14 Andreas Heinisch 2021-01-09 17:46:57 UTC
I fixed the number of sorting keys being saved and displayed (https://gerrit.libreoffice.org/c/core/+/108987), but I am not sure about the sorting options. Atm, there is no xml definition for natural sort and the options regarding the boundary columns, and I am not sure if I can add these options without hurting the ods standard.
Comment 15 Commit Notification 2021-02-12 21:35:17 UTC
Andreas Heinisch committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/788c777c6cdf2254e8bba05321f4a9de309b15b5

tdf#105301 - increase the size of the sorting keys

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 16 Andreas Heinisch 2021-02-12 21:41:34 UTC
I close this once, since the missing sorting options are mentioned in bug 90296 too.
Comment 17 Xisco Faulí 2021-02-16 10:58:19 UTC
Verified in

Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: a5d68a4f959804f93ddda61a45cedaadb504e3f2
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

@Andreas Heinisch, thanks for fixing this issue!!
Comment 18 Commit Notification 2021-02-16 10:59:30 UTC
Andreas Heinisch committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/1c89de1ffce80e228eafca327d4f90a5c5487e55

tdf#105301 - increase the size of the sorting keys

It will be available in 7.1.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 19 Commit Notification 2021-02-17 22:44:07 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/fb1aa71ca3f7bec3fa6a10c4c3dec37987b213a2

tdf#105301: sc: Add UItest

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.