Description: Currently the download destination is default to Desktop folder on Windows, but this folder is intended to save quick launches used for Windows Desktop, no intended to save downloaded files. Steps to Reproduce: 1. Tools -> Options -> LibreOffice -> Online Update Actual Results: The download destination is default to C:\Users\<User name>\Desktop, as the attachment. Expected Results: Despite it can be replaced via Change button, download destination should defaulting to C:\Users\<User name>\Download folder. Reproducible: Always User Profile Reset: No Additional Info: User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:51.0) Gecko/20100101 Firefox/51.0
Created attachment 130688 [details] Screenshot
Somewhat a legacy setting pre Vista, intent being to direct the download to a directory user has write permission to and will find. Or, failing that to a common location with write permissions for all users [1][2]. Probably reasonable to make use of the now Windows OS default provision of a writable %USERPROFILE%/Downloads directory. The getDesktopDirectory() seems to only be used for the online update, so should be able to adjust it perhaps to getDownloadsDirectory() Easy hack? =-ref-= [1] http://opengrok.libreoffice.org/xref/core/extensions/source/update/check/updatecheckconfig.hxx#140 [2] http://opengrok.libreoffice.org/xref/core/extensions/source/update/check/updatecheckconfig.cxx#163
(In reply to V Stuart Foote from comment #2) > Probably reasonable to make use of the now Windows OS default provision of a > writable %USERPROFILE%/Downloads directory. > Was no CLSID (constant special item ID list) defined for Downloads with old system, why Desktop is now the default for our downloads. For the new its KNOWNFOLDERID handle is "FOLDERID_Downloads" accessed with the SHGetKnownFolderPath() function. Still looks pretty straight forward substitution. =-refs-= https://msdn.microsoft.com/en-us/library/windows/desktop/dd378457%28v=vs.85%29.aspx https://msdn.microsoft.com/en-us/library/windows/desktop/bb762188%28v=vs.85%29.aspx http://stackoverflow.com/questions/28963848/shgetfolderpath-download-folder
(In reply to V Stuart Foote from comment #2) > ... %USERPROFILE%/Downloads... Easy hack? Agreed (-needsUX) and likely (+easyhack).
easyHack and needsDevEval are mutually exclusive. Removed easyHack for now.
(In reply to Samuel Mehrbrodt (CIB) from comment #5) > easyHack and needsDevEval are mutually exclusive. Removed easyHack for now. ???? we use that combination for more than 1 year. If an easyhack missed e.g. code pointers needsDevEval is set. Please do a search, to see how often that combination is used. Did you think of needsDevAdvice, which is used for developer advice (whether or not a think is doable at all).
Another facet, the change from CLSID to KNOWNFOLDERID based method is only supported from MS Windows Vista onward. We will need to consider provision for update of Windows XP while that remains a "supported" OS.
removing easyhack, it does not look like something a new contrbutor can "just" do.
I suggest we integrate a mecanism to check OS version first, then we try to get the solutions separately.
(In reply to V Stuart Foote from comment #7) > Another facet, the change from CLSID to KNOWNFOLDERID based method is only > supported from MS Windows Vista onward. We will need to consider provision > for update of Windows XP while that remains a "supported" OS. LibreOffice removed support for Windows XP and Vista, so we may not necessary to consider them.
By the way, is it better or not to apply a similar change to other OS than Windows too?
(In reply to Takeshi Abe from comment #11) > By the way, is it better or not to apply a similar change to other OS than > Windows too? @moggi, this covers Windows but is controling a suitable download location for updates going to need attention cross platform moving forward with your MAR based incrementals?
(In reply to V Stuart Foote from comment #12) > (In reply to Takeshi Abe from comment #11) > > By the way, is it better or not to apply a similar change to other OS than > > Windows too? > > @moggi, this covers Windows but is controling a suitable download location > for updates going to need attention cross platform moving forward with your > MAR based incrementals? First this bug report is about the old update checker and not the new automatic updater. Most likely this bug will go away at some point just by removing the old update checker. The new updater is going to store the update files in the LibreOffice user profile for now.
(In reply to Markus Mohrhard from comment #13) > (In reply to V Stuart Foote from comment #12) > > (In reply to Takeshi Abe from comment #11) > > > By the way, is it better or not to apply a similar change to other OS than > > > Windows too? > > > > @moggi, this covers Windows but is controling a suitable download location > > for updates going to need attention cross platform moving forward with your > > MAR based incrementals? > > First this bug report is about the old update checker and not the new > automatic updater. Most likely this bug will go away at some point just by > removing the old update checker. > > The new updater is going to store the update files in the LibreOffice user > profile for now. Oh yeah, that’s a good choice.
Takeshi Abe committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=fb0bf56948d7f968717f4a3f53ce56e320cd5f36 tdf#105538 Download update to Downloads folder on Windows It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Polite ping: is this bug fixed? if so, please close it as RESOLVED FIXED
A polite ping to Takeshi Abe: is this bug fixed? if so, could you please close it as RESOLVED FIXED ? Thanks
OK, this is fixed. Version: 6.0.0.1 (x64) Build ID：d2bec56d7865f05a1003dc88449f2b0fdd85309a CPU 线程：4; 操作系统：Windows 10.0; UI 渲染：默认; 区域语言：zh-CN (zh_CN); Calc: group