Bug 105571 - Obsolete toolbar:helpid attribute in toolbar xml files
Summary: Obsolete toolbar:helpid attribute in toolbar xml files
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
5.4.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:5.4.0
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-27 15:33 UTC by Gabor Kelemen (allotropia)
Modified: 2017-01-31 13:36 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2017-01-27 15:33:59 UTC
The toolbar xml files can have a toolbar:helpid attribute, which may define a numeric help id that contains description for the given element.

However the numeric help id system was apparently retired and such help ids still in helpcontent did not work anymore. This is why I removed much of them in the last month or so.

Now, I think it would be nice to cleanup these attributes from toolbar definitions, as they are rather useless now. There is actually quite a lot of these around:

gabor@dome:~/src/core$ git grep toolbar:helpid | wc -l
1425
Comment 1 Commit Notification 2017-01-31 09:12:30 UTC
Gabor Kelemen committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=695c8bc98a486d01d00a2fda3e05fb6a615fc1bf

tdf#105571 Drop toolbar:helpid attribute from toolbar definitions

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.