Download it now!
Bug 105575 - Slow rendering when using a Logo command
Summary: Slow rendering when using a Logo command
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.1.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, perf, regression
Depends on:
Blocks: VCL-Scheduler LibreLogo
  Show dependency treegraph
 
Reported: 2017-01-27 19:13 UTC by Telesto
Modified: 2019-08-03 03:06 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2017-01-27 19:13:11 UTC
Description:
While testing bug 83801 I noticed that the Logo command "repeat 400 [ circle 10 + repcount/10 fd 5 + repcount/10 lt 10 ]" is executed slowly (with or without OPENGL)

Steps to Reproduce:
1. Open Writer, enable "View -> Toobars -> Logo";
2. Run the following LOGO command one by one (to run a LOGO command, paste the command in the LOGO command line box, then hit ENTER): repeat 400 [ circle 10 + repcount/10 fd 5 + repcount/10 lt 10 ]

Actual Results:  
The rendering is extremely slow compared to Lib5.0.2.2


Expected Results:
Same speed as in Lib5.0.2.2


Reproducible: Always

User Profile Reset: No

Additional Info:
Found in
Version: 5.4.0.0.alpha0+
Build ID: b41186a2fc49e440890b8c86e5367352ffaf9cd6
CPU Threads: 4; OS Version: Windows 6.19; UI Render: GL; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-01-26_01:50:40
Locale: nl-NL (nl_NL); Calc: CL

and in
Version: 5.3.0.0.alpha1+ (x64)
Build ID: 964f4ca95baf34d21002312003453cd0e72f5832
CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; Layout Engine: new; 
TinderBox: Win-x86_64@62-TDF, Branch:MASTER, Time: 2016-11-18_05:19:44
Locale: nl-NL (nl_NL); Calc: CL

but not in
Version: 5.0.2.2
Build ID: 37b43f919e4de5eeaca9b9755ed688758a8251fe
Locale: en-US (nl_NL)

Terminal output with debug build:
warn:legacy.osl:6020:4136:svx/source/sdr/contact/viewcontactofsdrpathobj.cxx:56: PolyPolygon object without geometry detected, this should not be created (!)
warn:legacy.osl:6020:7032:svx/source/sdr/contact/viewcontactofsdrpathobj.cxx:56: PolyPolygon object without geometry detected, this should not be created (!)
warn:sw:6020:7032:C:\cygwin\home\tinderbox\master\sw\inc\swrect.hxx:283: SVRect() without Width or Height
warn:sw:6020:7032:C:\cygwin\home\tinderbox\master\sw\inc\swrect.hxx:283: SVRect() without Width or Height
warn:legacy.osl:6020:4136:svx/source/sdr/contact/viewcontactofsdrpathobj.cxx:56: PolyPolygon object without geometry detected, this should not be created (!)


User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0
Comment 1 Telesto 2017-01-29 09:11:48 UTC
Aron could you take a look at this one.

Found in
Version: 5.4.0.0.alpha0+
Build ID: b41186a2fc49e440890b8c86e5367352ffaf9cd6
CPU Threads: 4; OS Version: Windows 6.19; UI Render: GL; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-01-26_01:50:40
Locale: nl-NL (nl_NL); Calc: CL

and in
Version: 5.1.0.3
Build ID: 5e3e00a007d9b3b6efb6797a8b8e57b51ab1f737
CPU Threads: 4; OS Version: Windows 6.2; UI Render: default; 
Locale: en-US (nl_NL)

but not in
Version: 5.0.6.3
Build ID: 490fc03b25318460cfc54456516ea2519c11d1aa
Locale: en-US (nl_NL)
Comment 2 Buovjaga 2017-02-01 11:39:38 UTC
I cannot compare with 5.0.2.2, because it says "too many or too few spaces next to parentheses". It works fine in 5.4.
Comment 3 Telesto 2017-02-01 14:18:20 UTC
Retested it again. Still slow compared to Lib 5.0.2.2
Version: 5.4.0.0.alpha0+
Build ID: 2670ca3fc597decae78499d1397539668eb84e5e
CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-01-31_05:32:46
Locale: nl-NL (nl_NL); Calc: CL

Fix for "too many or too few spaces next to parentheses":
1. Start LibreOffice
2. Go to Options -> Language Settings -> Set Local Settings to "English (USA)" 
3. Restart LibreOffice
Comment 4 Buovjaga 2017-02-03 12:28:46 UTC
Ok in 5.0.2.2 it is super fast!

Version: 5.0.2.2 (x64)
Build ID: 37b43f919e4de5eeaca9b9755ed688758a8251fe
Locale: en-US (fi_FI)
Comment 5 Aron Budea 2017-02-19 21:25:15 UTC Comment hidden (bibisection)
Comment 6 Aron Budea 2017-02-19 21:28:16 UTC
Originally takes about 30s on my computer, after these commits it's about 2-2.5x more (60-75s). While the amount of delay could be up for discussion, probably something around the original runtime would be more desirable.
Ash, Laszlo, Miklos? Does this require a change in the scheduler, or in the Logo interpreter?

https://cgit.freedesktop.org/libreoffice/core/commit/?id=3dfeae78cac187ec27f873271005c77aebafd038
author		Miklos Vajna <vmiklos@collabora.co.uk>	2015-09-09 10:30:18 (GMT)
committer	Miklos Vajna <vmiklos@collabora.co.uk>	2015-09-09 10:30:57 (GMT)

"vcl: restore lost hunk in Scheduler::ImplStartTimer()
Regression from commit 6d64d2f38d9f6c2f54e05675ecd0709eabf6d8ca (Minor refactoring and cleanup of Scheduler and Timer., 2015-07-19), the old Timer::ImplStartTimer() used to set nMS to at least 1, but the new Scheduler::ImplStartTimer() didn't do that."

https://cgit.freedesktop.org/libreoffice/core/commit/?id=6d64d2f38d9f6c2f54e05675ecd0709eabf6d8ca
author		Ashod Nakashian <ashodnakashian@yahoo.com>	2015-07-19 23:40:18 (GMT)
committer	Michael Meeks <michael.meeks@collabora.com>	2015-09-04 18:43:41 (GMT)

"Minor refactoring and cleanup of Scheduler and Timer."
Comment 7 Telesto 2017-09-08 12:11:25 UTC
@Jan-Marek: Might it be related to the scheduler?
Comment 8 Jan-Marek Glogowski 2017-09-08 16:26:33 UTC
All my Scheduler changes are just in master AKA 6.0. Those 1ms delays, reintroduced by Miklos to fix the workaround for AutoTimers rescheduling instantly again, don't exists anymore. So on master it's probably fixed (but for sure you have other bugs).
Comment 9 Telesto 2018-08-02 14:35:26 UTC
Repro with
Version: 6.2.0.0.alpha0+
Build ID: 1b21ff86effe58ae368457de8fec654ba4c8edd9
CPU threads: 4; OS: Windows 6.3; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-07-30_03:13:35
Locale: en-US (nl_NL); Calc: CL
Comment 10 QA Administrators 2019-08-03 03:06:28 UTC
Dear Telesto,

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
 
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug