Bug 105623 - [UI] Two different text for the same function
Summary: [UI] Two different text for the same function
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
5.3.0.2 rc
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:5.4.0
Keywords: difficultyBeginner, easyHack, skillUI
Depends on:
Blocks:
 
Reported: 2017-01-30 19:26 UTC by Olivier Hallot
Modified: 2017-02-14 08:57 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
2 labels for the same function. (96.96 KB, image/png)
2017-01-30 19:26 UTC, Olivier Hallot
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Hallot 2017-01-30 19:26:22 UTC
Created attachment 130771 [details]
2 labels for the same function.

See image attached.

Both strings perform the same function: close the master view in Impress

E7WHo Close Master View (on the toolbar)
84yqC Close Master Slide (on the sidebar)

I suggest 84yqC be changed to Close Master View.
Comment 1 Katarina Behrens (Inactive) 2017-01-30 23:04:51 UTC
Very easy hack

.ui file for the sidebar panel is in sd/uiconfig/simpress/ui/sidebarslidebackground.ui Just rename the button, that's it
Comment 2 Olivier Hallot 2017-01-31 11:35:13 UTC
Sure. 
But I'd like to get the OK from the UX team.
cc'ing them
Comment 3 Heiko Tietze 2017-01-31 11:52:44 UTC
Well spotted. I vote for *View.
Comment 4 Commit Notification 2017-01-31 17:14:04 UTC
Olivier committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=f9d846e6adc29a9f5cc5166193219ddadc95955b

tdf#105623 - Two labels for the same function

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Heiko Tietze 2017-02-01 08:27:40 UTC
Verified in master, both have the same label now. "Close Master View" in the sidebar changes with "Master Slide": should we adjust this too? IMO not.