Bug 106027 - draw:name should now be unique
Summary: draw:name should now be unique
Status: RESOLVED WONTFIX
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.2.0.0.alpha1
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2017-02-15 14:29 UTC by tristan.faure
Modified: 2017-04-04 13:44 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
the sample document (31.01 KB, application/vnd.oasis.opendocument.text)
2017-02-15 14:31 UTC, tristan.faure
Details

Note You need to log in before you can comment on or make changes to this bug.
Description tristan.faure 2017-02-15 14:29:15 UTC
Description:
We have developed a solution which generates open document (odt) files.
In previous LibreOffice version there was no problem to have several draw:name attributes with the same content in draw:frame tags containing images. 
In 5.3.0.3 images are not displayed

Steps to Reproduce:
1.Open attached sample


Actual Results:  
One image is displayed 

Expected Results:
two images shall be displayed


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0
Comment 1 tristan.faure 2017-02-15 14:31:42 UTC
Created attachment 131252 [details]
the sample document
Comment 2 Xisco Faulí 2017-02-15 15:21:57 UTC
Confirmed in

Version: 5.2.0.0.alpha1+
Build ID: 5b168b3fa568e48e795234dc5fa454bf24c9805e
CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; 
Locale: ca-ES (ca_ES.UTF-8)

but not in

Version: 5.0.0.0.alpha1+
Build ID: 0db96caf0fcce09b87621c11b584a6d81cc7df86
Locale: ca-ES (ca_ES.UTF-8)
Comment 3 raal 2017-03-13 19:28:57 UTC
This seems to have begun at the below commit.
Adding Cc: to Caolán McNamara; Could you possibly take a look at this one? Thanks

Probably not a bug, see description of the commit:

author	Caolán McNamara <caolanm@redhat.com>	2015-11-11 13:34:43 (GMT)
committer	Caolán McNamara <caolanm@redhat.com>	2015-11-19 09:31:00 (GMT)
commit de0432a9256188c7b5cd1a83858311e68c890ebf (patch)
tree 0f71c62f403b1fe81915ce336a8ad9be7e8446df
parent 526bbbbd2f8eb227bc0dacd755a6c72511adf976 (diff)
Incredible slowness and crashes with document with vast num of frame dups
it looks like draw:name values are supposed to be unique in ODF, even if it's not spelled out explicitly, since it exists so the frame can be referenced, which sort of implies that it has to be unique, so a document where the values aren't unique can be considered invalid 19.197.10 <draw:frame> The draw:name attribute specifies a name by which a <draw:frame> element can be referenced. So reject duplicate frames
	 36819a8a88302af3a9b955eb7190aad1ef571a38 is the first bad commit
commit 36819a8a88302af3a9b955eb7190aad1ef571a38
Author: Norbert Thiebaud <nthiebaud@gmail.com>
Date:   Thu Nov 19 06:59:42 2015 -0800

    source de0432a9256188c7b5cd1a83858311e68c890ebf

    source de0432a9256188c7b5cd1a83858311e68c890ebf

:040000 040000 08a0eb5b60b0a427b3f9d59f4cee3ffe680dbe98 30eee4aa1b33e06217795c5274cff1602eb6d8b1 M      instdir
git bisect log
# bad: [05d11632892a322664fb52bac90b2598b7fb7544] source 5616d22b57a9a5e57d545e912e029162a230829b
# good: [c1efd324c6ad448ac9edb030dc9738b9e6899e4d] source ab465b90f6c6da5595393a0ba73f33a1e71a2b65
git bisect start 'origin/master' 'oldest'
# good: [97526ab777da7e58ce283c05498262ecdd4d6f7f] source 4ea70f87f7a2b61eda6e5ab1f48debf6fcfadc1f
git bisect good 97526ab777da7e58ce283c05498262ecdd4d6f7f
# good: [86fee7ded76d9c2756ccab6aef160a2d7fab0ab6] source 1b62841b1859ae3443e2bf1ebe99ec3d6afb6cc2
git bisect good 86fee7ded76d9c2756ccab6aef160a2d7fab0ab6
# good: [11864a7db429a57aeea021e0b3f1fb1412282d32] source e5b721a14c1c8e5261a70588b30353cbb5bd55c6
git bisect good 11864a7db429a57aeea021e0b3f1fb1412282d32
# good: [7d52a87c0aa24498584ec522705cfae3a3a5a038] source 479df22d0b4b0e0393fcf621e7380b38415bcef8
git bisect good 7d52a87c0aa24498584ec522705cfae3a3a5a038
# bad: [bea538a879f50238f4c9c6f05e3d7390db9d76c7] source 7289a140fc68dc898ba2b2357cc960968195f236
git bisect bad bea538a879f50238f4c9c6f05e3d7390db9d76c7
# bad: [ad146f48b7f50d159d5b96f1c118cdb8412a98b8] source 91cbbb7797f048834b51690e9fab60aa778b1e44
git bisect bad ad146f48b7f50d159d5b96f1c118cdb8412a98b8
# bad: [e19c6163b0c6f5c6618cefd870a31522957fb620] source ff522704109078a0cde844c74d608137b7c70f42
git bisect bad e19c6163b0c6f5c6618cefd870a31522957fb620
# bad: [cb343d9d1273b0981a35f9629a32aace88bc0609] source bb2ee8c2b550186e48ca5f069dcf8a9d69d65729
git bisect bad cb343d9d1273b0981a35f9629a32aace88bc0609
# good: [dee525d2053607f9651075bead2f32ca32d6c40b] source 526bbbbd2f8eb227bc0dacd755a6c72511adf976
git bisect good dee525d2053607f9651075bead2f32ca32d6c40b
# bad: [47b0f459600b21f862998451a23173b53ace80c8] source 8311c6ed4970d22e7a6459fa7ed2779560e5e11d
git bisect bad 47b0f459600b21f862998451a23173b53ace80c8
# bad: [f224c781b4257dcfcb431d5928f8d54d0b2fdf78] source c94cf0cf5f10edb45a74a58c95c306b0d271645b
git bisect bad f224c781b4257dcfcb431d5928f8d54d0b2fdf78
# bad: [179ce594887adf39f57a3d04abe4c7df0c0a7a85] source 5319def848e855068512f0f895086ff7a1f9e44f
git bisect bad 179ce594887adf39f57a3d04abe4c7df0c0a7a85
# bad: [36819a8a88302af3a9b955eb7190aad1ef571a38] source de0432a9256188c7b5cd1a83858311e68c890ebf
git bisect bad 36819a8a88302af3a9b955eb7190aad1ef571a38
# first bad commit: [36819a8a88302af3a9b955eb7190aad1ef571a38] source de0432a9256188c7b5cd1a83858311e68c890ebf
Comment 4 Caolán McNamara 2017-04-04 13:40:45 UTC
please change the tool to give unique names to different objects
Comment 5 tristan.faure 2017-04-04 13:44:19 UTC
It is indeed the solution we will have to do.

I opened this bug to be sure it is not in contradiction with the specification.

Thank you for the analysis !