Bug 106255 - Crash in: fpicker::win32::vista::VistaFilePickerImpl::impl_sta_SetMultiSelectionMode(std::shared_ptr<fpicker::win32::vista::Request> const &)
Summary: Crash in: fpicker::win32::vista::VistaFilePickerImpl::impl_sta_SetMultiSelect...
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
5.3.0.3 release
Hardware: All Windows (All)
: highest critical
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-01 13:24 UTC by Knut Wenzig
Modified: 2019-05-15 11:09 UTC (History)
1 user (show)

See Also:
Crash report or crash signature: ["fpicker::win32::vista::VistaFilePickerImpl::impl_sta_SetMultiSelectionMode(std::shared_ptr<fpicker::win32::vista::Request> const &)"]

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Knut Wenzig 2017-03-01 13:24:02 UTC 
This bug was filed from the crash reporting server and is br-423752f8-202a-4847-b822-7dd62890970d.
=========================================
A macro (which was functional before) does not work anymore and results in crashes.
Comment 1 Knut Wenzig 2017-03-01 13:25:55 UTC 
These are the macros which quit working:

REM  *****  BASIC  *****

Sub DDICSVopen
dim aUrl(), s$
Dim vDoc 'die geladene Komponente
Dim Arg()
dim fileProps(1) as new com.sun.star.beans.PropertyValue
fileProps(0).Name = "FilterName"
fileProps(0).Value = "Text - txt - csv (StarCalc)"
fileProps(1).Name = "FilterOptions"
fileProps(1).Value = "44,34,76,1,,0,false,true,true,false"
oDlg = createUnoService("com.sun.star.ui.dialogs.FilePicker")
oDlg.setMultiSelectionMode(false)
oDlg.execute
aUrl = oDlg.getFiles()
'Messagebox for debugging
's = "file:" & chr(10) & aUrl(0) & chr(10)
'msgbox s
vDoc = StarDesktop.loadComponentFromURL(aURL(0), "_blank", 0, fileProps())
End Sub


Sub DDICSVsave
dim aUrl(), s$
Dim Arg()
dim fileProps(1) as new com.sun.star.beans.PropertyValue
fileProps(0).Name = "FilterName"
fileProps(0).Value = "Text - txt - csv (StarCalc)"
fileProps(1).Name = "FilterOptions"
fileProps(1).Value = "44,34,76,1,,0,false,true,true,false"
oDlg = createUnoService("com.sun.star.ui.dialogs.FilePicker")
oDlg.setMultiSelectionMode(false)
oDlg.initialize(array(1)) ' Speichern unter
oDlg.execute
aUrl = oDlg.getFiles()
thisComponent.storeAsURL(aURL(0), fileProps())
End Sub
Comment 2 Xisco Faulí 2017-03-01 13:44:02 UTC 
Crash reproduced in

Versión: 5.3.0.3
Id. de compilación: 7074905676c47b82bbcfbea1aeefc84afe1c50e1
Subpr. de CPU: 1; Versión de SO: Windows 6.1; Repr. de IU: predet.; Motor de trazado: HarfBuzz; 
Configuración regional: es-ES (es_ES); Calc: group

but not in

Version: 5.4.0.0.alpha0+
Build ID: eb7b03b052ffe8c2c577b2349987653db6c53f76
CPU threads: 1; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2017-02-26_22:34:18
Locale: es-ES (es_ES); Calc: group

so it has been fixed in the meantime.
Adding BackportRequest
Comment 3 Adolfo Jayme Barrientos 2017-03-02 15:15:50 UTC 
Which is the specific commit that fixed this issue, so that the backportRequest can be fulfilled?
Comment 4 Xisco Faulí 2017-03-02 15:18:04 UTC 
(In reply to Adolfo Jayme from comment #3)
> Which is the specific commit that fixed this issue, so that the
> backportRequest can be fulfilled?

it needs to be bisected. That's why I added the backportRequest...
Comment 5 Knut Wenzig 2017-03-29 14:07:46 UTC 
Not solved with 5.3.1, no problem with 5.2.6.
Comment 6 Knut Wenzig 2019-05-15 11:09:48 UTC 
The mentioned macro was not programmed properly and it turned out, that at least one line had to be added, as you can see in bug 109093.

Everyone who wants to take care of this issue and still gets an error with an old version of Calc should check, whether this new line changes the result.