Bug 106324 - LibreOffice.app includes 60 MB LibreOfficePython.framework tests folder
Summary: LibreOffice.app includes 60 MB LibreOfficePython.framework tests folder
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: framework (show other bugs)
Version:
(earliest affected)
5.3.0.3 release
Hardware: All macOS (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:6.2.0
Keywords: needsDevAdvice, regression
Depends on:
Blocks:
 
Reported: 2017-03-04 21:55 UTC by Jakob Stoeck
Modified: 2018-09-17 11:44 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jakob Stoeck 2017-03-04 21:55:32 UTC
Description:
LibreOffice.app/Contents/Frameworks/LibreOfficePython.framework/Versions/3.5/python3.5/test weighs approximately 60 MB and should not be needed by the application and could reduce the overall file size by ~7%.

Steps to Reproduce:
1. Look at LibreOffice.app/Contents under macOS

Actual Results:  
LibreOffice.app/Contents/Frameworks/LibreOfficePython.framework/Versions/3.5/python3.5/test exists

Expected Results:
LibreOffice.app/Contents/Frameworks/LibreOfficePython.framework/Versions/3.5/python3.5/test should not exist, saving space.


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_3) AppleWebKit/604.1.6 (KHTML, like Gecko) Version/10.2 Safari/604.1.6
Comment 1 tommy27 2017-07-17 04:51:13 UTC
I don't see such a python3.5/test subfolder under Win8.1 x64

did you try to upgrade to latest LibO 5.3.4.2 release?
the 5.3.0.3 version you reported the bug with is now obsolete
Comment 2 Jakob Stoeck 2017-07-17 07:25:09 UTC
Yes it’s still there under macOS. I updated the version. Most of it are python bytecode files for the tests inside __pycache__. That might be a regression if I understand this commit correctly: https://cgit.freedesktop.org/libreoffice/core/commit/?id=1603854be942078e7f2381fad2efbd992eeb86ee

The path of the test files was missing a /lib/. Correct path is like this: LibreOffice.app/Contents/Frameworks/LibreOfficePython.framework/Versions/3.5/lib/python3.5/test
Comment 3 Alex Thurgood 2017-07-17 08:59:55 UTC
Confirming with

Version: 5.3.4.2
Build ID: f82d347ccc0be322489bf7da61d7e4ad13fe2ff3
CPU Threads: 4; OS Version: Mac OS X 10.12.5; UI Render: default; Layout Engine: new; 
Locale: en-GB (fr_FR.UTF-8); Calc: group
Comment 4 Alex Thurgood 2017-07-17 09:01:50 UTC
Not present in LO5272 - regression
Comment 5 tommy27 2017-07-17 09:03:12 UTC
thanks. set back version to 5.3.0.3 since it should indicate the earlier release the bug is present, not the latest
Comment 6 QA Administrators 2018-07-18 02:39:15 UTC Comment hidden (obsolete)
Comment 7 How can I remove my account? 2018-08-14 19:51:22 UTC
Suggested fix in https://gerrit.libreoffice.org/#/c/59034/
Comment 8 Commit Notification 2018-08-15 05:54:18 UTC
Tor Lillqvist committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=0f2f719ccd5544eb37d1aacb0a50c317ae963e50

tdf#106324: Remove unnecessary test folder from LibreOfficePython framework

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Xisco Faulí 2018-09-17 11:37:54 UTC
A polite ping to Tor Lillqvist:
Is this bug fixed? if so, could you please close it as RESOLVED FIXED ? Otherwise, Could you please explain what's missing?
Thanks