When zooming (with pinch to zoom) don't allow to zoom to a factor smaller than page width (this restriction doesn't apply for Calc).
Steps to Reproduce:
User Profile Reset: No
User-Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0
I'd like to work on this issue. I think it would be better to have a setting to limit zoom or not as well.
Sure, let's see what you come up with. It shouldn't be too hard once you find the correct place.
(In reply to Tomaz Vajngerl from comment #2)
> Sure, let's see what you come up with. It shouldn't be too hard once you
> find the correct place.
I submitted a patch couple of days ago and I guess it's still under review.
For a quick question, why the zoom restriction shouldn't apply to Calc?
How is it supposed to be for Calc...?
I'm not monitoring gerrit and you didn't put me as a reviewer or said anything here, so I didn't know that you submitted a patch.
Why not calc - because in calc the current range is "the document" so it makes no sense to restrict zoom there. Calc needs special UI and handling anyway and that is a much larger task that needs to be done separately to this.
(In reply to Tomaz Vajngerl from comment #4)
> I'm not monitoring gerrit and you didn't put me as a reviewer or said
> anything here, so I didn't know that you submitted a patch.
> Why not calc - because in calc the current range is "the document" so it
> makes no sense to restrict zoom there. Calc needs special UI and handling
> anyway and that is a much larger task that needs to be done separately to
I should have familiarized myself with gerrit and bugzilla and their linkage..
I went and added you as a reviewer and will let you know about my future
patches. Also the link is: https://gerrit.libreoffice.org/#/c/35308/
For Calc, I didn't single it out for in my patch. I guess it can wait till the special UI comes out.
Thanks for the help!
Yeah, it is OK to not single it out for Calc.
You're working on a next bug?
(In reply to Tomaz Vajngerl from comment #6)
> Yeah, it is OK to not single it out for Calc.
> You're working on a next bug?
Yea I'm trying to look into this bug Bug 96816.
Ximeng Zu committed a patch related to this issue.
It has been pushed to "master":
tdf#106368 android: restrict zoom to page width
It will be available in 5.4.0.
The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
Affected users are encouraged to test the fix and report feedback.
Is this bug fixed?
If so, could you please close it as RESOLVED FIXED?
Also see this patch with an update of the bug fix.
(In reply to Ximeng Zu from comment #10)
> Also see this patch with an update of the bug fix.
*** Bug 89919 has been marked as a duplicate of this bug. ***