Download it now!
Bug 106378 - Set Paragraph Style > "Clear formatting" should be renamed to "Clear all formatting"
Summary: Set Paragraph Style > "Clear formatting" should be renamed to "Clear all form...
Status: RESOLVED INVALID
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium trivial
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Clear-Formatting Writer-Styles
  Show dependency treegraph
 
Reported: 2017-03-07 08:22 UTC by Timur
Modified: 2019-08-31 10:49 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Timur 2017-03-07 08:22:07 UTC
Description:
Since OO, there is "Clear formatting" in "Apply Style" toolbar.
It clears all formatting and as https://help.libreoffice.org/index.php?title=Common/Apply_Style says:
"To reset the selected objects to the default paragraph style, select Clear formatting".
In order to make things clear, this one should be renamed to "Clear all formatting".

Steps to Reproduce:
Choose Apply Style > "Clear formatting" and compare to Format - Clear Direct Formatting.

Actual Results:  
"Clear formatting" 

Expected Results:
"Clear all formatting"


Reproducible: Always

User Profile Reset: 

Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Firefox/38.0
Comment 1 V Stuart Foote 2017-03-07 16:16:35 UTC
You are of course referring to the "Formatting" toolbar. There is no "Apply Style" toolbar.

That control is a drop list toolbox with tooltip "Set Paragraph Style" [1], through 5.2 release it was "Apply Paragraph Style".

The "Clear formatting" action "aClearForm" calls RID_SVXSTR_CLEARFORM [2] and takes its label from its definition [3]

However, as Cor pointed out in bug 70759, the action of this control does not clear "All" formatting, just the Paragraph style -- it does not clear any Direct formatting applied and it does not clear other Style types (i.e. Character, Page, Frame, List or Table). 

Removing "direct" formatting is performed with the .uno:ResetAttributes command associated with the main menu Format -> Clear Direct Formatting command.

The RID_SVXSTR_CLEARFORM action will set/reset the *paragraph* style--it should probably be to Default but as in bug 70759 it sets to Text Body.

Its labeling controlled from [3] could be changed, but it can not be considered "All" as currently implemented, simply see no need to change it.

As to refactoring the RID_SVXSTR_CLEARFORM to affect both paragrah style, other styles and any direct formatting--that would be more than a trivial effort.


=-ref-=

[1] http://opengrok.libreoffice.org/xref/core/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu#2869

[2] http://opengrok.libreoffice.org/xref/core/svx/source/tbxctrls/tbcontrl.cxx#2202

[3] http://opengrok.libreoffice.org/xref/core/svx/source/tbxctrls/tbcontrl.src#206