Bug 106447 - Support checked items in the menu bar in Online
Summary: Support checked items in the menu bar in Online
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice Online
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard: target:5.4.0
Keywords: difficultyInteresting, easyHack, skillJavaScript
Depends on:
Blocks:
 
Reported: 2017-03-09 09:44 UTC by Pranav Kant
Modified: 2017-05-03 15:54 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pranav Kant 2017-03-09 09:44:10 UTC 
Currently, the file menubar doesn't have any support for checked items, so it is not possible to know whether some item is in selected state or not. Eg: Edit->Track Changes->Record.

We need to listen to state change messages sent by loolwsd like we do for our toolbar items (so they are shown in pressed/normal state accordingly).
Comment 1 Commit Notification 2017-05-03 15:54:00 UTC 
Pranav Kant committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/online/commit/?id=e032cb72fa230f27a9a90f0b74411b9a3c63c96e

tdf#106447: Support checked items in menubar