Bug 106484 - UI: Print Properties Device tab dropdown items not applied or remembered
Summary: UI: Print Properties Device tab dropdown items not applied or remembered
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
5.0.0.5 release
Hardware: All Linux (All)
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.2.0 target:7.0.5 target:7.1.1
Keywords: bibisected, bibisectRequest, regression
Depends on:
Blocks: Printer-Settings Print-Dialog
  Show dependency tree / graph
 
Reported: 2017-03-10 20:38 UTC by tmacalp
Modified: 2021-01-26 18:52 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description tmacalp 2017-03-10 20:38:19 UTC 
Description:
Attempting to change items at the bottom of the Print Properties Device tab, such as "Printer language type," "Color," or "Color depth" are completely ignored and remain unset after clicking OK.

I found this testing old bugs relating to PostScript vs PDF Mode printing.  It turns out that as of LO 5.0, this bug keeps these settings from being applied.

Steps to Reproduce:
1. New document/drawing/spreadsheet/etc...
2. File->Print
3. Click Properties
4. Select "Device" tab
5. Change "Printer language type" to something else
6. OK
7. Click Properties
8. Select "Device" tab again.

Actual Results:  
The Printer language type was never actually set, so it will return to its original value.  Printing after clicking OK will generate a print job that does not have the settings applied.

Expected Results:
The Printer language type should be set to whatever we changed it to, as it used to.  


Reproducible: Always

User Profile Reset: Yes, fresh profile.

Additional Info:
LibreOffice refuses to set any 3 of these drop-down items ("Printer language type," "Color," and "Color depth").  It's not that these items are applied but not remembered.  Attempting to set these items will affect the print job.  This could cause someone to accidentally print a huge job in color and potentially waste a lot of money.  Note that I believe there is a bug with pdf mode printing where attempting to change the print job to grayscale by using the Color dropdown will be ignored.  It only works under PostScript printing.

LibreOffice appears to honor the global setting for either PDF Mode or Postscript level from driver (Tools->Options->Print->PDF as standard print job format).

One workaround is that if an item is selected in the Device tab main list like Media Type (or whatever options your printer offers), the drop-down setting will then be applied/remembered.  My guess is there is problem with the logic for determining when a setting has been modified and will need to be saved/applied.

This affects LO 5.0.0+ but not 4.4.7.  I wasn't sure if this would fall under UI or Printing. 


User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0
Comment 1 Xisco Faulí 2017-03-14 09:06:23 UTC 
Confirmed in

Version: 5.2.0.0.alpha1+
Build ID: 5b168b3fa568e48e795234dc5fa454bf24c9805e
CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; 
Locale: ca-ES (ca_ES.UTF-8)

but not in

Version: 5.0.0.0.alpha1+
Build ID: 0db96caf0fcce09b87621c11b584a6d81cc7df86
Locale: ca-ES (ca_ES.UTF-8)
Comment 2 QA Administrators 2018-03-15 03:38:20 UTC Comment hidden (obsolete)
Comment 3 Buovjaga 2018-06-02 15:12:29 UTC 
Still repro and this seems to be Linux-only as Windows offers the dialog of the printer driver itself.

Arch Linux 64-bit
Version: 6.2.0.0.alpha0+
Build ID: 8e63d451b2aeb646ece98c4e219f92957f4482bd
CPU threads: 8; OS: Linux 4.16; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group threaded
Built on June 1st 2018
Comment 4 Xisco Faulí 2019-01-24 13:14:20 UTC 
Still reproducible with the new print dialog

Version: 6.3.0.0.alpha0+
Build ID: 0d46fb02f3f19d11db40b6c5335d78a3894502d7
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

@Daniel Silva, I thought you might be interested in this issue...
Comment 5 QA Administrators 2021-01-24 04:05:30 UTC Comment hidden (obsolete, spam)
Comment 6 Justin L 2021-01-25 16:29:41 UTC 
Why has no one ever bibisected this yet? It is easy to reproduce. It started in LO 5.1 - where there is no per-commit bibisect on Linux, so I used Miklos' daily one to get the range https://cgit.freedesktop.org/libreoffice/core/log/?id=4daa3f54437730fe4e509082faa0d3509c62cea0&qt=range&q=ee3d40b30816a8fc6d4e8f984659c8dfac19ec3b..efa2c05e84d0696b31bd822d3234798be43853ad

I didn't see anything in that range that seemed obviously. It seems very much like a Caolan thing, but his four patches didn't seem to be related to this on the surface.

I believe there is a Windows 5.1 per-commit bibisect, so perhaps someone having that could zero in on an exact commit?  (P.S. the screen wasn't redrawing properly for me, so I had to mostly guess at where to click - but that was good enough to do the bibisecting. I hope you do not have that same problem on Windows, but it is not insurmountable.)
Comment 7 Caolán McNamara 2021-01-26 11:53:34 UTC 
I suspect its

commit 07602e5a8b869be1c45158cf71d6015d17a5f797
Author: Katarina Behrens <Katarina.Behrens@cib.de>
Date:   Wed Jun 24 17:31:32 2015 +0200

    tdf#91362: Don't override printer page autodetection
    
    if printer settings haven't been modified

which is close to, but not mentioned in, the range you isolated
Comment 8 Commit Notification 2021-01-26 14:22:17 UTC 
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/07ec53a20caa416ba3f64f04151c3317313fa381

Resolves: tdf#106484 Print Properties Device tab dropdown change not detected

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Caolán McNamara 2021-01-26 14:22:50 UTC 
fixed in master, backports to 7-1 and 7-0 in gerrit
Comment 10 Commit Notification 2021-01-26 15:19:52 UTC 
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/cc2595a8041f0e863c786ff0d028561cb3f40552

Resolves: tdf#106484 Print Properties Device tab dropdown change not detected

It will be available in 7.0.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2021-01-26 15:20:05 UTC 
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/95617b04651ae9f515ced79760851123a7e09236

Resolves: tdf#106484 Print Properties Device tab dropdown change not detected

It will be available in 7.1.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Buovjaga 2021-01-26 18:52:58 UTC 
Verified, thanks

Arch Linux 64-bit
Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: 55933f49f5a04708d27dc69e8778ec126646e3a5
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: kf5
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 26 January 2021