The bug 106756 pointed out that there are projects that prefer own theme over using the system one. This is currently not the direction that LibreOffice wants to follow, so the bug has been closed. Nevertheless - the "fallback theme" that we have in LibreOffice is incredibly ugly, and could be improved. Also the code for the actual drawing is spread all over the place; would be great to unify that to one place instead of all the "if (native) {something();} else {fallback();}"-like implementation. There would be 2 things to improve: 1) move the drawing of the widgets out of their paint method to a theme painting class 2) actually improve the drawing of the "fallback" widgets The 1) would lead to using a theme class that would be either instantiated by the system integration (Gtk+ / KDE / Windows / macOS / ...), or the fallback instance is used. In 2) the actual drawing would be improved. Both 1) and 2) can be done incrementally, there is no need for a big bang where everything would be broken :-)
Thibaut: As to the actual code pointers: vcl/unx/kde/salnativewidgets-kde.cxx vcl/unx/gtk3/gtk3salnativewidgets-gtk.cxx vcl/unx/gtk/salnativewidgets-gtk.cxx vcl/source/gdi/salnativewidgets-none.cxx vcl/win/gdi/salnativewidgets-luna.cxx vcl/osx/salnativewidgets.cxx are the current implementations of the native themes. To see where the drawing happens, do 'git grep DrawNativeControl'. Eg. a radio button drawing happens in vcl/source/control/button.cxx in: void RadioButton::ImplDrawRadioButtonState(vcl::RenderContext& rRenderContext) You can see that the "native" part happens in the if (!maImage && rRenderContext.IsNativeControlSupported(... part, and the fallback happens in: if (!bNativeOK) part.
+1
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
We updated the themes for 6.1. Fallback is now the newly designed Colibre theme.