Bug 106964 - Glade notebookbar.ui can't be edit
Summary: Glade notebookbar.ui can't be edit
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:5.4.0
Keywords:
Depends on:
Blocks: Notebookbar
  Show dependency treegraph
 
Reported: 2017-04-05 08:00 UTC by andreas_k
Modified: 2017-04-09 23:34 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
notebookbar.ui only change is cutbox Text beside icons (303.57 KB, text/plain)
2017-04-05 08:53 UTC, andreas_k
Details
screenshot of the change in glade (105.68 KB, image/png)
2017-04-05 08:54 UTC, andreas_k
Details

Note You need to log in before you can comment on or make changes to this bug.
Description andreas_k 2017-04-05 08:00:05 UTC
it's not possible to edit the notebookbar.ui file with glade. When I open the file change one thing and save the notebookbar.ui file is broken.

without Glade it's not possible to edit the notebookbar.ui file in a usefull way. the other .ui files are no problem.
Comment 1 Samuel Mehrbrodt (CIB) 2017-04-05 08:26:18 UTC
Which Glade version do you have?
Comment 2 andreas_k 2017-04-05 08:53:13 UTC
Created attachment 132341 [details]
notebookbar.ui only change is cutbox Text beside icons

I open the master file and change cutbox from Toolbar Style non to Toolbar Style Text beside icons that's the change but with the new file writer crash.
Comment 3 andreas_k 2017-04-05 08:54:28 UTC
I have Glade 3.18.3 installed and in preferences I link to /opt/libreofficedev5.4/share/glade the libreofficedev version is master from 04.04.2017.
Comment 4 andreas_k 2017-04-05 08:54:51 UTC
Created attachment 132342 [details]
screenshot of the change in glade
Comment 5 Szymon Kłos 2017-04-09 09:54:56 UTC
The original notebookbar.ui file has incorrect structure (id was missing for one element and Glade saved that node but without content).
Comment 6 Commit Notification 2017-04-09 09:55:56 UTC
Szymon Kłos committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=82a25b754b0900d313ca24d9283ae6398dc66d18

tdf#106964 Notebookbar: missing id int the .ui file

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 andreas_k 2017-04-09 23:34:23 UTC
thanks a lot