LibreOffice Online uses a rather frankensteinish mix of Poco::Timestamp and std::chrono - we should move to using the latter consistently. It would be good to move wsd/* first - since it doesn't use much Poco API anymore - although it would be good to consider whether we need some convenience wrappers around std::chrono to make it somewhat less verbose - particularly the cast to milliseconds is very ugly. Thanks !
*** This bug has been marked as a duplicate of bug 107038 ***
I would like to work on this bug. (In reply to Michael Meeks from comment #0) > LibreOffice Online uses a rather frankensteinish mix of Poco::Timestamp and > std::chrono - we should move to using the latter consistently. > > It would be good to move wsd/* first - since it doesn't use much Poco API > anymore I think I found most of the instances of Poco::Timestamp in wsd/* only. It might make my work harder;). > although it would be good to consider whether we need some > convenience wrappers around std::chrono to make it somewhat less verbose - > particularly the cast to milliseconds is very ugly. Can you please elaborate. What do you mean by convinience wrapper here? I think moving to std::chrono will take a lot of work. For e.g to move this [1], we have std::chrono::time_point::time_since_epoch whose return type is std::chrono::system_clock::duration, while the data type already being used is std::time_t. So we will have to typecast or something. Do we have to move all the present instances of Poco::Timestamp or are there some restrictions? Thank You. [1] https://opengrok.libreoffice.org/xref/online/wsd/Auth.cpp#140
Please discuss in 107038.