Bug 107230 - File property "Save preview image with this document" not restored from disk (see comment 1)
Summary: File property "Save preview image with this document" not restored from disk ...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
5.3.2.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.1.0
Keywords:
Depends on:
Blocks: File-Properties Privacy
  Show dependency treegraph
 
Reported: 2017-04-17 11:59 UTC by sebalis
Modified: 2020-10-11 14:17 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sebalis 2017-04-17 11:59:52 UTC
I’ve observed this in Writer and Calc for years. When saving a file, I always uncheck the property "Save preview image with this document" because I don’t want to waste disk space – it might be a small amount per file and not use another sector on my disk but who knows, with many documents gathering on your drive it might add up to a significant amount. As long as the document stays open, this is remembered. But after the document is closed and the reopened, the checkbox is again selected in the file properties and the preview image will get saved. I have to remember this and go through several clicks to set the property the first I save it again.

I believe that as a file is opened, the program should determine if a preview image exists and set the file property accordingly. (And of course the file should then not be in a “changed” state, which does happen if I change this property manually.)
Comment 1 Regina Henschel 2017-04-17 15:37:45 UTC
It seems, that this is not really a property of the document, but of the UI. At least I do not find a setting inside the file, which would fit to it. But your suggestion, to preset the checkbox according to the existence of a thumbnail, is reasonable to me.

If you want to disable generating of thumbnails in general, then you can use the advanced settings. Go to Tools > Options > LibreOffice > Advanded. Click button "Open Expert Configuration". Search for item "GenerateThumbnail" and toggle it to "false" by double-click. In my tests this overrules the setting "with thumbnail" in the property dialog.

I see these problems:
No help for the feature of generating or not generating of thumbnails.
The precedence of the general setting and the checkbox in the file property is not clear.
The state of the checkbox should be handled as property of the document and be saved or - as you suggest - be regenerated on loading the document.
Comment 2 sebalis 2017-04-17 16:22:44 UTC
Thank you for this helpful response, Regina. Changing the general setting suits my purpose and I’ve seen that it does what I want with one of my files. As you say, the bug itself should still be addressed. Some people will not want to disable thumbnails globally but still have use cases for keeping the file property disabled for an individual file, e.g. a file that will be emailed several times while a group of people works on it.
Comment 3 raal 2018-04-09 12:57:31 UTC
*** Bug 116833 has been marked as a duplicate of this bug. ***
Comment 4 QA Administrators 2019-04-10 02:58:21 UTC Comment hidden (obsolete)
Comment 5 sdc.blanco 2020-10-07 12:15:05 UTC
(In reply to Regina Henschel from comment #1)
> The precedence of the general setting and the checkbox in the file property
> is not clear.
> The state of the checkbox should be handled as property of the document and
> be saved or - as you suggest - be regenerated on loading the document.
@Regina and all interested -- I am updating the help page for File - Properties - General.
https://help.libreoffice.org/7.1/en-US/text/shared/01/01100200.html
https://gerrit.libreoffice.org/c/help/+/103979

At present there is no information about this control. Two questions were asked about it in Ask Libreoffice (from 2 and 3 years ago), with no reply. 

According to a Calc 6.2 guide, a thumbnail.png is saved inside the document, but it does not explain what is done with it.

Any help/suggestions about what might be appropriate to add to this help page will be appreciated.   Also, sounds like a "tip" about the Advanced setting should be included.
Comment 6 Commit Notification 2020-10-11 13:58:19 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/d9a9b1f342cd9ecb0dc95636b62ebd8d456bfc0f

Partially resolving tdf#117954 and tdf#107230 - help page updating
Comment 7 sdc.blanco 2020-10-11 14:17:17 UTC
(In reply to Commit Notification from comment #6)
> Partially tdf#107230 - help page updating
Added statement from "Getting Started Guide 6.4" about "Save preview image..." to help page.  And added "tip", based on comment 1, about how to disable thumbnail generation completely.

Maybe the first of the three problems in comment 1 is resolved (for now). Do not know the status of the other two.