Steps: 1) Open Writer 2) Draw a shape 3) Context menu > Add Text Box 4) Move mouse over undo button in toolbar and it will read 'Undo: Insert $1' Version: 5.4.0.0.alpha0+ Build ID: 44b14e8c7c485d8a3bb99d9484ac63273988b633 CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: gtk2; TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2017-04-17_03:32:22 Locale: en-US (en_US.UTF-8); Calc: group
On pc Debian x86-64 with master sources updated 2 days ago, I could reproduce this.
'Add Text Box' feature was introduced by 7f77b8a689f84a03495ac5911236b68f01ee7b24. @Miklos: Can you take a look at it when you have some time ?
It seems we'd need a rewriter here according to this bt: #0 sw::UndoManager::StartUndo (this=0x555557880ff0, i_eUndoId=SwUndoId::INSERT, pRewriter=0x0) at /home/julien/lo/libreoffice/sw/source/core/undo/docundo.cxx:268 #1 0x00007fffca1db97e in SwXText::insertTextContentWithProperties (this=0x55555bc170d8, xTextContent=uno::Reference to (SwXTextFrame *) 0x55555c02b6a0, rCharacterAndParagraphProperties=empty uno::Sequence, xInsertPosition=uno::Reference to (SwXTextCursor *) 0x55555bb961e0) at /home/julien/lo/libreoffice/sw/source/core/unocore/unotext.cxx:1433 #2 0x00007fffca1dbcc2 in SwXText::appendTextContent (this=0x55555bc170d8, xTextContent=uno::Reference to (SwXTextFrame *) 0x55555c02b6a0, rCharacterAndParagraphProperties=empty uno::Sequence) at /home/julien/lo/libreoffice/sw/source/core/unocore/unotext.cxx:1476 #3 0x00007fffc9ac874c in SwTextBoxHelper::create (pShape=0x55555bd63930) at /home/julien/lo/libreoffice/sw/source/core/doc/textboxhelper.cxx:58 #4 0x00007fffca58ca9f in SwDrawShell::Execute (this=0x55555bcc23d0, rReq=...) at /home/julien/lo/libreoffice/sw/source/uibase/shells/drawsh.cxx:370 #5 0x00007fffca58b878 in SfxStubSwDrawShellExecute (pShell=0x55555bcc23d0, rReq=...) at /home/julien/lo/libreoffice/workdir/SdiTarget/sw/sdi/swslots.hxx:8360 #6 0x00007ffff1efe45c in SfxShell::CallExec (this=0x55555bcc23d0, pFunc=0x7fffca58b84a <SfxStubSwDrawShellExecute(SfxShell*, SfxRequest&)>, rReq=...) at /home/julien/lo/libreoffice/include/sfx2/shell.hxx:210
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Repro 6.3+.
Gabor Kelemen committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/45509a5eec0d946d06f249d391dee361e91808c6%5E%21 tdf#107317 Make undo insert text box to shape display proper message It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.