Bug 107317 - On Add Text Box to shape, undo label shows 'Insert $1'
Summary: On Add Text Box to shape, undo label shows 'Insert $1'
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.4 all versions
Hardware: All All
: low trivial
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: implementationError
Depends on:
Blocks: Undo-Redo
  Show dependency treegraph
 
Reported: 2017-04-21 08:27 UTC by Yousuf Philips (jay) (retired)
Modified: 2019-01-18 16:18 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2017-04-21 08:27:02 UTC
Steps:
1) Open Writer
2) Draw a shape
3) Context menu > Add Text Box
4) Move mouse over undo button in toolbar and it will read 'Undo: Insert $1'

Version: 5.4.0.0.alpha0+
Build ID: 44b14e8c7c485d8a3bb99d9484ac63273988b633
CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2017-04-17_03:32:22
Locale: en-US (en_US.UTF-8); Calc: group
Comment 1 Julien Nabet 2017-04-21 09:12:04 UTC
On pc Debian x86-64 with master sources updated 2 days ago, I could reproduce this.
Comment 2 Xisco Faulí 2017-04-21 09:28:50 UTC
'Add Text Box' feature was introduced by 7f77b8a689f84a03495ac5911236b68f01ee7b24.

@Miklos: Can you take a look at it when you have some time ?
Comment 3 Julien Nabet 2017-04-21 09:37:34 UTC
It seems we'd need a rewriter here according to this bt:
#0  sw::UndoManager::StartUndo (this=0x555557880ff0, i_eUndoId=SwUndoId::INSERT, pRewriter=0x0) at /home/julien/lo/libreoffice/sw/source/core/undo/docundo.cxx:268
#1  0x00007fffca1db97e in SwXText::insertTextContentWithProperties (this=0x55555bc170d8, xTextContent=uno::Reference to (SwXTextFrame *) 0x55555c02b6a0, 
    rCharacterAndParagraphProperties=empty uno::Sequence, xInsertPosition=uno::Reference to (SwXTextCursor *) 0x55555bb961e0)
    at /home/julien/lo/libreoffice/sw/source/core/unocore/unotext.cxx:1433
#2  0x00007fffca1dbcc2 in SwXText::appendTextContent (this=0x55555bc170d8, xTextContent=uno::Reference to (SwXTextFrame *) 0x55555c02b6a0, 
    rCharacterAndParagraphProperties=empty uno::Sequence) at /home/julien/lo/libreoffice/sw/source/core/unocore/unotext.cxx:1476
#3  0x00007fffc9ac874c in SwTextBoxHelper::create (pShape=0x55555bd63930) at /home/julien/lo/libreoffice/sw/source/core/doc/textboxhelper.cxx:58
#4  0x00007fffca58ca9f in SwDrawShell::Execute (this=0x55555bcc23d0, rReq=...) at /home/julien/lo/libreoffice/sw/source/uibase/shells/drawsh.cxx:370
#5  0x00007fffca58b878 in SfxStubSwDrawShellExecute (pShell=0x55555bcc23d0, rReq=...) at /home/julien/lo/libreoffice/workdir/SdiTarget/sw/sdi/swslots.hxx:8360
#6  0x00007ffff1efe45c in SfxShell::CallExec (this=0x55555bcc23d0, pFunc=0x7fffca58b84a <SfxStubSwDrawShellExecute(SfxShell*, SfxRequest&)>, rReq=...)
    at /home/julien/lo/libreoffice/include/sfx2/shell.hxx:210
Comment 4 QA Administrators 2018-04-22 02:32:00 UTC Comment hidden (obsolete)
Comment 5 Timur 2019-01-18 16:18:14 UTC
Repro 6.3+.