Bug 107347 - Unable to comment on an image, frame, OLE or shape
Summary: Unable to comment on an image, frame, OLE or shape
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsDevEval, topicUI
Depends on:
Blocks: Writer-Comments Writer-Enhancements
  Show dependency treegraph
 
Reported: 2017-04-22 02:51 UTC by Yousuf Philips (jay) (retired)
Modified: 2017-06-18 06:18 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2017-04-22 02:51:28 UTC
Steps:
1) Open writer
2) Insert an image
3) Unable to comment

Version: 5.4.0.0.alpha0+
Build ID: f0340e3dca1091accdb71e0c566b96cdf9e0f791
CPU threads: 2; OS: Linux 3.19; UI render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2017-04-21_13:34:48
Locale: en-US (en_US.UTF-8); Calc: group
Comment 1 Dieter 2017-04-22 08:31:50 UTC
I can confirm it partially. If you choose the anchor "as paragraph", it is possible to add a comment, otherwise not.
Comment 2 Yousuf Philips (jay) (retired) 2017-04-22 11:09:42 UTC
Thanks for confirming dieterp and catching the partial functionality. Please do set the bug status to NEW when you do confirm a bug. :D

@Buovjaga: Leaving it up to you to set the importance. :D
Comment 3 Yousuf Philips (jay) (retired) 2017-04-22 11:42:10 UTC
@Buovjaga: Not an enhancement, its a bug as it doesnt work when it should. :D
Comment 4 Buovjaga 2017-04-22 11:58:15 UTC
(In reply to Yousuf Philips (jay) from comment #3)
> @Buovjaga: Not an enhancement, its a bug as it doesnt work when it should. :D

Where is it said that it should work?
Comment 5 Yousuf Philips (jay) (retired) 2017-04-22 17:13:55 UTC
(In reply to dieterp from comment #1)
> I can confirm it partially. If you choose the anchor "as paragraph", it is
> possible to add a comment, otherwise not.

I guess i just assumed what you had mentioned was correct (actually there isnt any 'as paragraph' anchor option, so i assume you meant 'as character') and didnt test it, but whatever anchor i set it on, i'm unable to comment.

(In reply to Buovjaga from comment #4)
> Where is it said that it should work?

I can open a docx file that has a comment selecting an image and can modify/delete the comment. But whatever, returning it back to enhancement. This is just another crucial basic feature missing from Writer that would keep me away from using it. Hopefully this can be fixed soon.
Comment 6 Heiko Tietze 2017-04-23 08:17:45 UTC
When the object is a character the comment may be related to this text. Commenting on floating objects may be restricted to how it's done in Draw/Impress. Is there a difference in the format specification, Regina?
Comment 7 Yousuf Philips (jay) (retired) 2017-04-23 08:34:55 UTC
(In reply to Heiko Tietze from comment #6)
> Commenting on floating objects may be restricted to how it's done in
> Draw/Impress. Is there a difference in the format specification, Regina?

Images in writer are treated similar to frames, which isnt available in other modules. Images in non-writer apps, are treated similar to shapes.
Comment 8 Regina Henschel 2017-04-23 13:04:33 UTC
A comment in ODF is an <office:annotation> element. It is a valid child of a <text:p> element. Have a look at the large list, where <text:p> is allowed http://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part1.html#__RefHeading__1415138_253892949

So it would be possible to implement annotations in the way, that it is an annotation to the paragraph, which belongs to an object. In that way it is already possible to comment on a text inside a Writer-frame.

An image may have a <text:p> element as child. But such child is only implemented for Draw-images not for Writer-images. And annotation inside that <text:p> are not implemented for the Draw-images.

An OLE is stored as <draw:object-ole> element. This has no <text:p> child itself. But a <draw:object-ole> is always contained inside a <draw:frame> element and that in turn allows a <draw:text-box> with <text:p>. An annotation would be possible not in the <draw:object-ole> but at its container element.

Annotation in Draw are implemented as enhanced element <officeooo:annotation> as child of <draw:page>. Such elements are specific for LibreOffice and will be ignored by other applications. I consider this a wrong way to go and think, that LibreOffice should implement annotations of the single Draw-objects.

In Calc annotations are implemented as child of <table:table-cell>, which is the other valid parent of an <office:annotation> element.

So in summary, missing annotations are no restriction from file format, but missing implementation in LibreOffice.