Bug Hunting Session
Bug 107765 - CALC: Switching language during spell-check doesn't change the text's language property
Summary: CALC: Switching language during spell-check doesn't change the text's languag...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
4.2.0.4 release
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, regression
Depends on:
Blocks: Spell-Checking
  Show dependency treegraph
 
Reported: 2017-05-11 09:15 UTC by Justin L
Modified: 2018-12-07 03:47 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
CalcSpellCheckLanguage.ods: two pairs of US/UK spelling differences (7.13 KB, application/vnd.oasis.opendocument.spreadsheet)
2017-05-11 09:15 UTC, Justin L
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Justin L 2017-05-11 09:15:30 UTC
Created attachment 133231 [details]
CalcSpellCheckLanguage.ods:  two pairs of US/UK spelling differences

During spell checking, you have the option to change the language dictionary for a specific word. The character language properties are changed once you run through the spell checker.  So running the spell check a second time finds no errors. That broke in LO4.2 for Calc.

It was broken by Kohei Yoshida.  Bibisect42max has a range of commits that fail to start at this time, so I couldn't fully bisect.  The first proven bad is https://cgit.freedesktop.org/libreoffice/core/log/?id=2528e5d9058dc7b88a55fcc69226161bccec2691&qt=range&q=6c5c0302f3624ec7c3b862c98d5514f29328bbe9

The last proven good commit is 4bc3a58a648f6c0ce95b4eb41f2cbf46175629ed, just before Kohei's spell-checker related Calc changes.

Testing procedure:
-open CalcSpellCheckLanguage.ods.  [Default Language is English US. Labour and neighbour are marked as misspellings.]
-run the spell checker.  On the misspelled words, change the Language to English UK within the spell-checker dialog.
-run the spell checker a second time.  There should be no errors, and the character font properties of those words should be marked as English UK.
Comment 1 Justin L 2017-05-11 09:19:50 UTC
CC: Kohei

separated as a clean bug report for issue raised in bug 104197.
Comment 3 QA Administrators 2018-12-07 03:47:21 UTC
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
 
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug