Bug 107845 - LO 5.4.0.0.alpha1+Master Sidebar: Gallery: 3 folders with <ressource id .... not found>
Summary: LO 5.4.0.0.alpha1+Master Sidebar: Gallery: 3 folders with <ressource id .... ...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
5.4.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:5.4.0
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-14 14:50 UTC by Jacques Guilleron
Modified: 2017-05-20 07:14 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jacques Guilleron 2017-05-14 14:50:04 UTC 
Perhaps only a missing folder name.
found in:
LO 5.4.0.0.alpha1+ Build ID: 68a1cb23ede1d4ae6195850190fca6953c30417f
CPU threads: 2; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86@39, Branch:master, Time: 2017-05-14_07:04:56
Locale: fr-FR (fr_FR); Calc: CL
And 
LO 5.4.0.0.alpha1+ Build ID: 0025fc13d805751f8eeb14febbdd0033e0a6d91e
CPU threads: 2; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86@39, Branch:master, Time: 2017-05-04_05:21:32
Locale: fr-FR (fr_FR); Calc: CL
but not in 
LO 5.4.0.0.alpha0+ Build ID: 3a36cf434fb4a967c9ea767cb7ac5f4da0502a0d
CPU threads: 2; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86@39, Branch:master, Time: 2017-04-28_06:33:58
Locale: fr-FR (fr_FR); Calc: CL
Comment 1 Julien Nabet 2017-05-14 20:48:38 UTC 
On pc Debian x86-64 with master sources updated yesterday, I could reproduce this.

I noticed these logs:
warn:legacy.osl:4656:1:tools/source/rc/resmgr.cxx:704: Cannot load resource! file:///home/julien/lo/libreoffice/instdir/program/../program/resource/galen-US.res
    Class: 273, Id: 6016.     Resource Stack:
warn:legacy.osl:4656:1:tools/source/rc/resmgr.cxx:704: Cannot load resource! file:///home/julien/lo/libreoffice/instdir/program/../program/resource/galen-US.res
    Class: 273, Id: 6037.     Resource Stack:
warn:legacy.osl:4656:1:tools/source/rc/resmgr.cxx:704: Cannot load resource! file:///home/julien/lo/libreoffice/instdir/program/../program/resource/galen-US.res
    Class: 273, Id: 6021.     Resource Stack:
Comment 2 Julien Nabet 2017-05-14 21:00:46 UTC 
Caolán: I'm not sure but I think it could be due to https://cgit.freedesktop.org/libreoffice/core/commit/?id=34f7e618ddd3399d9e7f3998e25545256255d02d

Here's a bt for one which doesn't work:
#0  ResMgr::RscError_Impl (pMessage=0x7fffedff4a7b "Cannot load resource! ", pResMgr=0x555558109550, nRT=..., nId=6016, 
    rResStack=std::__debug::vector of length 2, capacity 2 = {...}, nDepth=0) at /home/julien/lo/libreoffice/tools/source/rc/resmgr.cxx:704
#1  0x00007fffedfbdd8c in ResMgr::GetResource (this=0x555558109550, rId=..., pResObj=0x0) at /home/julien/lo/libreoffice/tools/source/rc/resmgr.cxx:1028
#2  0x00007fffedfb768e in ResId::toString (this=0x7fffffff04c0) at /home/julien/lo/libreoffice/tools/source/rc/rc.cxx:33
#3  0x00007fffefa3eef2 in GalleryThemeEntry::GalleryThemeEntry (this=0x555558172680, bCreateUniqueURL=false, rBaseURL=..., rName="private://gallery/hidden/imgppt", 
    _bReadOnly=false, _bNewFile=false, _nId=16, _bThemeNameFromResource=true) at /home/julien/lo/libreoffice/svx/source/gallery2/gallery1.cxx:104
#4  0x00007fffefa56889 in GalleryTheme::CreateThemeEntry (rURL=..., bReadOnly=false) at /home/julien/lo/libreoffice/svx/source/gallery2/galtheme.cxx:746
#5  0x00007fffefa404aa in Gallery::ImplLoadSubDirs (this=0x555558130aa0, rBaseURL=..., rbDirIsReadOnly=@0x7fffffff09a7: false)
    at /home/julien/lo/libreoffice/svx/source/gallery2/gallery1.cxx:390
#6  0x00007fffefa3f948 in Gallery::ImplLoad (this=0x555558130aa0, 
    rMultiPath="file:///home/julien/lo/libreoffice/instdir/program/../share/gallery;file:///home/julien/lo/libreoffice/instdir/user/gallery")
    at /home/julien/lo/libreoffice/svx/source/gallery2/gallery1.cxx:216
#7  0x00007fffefa3f40d in Gallery::Gallery (this=0x555558130aa0, 
    rMultiPath="file:///home/julien/lo/libreoffice/instdir/program/../share/gallery;file:///home/julien/lo/libreoffice/instdir/user/gallery")
    at /home/julien/lo/libreoffice/svx/source/gallery2/gallery1.cxx:168
#8  0x00007fffefa3f6a4 in Gallery::GetGalleryInstance () at /home/julien/lo/libreoffice/svx/source/gallery2/gallery1.cxx:188
#9  0x00007fffefa634a9 in svx::sidebar::GalleryControl::GalleryControl (this=0x55555812fcf0, pParentWindow=0x5555581335b0, __in_chrg=<optimized out>, 
    __vtt_parm=<optimized out>) at /home/julien/lo/libreoffice/svx/source/gallery2/GalleryControl.cxx:39
Comment 3 Caolán McNamara 2017-05-15 12:12:56 UTC 
yeah, looks like the ids escaped into the gallery file format at some point, fixable
Comment 4 Commit Notification 2017-05-15 12:30:22 UTC 
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=3b0915d094d795486159ed6f003f5f783fc6651f

tdf#107845 string resource ids effectively ended up in the gallery format

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Julien Nabet 2017-05-20 07:14:10 UTC 
With master sources updated yesterday, I don't reproduce this.