Bug 107967 - System path on Unix starting with double-slashes converted to single slash
Summary: System path on Unix starting with double-slashes converted to single slash
Status: RESOLVED INVALID
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-20 07:39 UTC by Chris Sherlock
Modified: 2024-11-09 13:42 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Sherlock 2017-05-20 07:39:04 UTC
It appears that in the OSL code that we do some sanity checking for Unix system paths and convert double slashes (//) to single slash. However, if a system path starts with a double-slash then starting with double-slashes we are still converting this to a single slash.

That's unfortunately not valid. POSIX states the following:

"If a pathname begins with two successive <slash> characters, the first component following the leading <slash> characters may be interpreted in an implementation-defined manner, although more than two leading <slash> characters shall be treated as a single <slash> character."

http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap04.html#tag_04_13

In other words, the following path...

//path/to/file.txt

it becomes:

//path/to/file.txt

However, the following path...

///path/to/file.txt

this becomes:

/path/to/file.txt
Comment 1 Chris Sherlock 2017-05-20 08:13:54 UTC
It appears that the code comments are the issue here, they talk about double-slashes but actually, the code correctly checks for multiple slashes and changes to a single slash. 

I've now added a unit test to check for this.
Comment 2 Chris Sherlock 2017-05-20 08:14:55 UTC
Argh - wrong bug closed. Sorry, this is still an issue!
Comment 3 Xisco Faulí 2017-06-26 18:06:54 UTC
Moving to NEW
Comment 4 Xisco Faulí 2017-10-12 08:08:36 UTC
Dear Chris Sherlock,
This bug has been in ASSIGNED status for more than 3 months without any activity. Resetting it to NEW.
Please assigned it back to yourself if you're still working on this.
Comment 5 QA Administrators 2018-10-13 03:14:41 UTC Comment hidden (obsolete)
Comment 6 QA Administrators 2020-10-13 04:47:05 UTC Comment hidden (obsolete)
Comment 7 QA Administrators 2022-10-14 03:32:54 UTC Comment hidden (obsolete)
Comment 8 QA Administrators 2024-10-14 03:13:39 UTC Comment hidden (obsolete)
Comment 9 Chris Sherlock 2024-11-09 13:42:11 UTC
Non-issue.