Bug 108777 - Undo doesnt restore original shape size after setting 'Resize shape to fit text'
Summary: Undo doesnt restore original shape size after setting 'Resize shape to fit text'
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.2.0.4 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: implementationError
Depends on:
Blocks: Undo-Redo Text-Attributes-Dialog Shape-Textbox
  Show dependency treegraph
 
Reported: 2017-06-25 22:18 UTC by Yousuf Philips (jay) (retired)
Modified: 2023-09-08 21:48 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2017-06-25 22:18:12 UTC
Steps:
1. Open Writer
2. Draw a shape
3. Double-click on shape to enter edit mode and type some words
4. Right-click > Text Attributes or Format > Text Box and Shape > Text Attributes
5. Check 'Resize shape to fit text' and click 'OK'
6. Click outside of the shape to leave edit mode
7. Press undo
8. Text gets removed, shape doesnt return to original size, and 'Resize shape to fit text' is still enabled

Version: 6.0.0.0.alpha0+
Build ID: 1f4d7fc8618828222d7f4447daed4c3361edeea6
CPU threads: 2; OS: Linux 4.4; UI render: default; VCL: gtk2; 
Locale: en-US (en_US.UTF-8); Calc: group
Comment 1 Xisco Faulí 2017-06-26 11:59:48 UTC
Confirmed in

Version: 6.0.0.0.alpha0+
Build ID: 08f6f9dded1b142b858c455da03319abac691655
CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: gtk2; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group
Comment 2 QA Administrators 2018-11-26 03:36:19 UTC Comment hidden (obsolete)
Comment 3 Gerald Pfeifer 2018-11-26 07:31:49 UTC
This bug is still present, Version: 6.1.3.2.
Comment 4 QA Administrators 2019-11-27 03:45:37 UTC Comment hidden (obsolete)
Comment 5 Gerald Pfeifer 2019-11-27 10:48:39 UTC
Still present in Version: 6.5.0.0.alpha0+
Build ID: 122468bf97f1ea456274991103a13489b8d5df58
CPU threads: 4; OS: Linux 5.3; UI render: default; VCL: gtk3; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-11-22_13:38:19
Comment 6 Gerald Pfeifer 2020-03-28 10:37:50 UTC
This appears to have been fixed since I last tested in November 2019.

Version: 7.0.0.0.alpha0+
Build ID: 4bca67d21e418eb3981cd63390bf2cb401dabe13
CPU threads: 4; OS: Linux 5.5; UI render: default; VCL: gtk3; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2020-03-08_02:59:34
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded
Comment 7 Xisco Faulí 2020-03-30 09:40:01 UTC
Still reproducible in

Version: 7.0.0.0.alpha0+
Build ID: 9b784a74a2f09e9eb9a0fd41d58c1f6b47ee6ee6
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

@Gerald, could you please double check it ?
Comment 8 Gerald Pfeifer 2020-03-30 11:54:43 UTC
(In reply to Xisco Faulí from comment #7)
> Still reproducible in
> 
> Version: 7.0.0.0.alpha0+
> Build ID: 9b784a74a2f09e9eb9a0fd41d58c1f6b47ee6ee6
> CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; 
> Locale: en-US (en_US.UTF-8); UI-Language: en-US
> Calc: threaded
> 
> @Gerald, could you please double check it ?

I had done two or three iterations on Saturday before closing it,
but methodically going through this again and again now I believe I
see what is crucial:

 Step 3. Double-click on shape to enter edit mode and type some words

does not make a difference, i.e., simply drawing the shape and typing also
reproduces the issue.

However, *not* selecting the shape again (either by clicking elsewhere and
then selecting the shape, or directly selecting the shape) before 

  Step 4. Format > Text Box and Shape > Text Attributes

is crucial to reproduce.

(On Saturday I did that followed by "Right-click > Text Attributes", in
which case it does not reproduce.  Perhaps remove that option from the
description of Step 4?)

@Xisco, does that make sense?
Comment 9 Dieter 2021-02-01 07:12:18 UTC
Same result with "Word Wrap Text in Shape" (see bug 139703)
Comment 10 QA Administrators 2023-02-02 03:20:17 UTC Comment hidden (obsolete)
Comment 11 Gerald Pfeifer 2023-02-02 12:28:00 UTC
Still there with Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: b2bd60b8c1937502857e12b0eea42323fd2353c8
CPU threads: 8; OS: Linux 6.1; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US

Summary of specific steps:

1. Open Writer
2. Draw a shape and (no clicking necessary) type some text
3. "Format" -> "Text Box and Shape" -> "Text Attributes..."
4. Check "Resize shape to fit text" and "OK"
5. Observe how the shape shrinks
6. Click outside the shape to leave edit mode
7. Undo
8. Observe how the text gets removed, alas the shape fails to return to
   its original size and "Resize shape to fit text" is still checked.
Comment 12 Stéphane Guillou (stragu) 2023-09-08 21:48:10 UTC
This issue is not inherited:
- In OOo 3.3, the option was greyed out.
- Before 5.2.0.1, the option would not work
- Since 5.2.0.1 and what I assume is Caolán fix for bug 93135, the feature works but the issue described here can be reproduced. (Checked with linux-64-releases bibisect repo.)

So let's call it an implementation error.
Copying Caolán in, in case you are interested.