Bug 108828 - Improve signing with password protected gpg keys
Summary: Improve signing with password protected gpg keys
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
6.0.0.0.alpha0+
Hardware: All All
: medium enhancement
Assignee: Samuel Mehrbrodt (allotropia)
URL:
Whiteboard: target:25.2.0 target:24.8.0.2
Keywords:
Depends on:
Blocks: Digital-Signatures OpenPGP
  Show dependency treegraph
 
Reported: 2017-06-28 08:26 UTC by Samuel Mehrbrodt (allotropia)
Modified: 2024-07-15 08:38 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Samuel Mehrbrodt (allotropia) 2017-06-28 08:26:09 UTC
When signing with a password protected gpg key, there are some issues:

* If you cancel the password dialog, you should get back to the certificate selector. Currently the certificate dialog will be closed.
* If you afterwards try to sign with another key, you will be asked to enter the password of the former key again.
* When there already is an existing signature and you try to sign with a password protected signature, then cancel the password dialog, the signature will be created anyway.
Comment 1 Buovjaga 2017-06-29 14:06:55 UTC
Sure, let's do it.
Comment 2 Commit Notification 2024-07-11 18:58:43 UTC
Samuel Mehrbrodt committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b7a6d5752a3f60dc29cde6ea05ee6b7112dc4780

tdf#108828 Show certificate selector again after cancelling password dialog

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Samuel Mehrbrodt (allotropia) 2024-07-11 19:15:17 UTC
> * If you cancel the password dialog, you should get back to the certificate selector. Currently the certificate dialog will be closed.

This is fixed with above commit.
Comment 4 Commit Notification 2024-07-15 04:26:45 UTC
Samuel Mehrbrodt committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0e1592094e7463b07e9bc9725b4c85d5244bf997

tdf#108828 Prevent leaking keys from previous signing sessions

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Samuel Mehrbrodt (allotropia) 2024-07-15 04:35:56 UTC
> * If you afterwards try to sign with another key, you will be asked to enter the password of the former key again.
> * When there already is an existing signature and you try to sign with a password protected signature, then cancel the password dialog, the signature will be created anyway.

These two problems are fixed with the second commit.
Comment 6 Commit Notification 2024-07-15 07:30:13 UTC
Samuel Mehrbrodt committed a patch related to this issue.
It has been pushed to "libreoffice-24-8":

https://git.libreoffice.org/core/commit/ba2d46a55e601007be9d06b1980a4d05957a2908

tdf#108828 Show certificate selector again after cancelling password dialog

It will be available in 24.8.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2024-07-15 08:38:33 UTC
Samuel Mehrbrodt committed a patch related to this issue.
It has been pushed to "libreoffice-24-8":

https://git.libreoffice.org/core/commit/e9ebcb15f0cb458da0a0c7583fa740c063a5e107

tdf#108828 Prevent leaking keys from previous signing sessions

It will be available in 24.8.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.