Bug 109156 - LibO hangs when clicking "OK" in the AutoCorrect replacement table
Summary: LibO hangs when clicking "OK" in the AutoCorrect replacement table
Status: RESOLVED DUPLICATE of bug 108835
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Linguistic (show other bugs)
Version:
(earliest affected)
6.0.0.0.alpha0+
Hardware: All All
: medium critical
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2017-07-17 12:05 UTC by tommy27
Modified: 2017-07-18 05:36 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:

Attachments
AutoCorrect large database (206K entries) that triggers the bug (3.81 MB, application/zip)
2017-07-17 12:21 UTC, tommy27 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description tommy27 2017-07-17 12:05:51 UTC 
Description:
tested under Win7 x64 using LibO Version: 6.0.0.0.alpha0+

Build ID: 4f17445c12dc26c4881c4e486215b58d26515f8d
CPU threads: 8; OS: Windows 6.1; UI render: GL; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-07-16_23:03:56
Locale: it-IT (it_IT); Calc: group

Closing the autocorrect replacement table is no longer possible and LibO hangs everytime either if you add a new entry or just click "ok" without entering any item. The "Cancel" button still works fine; it closes the table with no hang.

This is a regression since the "OK" button works fine in LibO 5.3.4.2.

Steps to Reproduce:
1- open a Writer document
2- click on "Tools/AutoCorrect/Autocorrect options"
3- one the AutoCorrect replacement table shows up, click the "Ok" button at the bottom

Actual Results:  
the replacement table doesn't close and LibO hangs.

Expected Results:
the replacement table closes.


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:49.0) Gecko/20100101 Firefox/49.0 SeaMonkey/2.46
Comment 1 Telesto 2017-07-17 12:18:13 UTC 
Looks like a dupe of bug 108835
Comment 2 tommy27 2017-07-17 12:21:57 UTC 
Created attachment 134684 [details]
AutoCorrect large database (206K entries) that triggers the bug

in order to reproduce the bug you should use a very large AutoCorrect entry list such as the one I attached here.

this "acor_it-IT.dat" contains more than 206000 entries and you have to place it in the user profile under the path: "C:\Users\Utente\AppData\Roaming\LibreOfficeDev\4\user\autocorr"  (the exact name may vary according to your computer)

It seems that closing the AutoCorrect table with the "OK" button when you have a huge list such as this one makes LibO hang... 

if the acor_xx-YY.dat file you are displaying is small you don't see the issue.
Comment 3 tommy27 2017-07-17 12:31:26 UTC 
maybe a side effect of the fix for Bug 99071?
Comment 4 Xisco Faulí 2017-07-17 12:46:47 UTC 
I think it's a dupe of bug 108835

*** This bug has been marked as a duplicate of bug 108835 ***
Comment 5 tommy27 2017-07-17 13:16:44 UTC 
look similar.

interestingly I wasn't able to reproduce Bug 108835 using "TinderBox: Win-x86@42, Branch:master, Time: 2017-06-13_23:06:37"

while Cor reported it with "TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2017-06-27_23:55:07"

and telesto confirmed it with: "TinderBox: Win-x86@42, Branch:master, Time: 2017-06-28_00:47:42"
Comment 6 tommy27 2017-07-18 05:24:11 UTC 
(In reply to tommy27 from comment #3)
> maybe a side effect of the fix for Bug 99071?

I can reproduce the issue even with Version: 6.0.0.0.alpha0+
Build ID: a2e670df4efb219a1f92946d7a2887bdd0f88f5d
CPU threads: 4; OS: Windows 6.29; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-07-13_23:50:53
Locale: it-IT (it_IT); Calc: group

so it seems the problem with the "OK" button of the autocorrect replacement table was already present before Bug 99071 got fixed (the committ is from the day after my tested build). 

the guilty committ must be the one Xisco pointed out in the bibisect report from bug 108835