In order to make favorite characters more prominent in the grid of special characters I suggest to highlight those items. It shouldn't be too flashy but there might be a nice background color defined in the theme (do not hard code colors).
I would also accept a WFM.
Hi Heiko! I changed the highlighting and the border. Is there any example how to add a new color to the codebase in the settings of LIBO? Should this be an expert setting or hust a "normal" color in the color options pane?
Cool, show me :-)
Adding colors is tedious and IMO pointless, not to say wrong, for one particular option.
Had a hard time to remember why I wrote this ticket. Point is that the long list with all characters contains the favorites too- and we should indicate those. Could imagine a border with the highlight color or background lighter/darker by 10%, or so.
Created attachment 178798 [details]
Like mentioned in https://nextcloud.documentfoundation.org/s/asdc9Km2AamqDg6
Nothing is lost :-).
I like your solution (would have been nicer if the border was outside but this might be much more difficult to code). Please make sure it works well if the item is selected.
If you are looking for some replacement to COL_RED, SwViewOption::GetFieldShadingsColor() would be grey by default and GetSettings().GetStyleSettings().GetHighlightColor() blueish at most system themes.
As commented before I don't understand another color option as good solution but here is a prototype for implementation https://gerrit.libreoffice.org/c/core/+/128553.
Do you have an example how it would look like if the border is drawn outside?
I will try some colors in the settings and upload them so we can decide which fits the needs.
(In reply to Andreas Heinisch from comment #5)
> Do you have an example how it would look like if the border is drawn outside?
What I mean with "outside" is the thin black (in my case, with bright themes probably grey) line from the grid.
Created attachment 178822 [details]
Overview of different solutions
IMO, using COL_LIGHTRED as an outside border may be the best solution. However, the color is hardcoded then ...
Created attachment 178823 [details]
Is this the correct implementation of the outside border? Or should it be "outside" of the black rectangle?
Created attachment 178824 [details]
Double Outside Border
(In reply to Andreas Heinisch from comment #7)
> IMO, using COL_LIGHTRED as an outside border may be the best solution.
> However, the color is hardcoded then ...
Agreed, and we can change this later if the color is sub-optimal under some scenarios like dark themes.
The “double outside border” proposal looks the best to me, but I don’t think we should be using red as that colors connotes errors or destructive actions… Why not use a gentle yellow color, maybe as background, such as the one from the infobar? Or just the highlight color, like in the Calc spreadsheets, with the selected-cell background color being a lighter hue of that.
Proposed patch: https://gerrit.libreoffice.org/c/core/+/131446
Created attachment 178856 [details]
Background color like for menu items
Created attachment 178857 [details]
Background color like for hover items
OK, the yellow version isn’t that discernible; the blue one was better :)
And yellow has the meaning warning. Let's do with the hover color.
(Similar UI is the Stylist where a style is active in the document but it should be possible to select another for modification. IIRC, I suggested to use grey and highlight/blue, see bug 94427.)
Created attachment 178871 [details]
Background color like for selected menu items
The only thing that bothers me is that if we solve the highlighting of glyphs from the choosen subset and of favorites, how we should distinguish between favorite characters and/or the subset itself.
Check the document at https://nextcloud.documentfoundation.org/s/asdc9Km2AamqDg6 second page.
(In reply to Andreas Heinisch from comment #17)
> ... how should we distinguish between favorite characters and/or the subset itself.
True, if the subset needs one attribute the favorite requires another one.
a) use background and border color (as in the mockup with blue and red; we could go with a bold or darker blue instead of the red)
b) indicate favorites with a decorator image like a small star in the lower right corder
c) use hatches for favorites
d) use a (faint) blue border for the subset and highlight the favorites
e) "dim" characters that are not in the current subset (lighter font color - or darker in case of dark backgrounds)
Created attachment 178873 [details]
Proposal with blue color
Heiko, maybe you could create a new mockup, so I can check if I met all the requirements.
(In reply to Andreas Heinisch from comment #19)
> Created attachment 178873 [details]
> Proposal with blue color
This LGTM. Push it and let's see how it work on the various OS/DE.
Andreas Heinisch committed a patch related to this issue.
It has been pushed to "master":
tdf#109214 - Highlight the favorites in the grid of special characters
It will be available in 7.4.0.
The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
Affected users are encouraged to test the fix and report feedback.
Does there exist a bug report for the hightlight of the subset of the font like shown in https://nextcloud.documentfoundation.org/s/asdc9Km2AamqDg6? I could not find it.
(In reply to Andreas Heinisch from comment #22)
> Does there exist a bug report for the hightlight of the subset of the font...
Apparently not. Many thanks for the patch!