Bug 109276 - share\gallery\sg24.sdv & sg24.thm sg24.sdg are accessed around 644 times in total when adding a shape
Summary: share\gallery\sg24.sdv & sg24.thm sg24.sdg are accessed around 644 times in t...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsDevAdvice
Depends on:
Blocks: Too-Much-File-Access
  Show dependency tree / graph
 
Reported: 2017-07-22 17:42 UTC by Telesto
Modified: 2024-12-02 20:01 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:

Attachments
Backtrace & a few Instrument screenshots (1.26 MB, application/x-zip-compressed)
2017-09-06 09:33 UTC, Telesto 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2017-07-22 17:42:13 UTC 
Description:
share\gallery\sg24.sdv & sg24.thm sg24.sdg are accessed around 644 times in total when adding a shape 

Steps to Reproduce:
1. Open Process Monitor ad set the filter to Path | Contains| share\gallery
2. Open Writer or Draw or Calc or Impress
3. Insert -> Shape -> Basic -> Rectangle

Actual Results:  
share\gallery\sg24.sdv & sg24.thm & sg24.sdg are accessed around 644 times in total when adding a shape

Expected Results:
Should happen at all. 


Reproducible: Always

User Profile Reset: No

Additional Info:
Version: 6.0.0.0.alpha0+
Build ID: a9588baca8137f51e2ca72e40b1f448b0e1885d1
CPU threads: 4; OS: Windows 6.19; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-07-21_02:58:26
Locale: nl-NL (nl_NL); Calc: CL

and in:
Version: 5.2.5.0.0+
Build ID: a4d4fbeb623013f6377b30711ceedb38ea4b49f8

but not with
Version: 5.0.0.5
Build ID: 1b1a90865e348b492231e1c451437d7a15bb262b
Locale: nl-NL (nl_NL)
CPU Threads: 4; OS Version: Windows 6.2; UI Render: default; 
TinderBox: Win-x86@62-merge-TDF, Branch:libreoffice-5-2, Time: 2016-12-24_14:43:55
Locale: nl-NL (nl_NL); Calc: CL


User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0
Comment 1 Regina Henschel 2017-07-23 12:35:01 UTC 
I do not see such activities. I'm working with Windows 7.
Comment 2 Telesto 2017-07-24 08:18:34 UTC 
I forgot step 4
4. Actually draw the rectangle
Comment 3 Buovjaga 2017-08-15 10:20:41 UTC 
I confirm. Yet, we should get a developer's opinion.

Win 7 Pro 64-bit Version: 6.0.0.0.alpha0+ (x64)
Build ID: bec5a2ac82b5178f6e765494c2003febe8ab51da
CPU threads: 4; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2017-08-12_23:35:00
Locale: fi-FI (fi_FI); Calc: CL
Comment 4 Telesto 2017-09-06 09:33:19 UTC 
Created attachment 136060 [details]
Backtrace & a few Instrument screenshots

A Instrument backtrace with symbols & a few screenshots of Xcode Instruments containing a few code snippets of probably relevant parts.

I can't make that much of it, but hopefully someone else can.
Comment 5 Telesto 2017-09-28 11:58:41 UTC 
~/bibisect-win32-5.1
$ git bisect good 8e118822e67b622218480962b7f96c8f532bbdc2 is the first bad commit
commit 8e118822e67b622218480962b7f96c8f532bbdc2
Author: Norbert Thiebaud <nthiebaud@gmail.com>
Date:   Wed Oct 7 15:34:16 2015 -0700

    source 3080e4c09b7c4894d4f0f52c9beed4298f3fd23f

    source 3080e4c09b7c4894d4f0f52c9beed4298f3fd23f

:040000 040000 5e4e90a26a948b79a95d0a6889e3b546b7bc0d1e 0a68a0821e5d356e4fe2f0764a24c01c351564c7 M      instdir

~/bibisect-win32-5.1
$ git bisect log
# bad: [05d11632892a322664fb52bac90b2598b7fb7544] source 5616d22b57a9a5e57d545e912e029162a230829b
# good: [c1efd324c6ad448ac9edb030dc9738b9e6899e4d] source ab465b90f6c6da5595393a0ba73f33a1e71a2b65
git bisect start 'origin/master' 'oldest'
# good: [97526ab777da7e58ce283c05498262ecdd4d6f7f] source 4ea70f87f7a2b61eda6e5ab1f48debf6fcfadc1f
git bisect good 97526ab777da7e58ce283c05498262ecdd4d6f7f
# bad: [86fee7ded76d9c2756ccab6aef160a2d7fab0ab6] source 1b62841b1859ae3443e2bf1ebe99ec3d6afb6cc2
git bisect bad 86fee7ded76d9c2756ccab6aef160a2d7fab0ab6
# good: [ecd02a00b3cb479dcecd6a2539e2f4140cd8158f] source f45ac62a20b80033a7f5ccdef4a6c116b6fece24
git bisect good ecd02a00b3cb479dcecd6a2539e2f4140cd8158f
# bad: [f079ad05806f066d91ce750402631a16eada301e] source e695f173ccd3cd6c01c7191b98bb452fd387eb6d
git bisect bad f079ad05806f066d91ce750402631a16eada301e
# good: [b457317e967924fe178d778f43db995a85b5723b] source a2aed0e866c8e4eb308b90967fcd81e70bcdf7fb
git bisect good b457317e967924fe178d778f43db995a85b5723b
# bad: [bd812fbe6b97b1f81a2ca506d4fa2a5c4989747b] source e1208d37e4d24bc15e147ff63eb39c12f09a414b
git bisect bad bd812fbe6b97b1f81a2ca506d4fa2a5c4989747b
# bad: [d1af34e8951dd5b5acd11096bd696a8430096f45] source 6d7353deb891b6cb49e98fec5de2ad0f1bc86c24
git bisect bad d1af34e8951dd5b5acd11096bd696a8430096f45
# good: [6316991bbb6d5b638ffd62a7a52d4ddfe23a8cae] source 70409a450f62736885cf596991cdb7b42a19a88a
git bisect good 6316991bbb6d5b638ffd62a7a52d4ddfe23a8cae
# good: [d6df5572c1b2d00618c4a4d4c0536d07f52123eb] source 3eff65e78a3a90b07c7a01ff26736fd25996e476
git bisect good d6df5572c1b2d00618c4a4d4c0536d07f52123eb
# bad: [1afd8e1ca5ce57526a3ec359e3ae993e848589a7] source 6ca355d281133c1e0e54df4e4710a4e99bc38c17
git bisect bad 1afd8e1ca5ce57526a3ec359e3ae993e848589a7
# bad: [4bd2ae3fd6dcbde4eb8ae0b53e3e1ed7879d07b3] source 4c2339d8177d610cc23619e787c1517ce8e8afd7
git bisect bad 4bd2ae3fd6dcbde4eb8ae0b53e3e1ed7879d07b3
# bad: [8e118822e67b622218480962b7f96c8f532bbdc2] source 3080e4c09b7c4894d4f0f52c9beed4298f3fd23f
git bisect bad 8e118822e67b622218480962b7f96c8f532bbdc2
# good: [41f20fa9e2db9f8cd921819e6b6f2f9909680e11] source 884606e74bee007c0286a16fb8aa8fc8af9a8779
git bisect good 41f20fa9e2db9f8cd921819e6b6f2f9909680e11
# first bad commit: [8e118822e67b622218480962b7f96c8f532bbdc2] source 3080e4c09b7c4894d4f0f52c9beed4298f3fd23f
Comment 6 Telesto 2017-11-20 08:46:08 UTC 
Adding CC to Yousuf Philips
Comment 7 Yousuf Philips (jay) (retired) 2017-11-20 09:16:30 UTC 
(In reply to Telesto from comment #5)
> ~/bibisect-win32-5.1
> $ git bisect good
> 8e118822e67b622218480962b7f96c8f532bbdc2 is the first bad commit
> commit 8e118822e67b622218480962b7f96c8f532bbdc2
> Author: Norbert Thiebaud <nthiebaud@gmail.com>
> Date:   Wed Oct 7 15:34:16 2015 -0700
> 
>     source 3080e4c09b7c4894d4f0f52c9beed4298f3fd23f
> 
>     source 3080e4c09b7c4894d4f0f52c9beed4298f3fd23f
> 
> :040000 040000 5e4e90a26a948b79a95d0a6889e3b546b7bc0d1e
> 0a68a0821e5d356e4fe2f0764a24c01c351564c7 M      instdir
> 

Doesnt seem correct as there is no commit with this id - https://cgit.freedesktop.org/libreoffice/core/commit/?id=8e118822e67b622218480962b7f96c8f532bbdc2

@Raal, @Xisco, @Aron: Can one of you guys try to bibisect this.

(In reply to Telesto from comment #6)
> Adding CC to Yousuf Philips

This isnt something i'm able to tackle as i'm just familiar with the icon code :D
Comment 8 Buovjaga 2017-11-20 09:31:45 UTC 
It's the source sha you should be looking at: https://cgit.freedesktop.org/libreoffice/core/commit/?id=3080e4c09b7c4894d4f0f52c9beed4298f3fd23f

tdf#91097 Substitute rectangle and ellipse uno commands
Comment 9 Yousuf Philips (jay) (retired) 2017-11-20 15:27:31 UTC 
(In reply to Buovjaga from comment #8)
> It's the source sha you should be looking at:
> https://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=3080e4c09b7c4894d4f0f52c9beed4298f3fd23f

Doesnt make sense that Maxim replacing some entries in the toolbar and menubar xml files would cause such a bug.
Comment 10 Yousuf Philips (jay) (retired) 2017-11-20 15:30:59 UTC 
To clarify, those shape .uno commands (.uno:BasicShapes.rectangle, .uno:BasicShapes.ellipse) are available in Basic Shapes group button, so if this is an issue related to those 2 commands, then it would likely be inherited from OOo.
Comment 11 Telesto 2017-11-20 16:13:06 UTC 
(In reply to Yousuf Philips (jay) from comment #10)
> To clarify, those shape .uno commands (.uno:BasicShapes.rectangle,
> .uno:BasicShapes.ellipse) are available in Basic Shapes group button, so if
> this is an issue related to those 2 commands, then it would likely be
> inherited from OOo.

Should have looked further.. indeed, inherited from OOo.
Comment 12 QA Administrators 2018-11-21 03:44:19 UTC Comment hidden (obsolete)
Comment 13 QA Administrators 2020-11-21 04:22:22 UTC Comment hidden (obsolete)
Comment 14 QA Administrators 2022-11-22 03:35:20 UTC Comment hidden (obsolete)
Comment 15 QA Administrators 2024-11-22 03:15:22 UTC Comment hidden (obsolete)
Comment 16 Buovjaga 2024-12-02 20:01:27 UTC 
The file name seems to be symbolshapes.(sdv|thm|sdg) now.

Version: 25.2.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 03a701516ea94b786ba6e1b35bf6dad22cceced5
CPU threads: 2; OS: Windows 11 X86_64 (10.0 build 22621); UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded