The Hyperlink dialog closes immediately after clicking OK for the the warning dialog: Please type in a valid file name. Not quite practical
Steps to Reproduce:
1. Open Writer
2. Type some text and select it
3. Press CTRL+K
4. Select "New document" and press OK
5. A warning popups up: Please type in a valid file name. Press OK -> Dialog closes
The dialog is closed after a warning dialog
The dialog should stay open to follow up the advise given in the Warning Dialog
User Profile Reset: No
Build ID: 343d40206a929969e1755b073edae91cc4bd9751
CPU threads: 4; OS: Windows 6.19; UI render: default;
TinderBox: Win-x86@42, Branch:master, Time: 2017-07-26_05:51:20
Locale: nl-NL (nl_NL); Calc: CL
User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0
Regression introduced by:
author Thomas Arnhold <firstname.lastname@example.org> 2014-08-17 11:34:20 (GMT)
committer Thomas Arnhold <email@example.com> 2014-08-23 02:33:06 (GMT)
commit f4246fab77113147b36706a1f3d93e8724ff826b (patch)
parent c8a3b2d14c4942aa7d0d325a7b925f93b985161c (diff)
fdo#56456 fdo#75578 fdo#63271 fdo#75805 Improve hyperlink dialog
* Rename "Back" to "Reset" like in other dialogs (eg. Writer - Format - Character).
* Apply-Button, which reflects the old behavior of the dialog, and doesn't
close it automatically.
* Added an OK-Button, which applies the changes made and automatically closes the
With this both use cases should be handled:
* Inserting one single URI with simple close.
* Modifying multiple URIs without closing the dialog.
Hopefully all users are happy with this ;)
Bisected with bibisect-44max
Adding Cc: to Thomas Arnhold
** Please read this message in its entirety before responding **
To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.
There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.
If you have time, please do the following:
Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/
If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.
Please DO NOT
Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not
appropriate in this case)
If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/
2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword
Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa
Thank you for helping us make LibreOffice even better for everyone!
I could not reproduce in 6.3 or 6.4 on gtk3 linux with comment 0's STR. I never get a warning dialog on an empty "New Document" hyperlink.
(In reply to Justin L from comment #4)
> I never get a warning dialog on an empty "New Document" hyperlink.
Oops. I was always choosing "Document" instead of "New Document".
Proposed patch at https://gerrit.libreoffice.org/c/core/+/127010
Gabor Kelemen committed a patch related to this issue.
It has been pushed to "master":
tdf#109390 Warn about empty New Document only on Apply, not OK
It will be available in 7.4.0.
The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
Affected users are encouraged to test the fix and report feedback.
(In reply to Commit Notification from comment #7)
Hm, is this still consistent?
On all other tabs, both Apply and OK just do nothing when the address (different in different cases) is empty.
The question is if doing *nothing* is OK there. But IMO all tabs should *at least* be consistent; if empty name does nothing on OK, it should also do nothing on Apply.
And then - *maybe* - a warning would be useful, but *both for OK and apply*, and *on all tabs*. That would be a different issue, and would need UX evaluation.
(In reply to Mike Kaganski from comment #8)
> (In reply to Commit Notification from comment #7)
> Hm, is this still consistent?
> On all other tabs, both Apply and OK just do nothing when the address
> (different in different cases) is empty.
> The question is if doing *nothing* is OK there. But IMO all tabs should *at
> least* be consistent; if empty name does nothing on OK, it should also do
> nothing on Apply.
> And then - *maybe* - a warning would be useful, but *both for OK and apply*,
> and *on all tabs*. That would be a different issue, and would need UX
I'll file a continuation bug in a moment, thanks for bringing it up.